From patchwork Thu Dec 24 03:42:10 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zidan Wang X-Patchwork-Id: 7915221 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id ABA249F38E for ; Thu, 24 Dec 2015 03:39:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B787320421 for ; Thu, 24 Dec 2015 03:39:39 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id 590D9203B7 for ; Thu, 24 Dec 2015 03:39:38 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id 0EB802665D9; Thu, 24 Dec 2015 04:39:37 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAD_ENC_HEADER,BAYES_00, RCVD_IN_DNSWL_LOW, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 1604D26659F; Thu, 24 Dec 2015 04:39:29 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 1192F2665A6; Thu, 24 Dec 2015 04:39:28 +0100 (CET) Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0144.outbound.protection.outlook.com [157.56.111.144]) by alsa0.perex.cz (Postfix) with ESMTP id 97D28266572 for ; Thu, 24 Dec 2015 04:39:20 +0100 (CET) Received: from BN3PR0301CA0061.namprd03.prod.outlook.com (10.160.152.157) by CY1PR0301MB1260.namprd03.prod.outlook.com (10.161.213.12) with Microsoft SMTP Server (TLS) id 15.1.361.13; Thu, 24 Dec 2015 03:39:18 +0000 Received: from BL2FFO11FD053.protection.gbl (2a01:111:f400:7c09::169) by BN3PR0301CA0061.outlook.office365.com (2a01:111:e400:401e::29) with Microsoft SMTP Server (TLS) id 15.1.361.13 via Frontend Transport; Thu, 24 Dec 2015 03:39:17 +0000 Authentication-Results: spf=permerror (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; Received-SPF: PermError (protection.outlook.com: domain of freescale.com used an invalid SPF mechanism) Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD053.mail.protection.outlook.com (10.173.161.181) with Microsoft SMTP Server (TLS) id 15.1.355.15 via Frontend Transport; Thu, 24 Dec 2015 03:39:17 +0000 Received: from b50113.ap.freescale.net (b50113.ap.freescale.net [10.192.241.68]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id tBO3dCtX016958; Wed, 23 Dec 2015 20:39:13 -0700 From: Zidan Wang To: Date: Thu, 24 Dec 2015 11:42:10 +0800 Message-ID: X-Mailer: git-send-email 1.9.1 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD053; 1:kxO5ALnc0dMv6mrVN/Ifwdb/J5m8g/GZFDJuhZH18zmLZWD7/eih4C59+8YQMwX1OXdCLz0OXX4Wsc8CmMQzA+fIfII3gA2CKfStHcppz0lIuUaQurlYvUhq0HNq+g7WoAy8iARC0zWpkw4REn9zf+S9OtT2AweCeScM/5uJCxOPoMCe0m59k/Qw+1e4vbRGU6BRFkhaEUChDzYqDN5t4pYA/oQ6mBvKrKiQ85+DuhO3tH9XaW7Vi3YP0f2UlUf9Vkc3lWFStHykcSSlwp4Wtsd7iU18gWrsl7mDQRC8Sqjuph/mc/I65uCurkqFgpDEJgMu1Vp83s0RoeSNvyE+XbMltVjBZBk/OAravmNo7awF0fFeTp5ku1bo1uXK36BZLKRjdT/Lctlm6Ujx+xLpmu67CygRL0TvfS8CVHEcZeYIn/zbawfeWAKoPxDXMoM0 X-Forefront-Antispam-Report: CIP:192.88.158.2; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(448002)(3190300001)(189002)(199003)(118296001)(586003)(92566002)(19580405001)(4001430100002)(106466001)(6806005)(104016004)(50226001)(77096005)(5008740100001)(1096002)(1220700001)(5001960100002)(11100500001)(19580395003)(107886002)(97736004)(36756003)(50466002)(110136002)(33646002)(2351001)(229853001)(48376002)(5003940100001)(69596002)(86362001)(189998001)(50986999)(87936001)(47776003)(81156007)(85326001); DIR:OUT; SFP:1102; SCL:1; SRVR:CY1PR0301MB1260; H:az84smr01.freescale.net; FPR:; SPF:PermError; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1260; 2:gtaXnOKnJwQ31mbTyo2Ap+40mgT1wG0aRo/f+Y7ZCEsesbakjrUaSi6emoKgvNg6pNWuojLzvXjIo/xkU36wVp3Kq1hIxig+0bZqSZrfohewJyJuhjhxNWuWJYCWkNDC9sk16ZVblWp/Lad2V8Fnow==; 3:ShEDk0ymMeL/uBXfN9dAXSdu+JXh4Dh/mBRd7GFrSl+jx0X2b94JxBuseRWTIxrSjlZNAKF0cZeLMK90INJrMP6EucSv2Mp1J2qmAeIk2tt98tKGk/sU+8pxBPF4oiD6+mtVfJMmdIsHYzDoWw0evh/2O0OAo7SmrP9ECuV4AiS+u7WhkIYEx13SYaOnB7gk5g/fk2D2k1kD1yoIOjhC490tEJrLOxLok1dcHsvqww8=; 25:7vGhCK+focNmKcq3S0K+pP3pV7IibllzdiPpOG9zLLyE/5TUu4FzBtXGjq/bqFPQPJu+64usTYpZMfH+Zzi+9iMOa/FrYEkNTG4vqyTSBuyrmAcb2QvUc+5suOqT3kYazAuumczrIvHRggpUq5CbD50JI0fE/m8Fd5dUAB1NeFHJZ9gFh0H1Dn3qiL1e1C5Z8B0sGD6tbZ3vsbxtuuJvtuKVSz+guFmysyUiBmfI+t9fsWOmZKvTz0oXW9/B/qqjRpcIOxfkE73PbXREzMV92g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB1260; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1260; 20:9aoClsxyLAtTYKeIYLKSq0yzcrw3HuhMqjdZ81X7b758M7LN7zu6/PbiuUB3Eiqbv5TMeiHnojp0105SWSVx0XO/xvAO1O4YEM/bwsJP+p6Z7jpESYB45i1uXhTSoVO70OWmRx4E/Roj9PPsN3PNIlZZPapLQCHwfjloBfOet/kfDPl+oRFwo8ielwI83uIYmqXYRrt0vgL5HsSIGBskQ7sQGZRYlaCsHgjd3kTN5UINwHLHFigNyE5LTQ/r/08tyPvb6U1nU8zXp2llrdriL/07H+1lDduBkcBgm3nw3pBffhTh9dvTZGH+BwPI4B/3izXeMkZJHS2U/MZ01oq+JK/PFlptOJhakBSgZWhdns8=; 4:0RWJ7Q0+EJ0WtoX0dbS5evjEp3JV4WJBehvmomrM/iAyXsj2727n89ZZZaG1dbd8QSwe+NH+CalYzJCsh60iFd5DvApigOfaaumq7M1WAz7rZ3B+siQxsJcA3RB04xKZBTVLX+99LLIe4YwQNUu/2p62HbPpsiwB0x/LMSFWxA4piBDa5XP7ei7c/GCaZ8tTtFkLvUOQ9szePddOdAudHOinxBA7cYm1K2LTgr/V2C59FFAcLSzd6fb9X0MrfsbZAYBrVlDC4R039dFF+/MRNLaO+lsWiSndK/qpQQs0tJAjhFDkbv3nKKIlVdGGAKrblHC96picC8+D6uIUc98PdQuH5U4rmYFYPjTx/RgV38hPx/KAEQPd/jezZ+gKvl6P/z/W2rexvDYNPP1xH7+TrNCipJ5GnoKJkU6hhchMSUEX63CVTWk6QBG88xbJFYqh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(101931422205132); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(5005006)(520078)(8121501046)(10201501046)(3002001); SRVR:CY1PR0301MB1260; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB1260; X-Forefront-PRVS: 0800C0C167 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CY1PR0301MB1260; 23:PDCtvA94rwyZ9YHmd/G5KzIiSTmENMW2wvTyQko?= =?us-ascii?Q?2NtC8/7I88s6O7LNbHCmHvFhc8wYcnz1jFGd1+p9uiptJJWwVj/b/foPxzMA?= =?us-ascii?Q?6rvtoK8PnvcoNL031IVG1WC10DMbXfxFmlWx020fpaEvci4vssnMkaSAFMJW?= =?us-ascii?Q?Kvodkv0uT5iW1ktCq3zT9qDb0HIW7hygpdiVHo3Vt6WqGYLejVWtX5yl571N?= =?us-ascii?Q?Tg/FTH0LAxjrbP2ISopj8PVIGY2tnoKpRNhf7IwIiWWap3HSFtxPirT9D6NI?= =?us-ascii?Q?QHRtuIIMbE+c08PNnsFWNsiXXzW3NOUIVyypRlXLmY974TQjjnEHP8tBwSgS?= =?us-ascii?Q?7yFDJtdJJECMTA95wiCj7i5cMW8hUOSvI0bEcH3TfsrJCbjuLINz1hDiLwIJ?= =?us-ascii?Q?DmzAKax8qJKbzUkMLQ4doqZuAMMkS444uwt2lW3pTNyQaFhEw7aCuuIly3BB?= =?us-ascii?Q?IsfycJGvOwxoAG4nrwJtvbQnhgCq+lNyVBZW9vP51q4Nu8zQv1W0+smMlCN8?= =?us-ascii?Q?bNrF3TlU6jbDp0R9MdYhmtFKwKNh/CXMtWkmbBiBKkB166TkFnPZgIdFML+t?= =?us-ascii?Q?hWPp2UiVXh36FtcRVLWPVCTuo5k3imhvYulZuh4qKAdImBxjQzR3P8u3jpD4?= =?us-ascii?Q?4kWuXz5OygdC1R9Joly9FtNvQDn9ipkMQU/vvIzAUmh26WbFlLSgayjpEPfW?= =?us-ascii?Q?7w2UaDq4N7TkdUBNq0HPpJm3ypTeRO/15EU5QY3BYpIguFkJfUzEqsxx8jGo?= =?us-ascii?Q?eelaQT5f4+WkdEHdkmvTxYa7abIL1/1lGdiLNor1+obWasaBVH8DbS/hS/A1?= =?us-ascii?Q?D5eoAkGjHDN128VA6JZAPeMZyMOWxKMbg6Z0jJuLa/nBOYPXHnpATDd2BQ2e?= =?us-ascii?Q?q7V59NetoJSIzQJUdlUjPPXXOmsi8Qx65xN+CdhmUI1kxyteC88+byTdtHNw?= =?us-ascii?Q?ockf/evkHRwcsbACHyMSfiYDrUYGobDzpufcBJ+l5O8N/YiXqKiRcZOUsxW6?= =?us-ascii?Q?zn6PeRwAziHr1pkFnbp16gRTHSIy4kl9e3d3tQj5g/5DX7SrtB4Q2od/JOPV?= =?us-ascii?Q?hfQekzUJi0AlBa0MOTndHbADvOlko?= X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB1260; 5:IXrwxWGjAsrlr8Jep9+09kHU9g/lreOEgcGGyWsFkqRiv6MoAVsAQ0UCzm8ROq99O06IobsdnTyjxtPenDijgx94G6kMNeFHW1iqT3sc1t2B38SAiNz+01pOLNx0Nah4EZNF9z62xDMs3B53geAoBw==; 24:lIdeYjZGnnxWVDF941sDGyp84ujYULgBsfz0LQJGcBLT1K9QQtCO1nZkLSGDCsdjLZOTu+FO+r00fEf8USktirba+d0Sa8xcIJGgmJI3tTo= X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Dec 2015 03:39:17.9266 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB1260 Cc: alsa-devel@alsa-project.org, Zidan Wang , Xiubo.Lee@gmail.com, tiwai@suse.com, nicoleotsuka@gmail.com Subject: [alsa-devel] [PATCH v2] ASoC: fsl_asrc: old version asrc only support even numbered channels X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP The latest asrc's channel bits is 4 bit, the old asrc's channel bits is 3. For the old version asrc, channel should be a even number. Signed-off-by: Zidan Wang --- v1->v2: 1. add an extra else if for the new condition. sound/soc/fsl/fsl_asrc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c index be78dc9..d7d81cf 100644 --- a/sound/soc/fsl/fsl_asrc.c +++ b/sound/soc/fsl/fsl_asrc.c @@ -116,6 +116,9 @@ static int fsl_asrc_request_pair(int channels, struct fsl_asrc_pair *pair) } else if (asrc_priv->channel_avail < channels) { dev_err(dev, "can't afford required channels: %d\n", channels); ret = -EINVAL; + } else if (asrc_priv->channel_bits < 4 && channels % 2 != 0) { + dev_err(dev, "old version asrc can't support an odd channel number"); + ret = -EINVAL; } else { asrc_priv->channel_avail -= channels; asrc_priv->pair[index] = pair;