Pop noise on startup when headphones are plugged in (Dell XPS13 9333)

Commit Message

Takashi Iwai April 20, 2015, 7:18 a.m. UTC

At Mon, 20 Apr 2015 07:58:15 +0200,
Takashi Iwai wrote:
> 
> At Sun, 19 Apr 2015 19:26:58 +0200,
> Gabriele Mazzotta wrote:
> > 
> > Hi,
> > 
> > I've recently found that commit a551d91473 ("ALSA: hda - Use regmap for
> > command verb caches, too") is somehow causing a pop noise on startup
> > when headphones are plugged in, but I couldn't figure out the exact
> > cause. Was this observed on other systems (mine is a Dell XPS13 9333,
> > Realtek ALC3661)? Does anyone have any idea of what the cause might be?
> 
> Are you sure that the commit is the culprit?  There are lots of other
> changes like the widget-based power saving.

FYI, the widget power-saving can be disabled by the following.  (It
can be done by hints, too.)

If this fixes the problem, we likely need more tweaks at path power
activation.  Or, as a last resort, put this to the fixup for your
model.


Takashi

---

Comments

Gabriele Mazzotta April 20, 2015, 7:51 p.m. UTC | #1

On Monday 20 April 2015 09:18:40 Takashi Iwai wrote:
> At Mon, 20 Apr 2015 07:58:15 +0200,
> Takashi Iwai wrote:
> > 
> > At Sun, 19 Apr 2015 19:26:58 +0200,
> > Gabriele Mazzotta wrote:
> > > 
> > > Hi,
> > > 
> > > I've recently found that commit a551d91473 ("ALSA: hda - Use regmap for
> > > command verb caches, too") is somehow causing a pop noise on startup
> > > when headphones are plugged in, but I couldn't figure out the exact
> > > cause. Was this observed on other systems (mine is a Dell XPS13 9333,
> > > Realtek ALC3661)? Does anyone have any idea of what the cause might be?
> > 
> > Are you sure that the commit is the culprit?  There are lots of other
> > changes like the widget-based power saving.
> 
> FYI, the widget power-saving can be disabled by the following.  (It
> can be done by hints, too.)
> 
> If this fixes the problem, we likely need more tweaks at path power
> activation.  Or, as a last resort, put this to the fixup for your
> model.

Unfortunately the change here below has no effect on my machine.
patch_alc662() is the right function.

> Takashi
> 
> ---
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 231d0e4b9a95..637ff2b70f6e 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -5584,7 +5584,7 @@ static int patch_alc269(struct hda_codec *codec)
>  
>  	spec = codec->spec;
>  	spec->gen.shared_mic_vref_pin = 0x18;
> -	codec->power_save_node = 1;
> +	/* codec->power_save_node = 1; */
>  
>  	snd_hda_pick_fixup(codec, alc269_fixup_models,
>  		       alc269_fixup_tbl, alc269_fixups);

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 231d0e4b9a95..637ff2b70f6e 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -5584,7 +5584,7 @@  static int patch_alc269(struct hda_codec *codec)
 
 	spec = codec->spec;
 	spec->gen.shared_mic_vref_pin = 0x18;
-	codec->power_save_node = 1;
+	/* codec->power_save_node = 1; */
 
 	snd_hda_pick_fixup(codec, alc269_fixup_models,
 		       alc269_fixup_tbl, alc269_fixups);