From patchwork Mon Apr 20 07:18:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 6240031 Return-Path: X-Original-To: patchwork-alsa-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CE3B79F32B for ; Mon, 20 Apr 2015 07:18:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 00A852035D for ; Mon, 20 Apr 2015 07:18:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.kernel.org (Postfix) with ESMTP id D2ADD20340 for ; Mon, 20 Apr 2015 07:18:51 +0000 (UTC) Received: by alsa0.perex.cz (Postfix, from userid 1000) id E74EB260626; Mon, 20 Apr 2015 09:18:50 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from alsa0.perex.cz (localhost [IPv6:::1]) by alsa0.perex.cz (Postfix) with ESMTP id E9CDC260575; Mon, 20 Apr 2015 09:18:48 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id B66F9260588; Mon, 20 Apr 2015 09:18:47 +0200 (CEST) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by alsa0.perex.cz (Postfix) with ESMTP id A2D0A2604FC for ; Mon, 20 Apr 2015 09:18:40 +0200 (CEST) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 6A3D0ABA2; Mon, 20 Apr 2015 07:18:40 +0000 (UTC) Date: Mon, 20 Apr 2015 09:18:40 +0200 Message-ID: From: Takashi Iwai To: Gabriele Mazzotta In-Reply-To: References: <23057263.IjMh4t6SYF@xps13> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Cc: alsa-devel@alsa-project.org Subject: Re: [alsa-devel] Pop noise on startup when headphones are plugged in (Dell XPS13 9333) X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP At Mon, 20 Apr 2015 07:58:15 +0200, Takashi Iwai wrote: > > At Sun, 19 Apr 2015 19:26:58 +0200, > Gabriele Mazzotta wrote: > > > > Hi, > > > > I've recently found that commit a551d91473 ("ALSA: hda - Use regmap for > > command verb caches, too") is somehow causing a pop noise on startup > > when headphones are plugged in, but I couldn't figure out the exact > > cause. Was this observed on other systems (mine is a Dell XPS13 9333, > > Realtek ALC3661)? Does anyone have any idea of what the cause might be? > > Are you sure that the commit is the culprit? There are lots of other > changes like the widget-based power saving. FYI, the widget power-saving can be disabled by the following. (It can be done by hints, too.) If this fixes the problem, we likely need more tweaks at path power activation. Or, as a last resort, put this to the fixup for your model. Takashi diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c index 231d0e4b9a95..637ff2b70f6e 100644 --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5584,7 +5584,7 @@ static int patch_alc269(struct hda_codec *codec) spec = codec->spec; spec->gen.shared_mic_vref_pin = 0x18; - codec->power_save_node = 1; + /* codec->power_save_node = 1; */ snd_hda_pick_fixup(codec, alc269_fixup_models, alc269_fixup_tbl, alc269_fixups);