| Message ID | 20180815092637.11455-1-govinds@codeaurora.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | *** Add support for wifi QMI client handshakes *** | expand |
+ linux-msm Hi Govind, Kalle, On Wed, Aug 15, 2018 at 02:56:31PM +0530, Govind Singh wrote: > Add QMI client handshakes for Q6 integrated WLAN connectivity subsystem. > This module is responsible for communicating WLAN control messages to FW > over QMI interface. This patch series enables the qmi handshakes required for > WCN3990 chipset. [...] What's the status of this patchset? It has seen various stages of review, and except for the fact that Govind seems to have dropped various Reviewed-by/Acked-by tags (which Rob noticed), I don't see any relevant feedback that should be blocking it. I previously had concerns about the firmware boot sequence -- that it required a Qualcomm-specific TFTP service over QRTR, which had no open source implementations. There is now a published daemon that worked for me [1], as well as firmware releases that loaded modem and Wifi firmware together, such that this TFTP service is not needed at all. So my concerns there are no longer blocking. And I think Rob already reviewed the relevant DT bindings (but again, Govind missed collecting that tag for this series). So the only outstanding request I see is to collect the appropriate tags. Should Govind resend the whole series just for that? FWIW, I've been using this series for a while now, and I reviewed earlier versions. I can provide this for the whole series: Reviewed-by: Brian Norris <briannorris@chromium.org> If nothing else, I think it's important to get someone to merge the DT bindings from this series, because Govind is now trying to extend the DT binding and to enable the WCN3990 device node in the SDM845 device tree nodes. Regards, Brian [1] https://github.com/andersson/tqftpserv [2] See this series: https://patchwork.kernel.org/cover/10621863/ Govind didn't send it to the right mailing lists yet, but we're close...
On Mon, Oct 08, 2018 at 05:36:30PM -0700, Brian Norris wrote: > + linux-msm > > Hi Govind, Kalle, > > On Wed, Aug 15, 2018 at 02:56:31PM +0530, Govind Singh wrote: > > Add QMI client handshakes for Q6 integrated WLAN connectivity subsystem. > > This module is responsible for communicating WLAN control messages to FW > > over QMI interface. This patch series enables the qmi handshakes required for > > WCN3990 chipset. > [...] > > What's the status of this patchset? It has seen various stages of > review, and except for the fact that Govind seems to have dropped > various Reviewed-by/Acked-by tags (which Rob noticed), I don't see any > relevant feedback that should be blocking it. > > I previously had concerns about the firmware boot sequence -- that it > required a Qualcomm-specific TFTP service over QRTR, which had no open > source implementations. There is now a published daemon that worked for > me [1], as well as firmware releases that loaded modem and Wifi firmware > together, such that this TFTP service is not needed at all. So my > concerns there are no longer blocking. > > And I think Rob already reviewed the relevant DT bindings (but again, > Govind missed collecting that tag for this series). > > So the only outstanding request I see is to collect the appropriate > tags. Should Govind resend the whole series just for that? > > FWIW, I've been using this series for a while now, and I reviewed > earlier versions. I can provide this for the whole series: > > Reviewed-by: Brian Norris <briannorris@chromium.org> Hello Kalle, I see that this patch series has been added to your master-pending branch. It seems to be lacking Brians Reviewed-by tags (from above). The diff between v4 and v5 is just: +++ b/drivers/net/wireless/ath/ath10k/qmi.c @@ -1010,10 +1010,10 @@ int ath10k_qmi_deinit(struct ath10k *ar) struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); struct ath10k_qmi *qmi = ar_snoc->qmi; + qmi_handle_release(&qmi->qmi_hdl); cancel_work_sync(&qmi->event_work); destroy_workqueue(qmi->event_wq); - qmi_handle_release(&qmi->qmi_hdl); - qmi = NULL; + ar_snoc->qmi = NULL; return 0; } I've given my Acked-by on v4: https://patchwork.kernel.org/cover/10540111/ The change between v4 and v5 does not warrant the removal of those tags, so please re-add them. Rob has given his Reviewed-by on the dt-binding on v4: https://patchwork.kernel.org/patch/10540115/ The dt-binding hasn't changed between v4 and v5, so please re-add it. I also noted that kbuild test robot complain about this series on x86: http://lists.infradead.org/pipermail/ath10k/2018-October/012268.html Are test errors still valid? My patch series that makes QMI_HELPERS selectable for compile test (e.g. x86), is queued up for 4.20~5.0: https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=qcom-drivers-for-4.20 Does this patch series make the errors go away, or are they unrelated? Kind regards, Niklas > > If nothing else, I think it's important to get someone to merge the DT > bindings from this series, because Govind is now trying to extend the DT > binding and to enable the WCN3990 device node in the SDM845 device tree > nodes. > > Regards, > Brian > > [1] https://github.com/andersson/tqftpserv > [2] See this series: > https://patchwork.kernel.org/cover/10621863/ > Govind didn't send it to the right mailing lists yet, but we're > close...
Niklas Cassel <niklas.cassel@linaro.org> writes: > On Mon, Oct 08, 2018 at 05:36:30PM -0700, Brian Norris wrote: >> + linux-msm >> >> Hi Govind, Kalle, >> >> On Wed, Aug 15, 2018 at 02:56:31PM +0530, Govind Singh wrote: >> > Add QMI client handshakes for Q6 integrated WLAN connectivity subsystem. >> > This module is responsible for communicating WLAN control messages to FW >> > over QMI interface. This patch series enables the qmi handshakes required for >> > WCN3990 chipset. >> [...] >> >> What's the status of this patchset? It has seen various stages of >> review, and except for the fact that Govind seems to have dropped >> various Reviewed-by/Acked-by tags (which Rob noticed), I don't see any >> relevant feedback that should be blocking it. >> >> I previously had concerns about the firmware boot sequence -- that it >> required a Qualcomm-specific TFTP service over QRTR, which had no open >> source implementations. There is now a published daemon that worked for >> me [1], as well as firmware releases that loaded modem and Wifi firmware >> together, such that this TFTP service is not needed at all. So my >> concerns there are no longer blocking. >> >> And I think Rob already reviewed the relevant DT bindings (but again, >> Govind missed collecting that tag for this series). >> >> So the only outstanding request I see is to collect the appropriate >> tags. Should Govind resend the whole series just for that? >> >> FWIW, I've been using this series for a while now, and I reviewed >> earlier versions. I can provide this for the whole series: >> >> Reviewed-by: Brian Norris <briannorris@chromium.org> > > Hello Kalle, > > I see that this patch series has been added to your master-pending branch. Yes, I'm very close to applying these patches now. > It seems to be lacking Brians Reviewed-by tags (from above). Added in the pending branch. > The diff between v4 and v5 is just: > > +++ b/drivers/net/wireless/ath/ath10k/qmi.c > @@ -1010,10 +1010,10 @@ int ath10k_qmi_deinit(struct ath10k *ar) > struct ath10k_snoc *ar_snoc = ath10k_snoc_priv(ar); > struct ath10k_qmi *qmi = ar_snoc->qmi; > > + qmi_handle_release(&qmi->qmi_hdl); > cancel_work_sync(&qmi->event_work); > destroy_workqueue(qmi->event_wq); > - qmi_handle_release(&qmi->qmi_hdl); > - qmi = NULL; > + ar_snoc->qmi = NULL; > > return 0; > } > > I've given my Acked-by on v4: > https://patchwork.kernel.org/cover/10540111/ > The change between v4 and v5 does not warrant the removal of those tags, > so please re-add them. Added these as well. > Rob has given his Reviewed-by on the dt-binding on v4: > https://patchwork.kernel.org/patch/10540115/ > The dt-binding hasn't changed between v4 and v5, so please re-add it. And this also. Please check that everything is ok in the pending branch I just pushed: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/log/?h=pending > I also noted that kbuild test robot complain about this series on x86: > http://lists.infradead.org/pipermail/ath10k/2018-October/012268.html > Are test errors still valid? These errors are because of my mistakes in the conflict resolutions I did yesterday. They should be fixed now. > My patch series that makes QMI_HELPERS selectable for compile test > (e.g. x86), is queued up for 4.20~5.0: > https://git.kernel.org/pub/scm/linux/kernel/git/agross/linux.git/log/?h=qcom-drivers-for-4.20 > > Does this patch series make the errors go away, or are they unrelated? Yeah, the errors reported by kbuild bot were unrelated. BTW, I can already use COMPILE_TEST to for compiling snoc.c on x86. I do get some warnings about QMI_HELPERS which I guess your patches fix once they land my tree. Thanks for all the help!
Add QMI client handshakes for Q6 integrated WLAN connectivity subsystem. This module is responsible for communicating WLAN control messages to FW over QMI interface. This patch series enables the qmi handshakes required for WCN3990 chipset. QUALCOMM MSM Interface(QMI) provides the control interface between components running b/w remote processors with underlying transport layer based on integrated chipset(shared memory) or discrete chipset(PCI/USB/SDIO/UART). QMI client driver implementation is based on qmi framework https://lwn.net/Articles/729924/. Below is the sequence of qmi handshake. QMI CLIENT(APPS) QMI SERVER(FW in Q6) <------wlan service discoverd---- -----connect to wlam qmi service-----> ------------wlan info request-----> <------------wlan info resp------------ ------------msa info req--------> <------------msa info resp------------ ------------msa ready req--------> <------------msa ready resp------------ <------------msa ready indication------- ------------capability req-------> <------------capability resp------------ ------------qmi bdf req---------> <------------qmi bdf resp------------ ------------qmi cal trigger-------> <------------ QMI FW ready indication------- WLAN fw is running in modem Q6 dsp as user PD(protection domain). Sequence of user PD loading is as following. 1) Remote proc PIL driver loads the modem fw/ROOT PD. 2) As part of ROOT pd boot-up it queries to a daemon(pd_mapper) running in apps processor to determine how many usre pd's to be loaded by the remote processor(Q6). 3) Once user pd info is known to remote processor it loads the user pd via tftp protocol. https://github.com/andersson/pd-mapper https://github.com/andersson/tqftpserv Changes since V4: Minor change in unload sequence, qmi handle is released prior work destroy. Changes since V3: Removed msa memory child node and used only memory-region property. Fixed sparse warning reported in v3 change. Changed qmi board id data type to u32 to align with fw defined value. Changes since V2: Addressed review comments from v2 version. Removed msa-size from dt binding and added reference to reserved-memory/reserved-memory.txt. Changes since V1: Removed qmi client driver and integrated qmi client handshakes in snoc platform driver. Addressed comments on v1 version. Switched to ath10k bdf download infra(board-2.bin) Added MSA fixed region support to support unload use-case. Unified logging. Testing: Tested all qmi handshakes, driver load/unload and STA/SAP sanity testing. Tested HW: SDM845(WCN3990) Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1 Govind Singh (5): ath10k: Add qmi service helpers for wcn3990 qmi client dt: bindings: add bindings for msa memory region firmware: qcom: scm: Add WLAN VMID for Qualcomm SCM interface ath10k: Add debug mask for QMI layer ath10k: Add QMI message handshake for wcn3990 client Rakesh Pillai (1): ath10k: Add support to create boardname for non-bmi target .../bindings/net/wireless/qcom,ath10k.txt | 6 + drivers/net/wireless/ath/ath10k/Kconfig | 1 + drivers/net/wireless/ath/ath10k/Makefile | 4 +- drivers/net/wireless/ath/ath10k/core.c | 14 +- drivers/net/wireless/ath/ath10k/core.h | 4 + drivers/net/wireless/ath/ath10k/debug.h | 1 + drivers/net/wireless/ath/ath10k/qmi.c | 1019 ++++++++ drivers/net/wireless/ath/ath10k/qmi.h | 129 + .../net/wireless/ath/ath10k/qmi_wlfw_v01.c | 2072 +++++++++++++++++ .../net/wireless/ath/ath10k/qmi_wlfw_v01.h | 677 ++++++ drivers/net/wireless/ath/ath10k/snoc.c | 262 ++- drivers/net/wireless/ath/ath10k/snoc.h | 4 + include/linux/qcom_scm.h | 4 +- 13 files changed, 4186 insertions(+), 11 deletions(-) create mode 100644 drivers/net/wireless/ath/ath10k/qmi.c create mode 100644 drivers/net/wireless/ath/ath10k/qmi.h create mode 100644 drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.c create mode 100644 drivers/net/wireless/ath/ath10k/qmi_wlfw_v01.h