From patchwork Mon Nov 24 13:15:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5366481 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 32E0FC11AC for ; Mon, 24 Nov 2014 13:28:23 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 593F8203F7 for ; Mon, 24 Nov 2014 13:28:22 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9595D203ED for ; Mon, 24 Nov 2014 13:28:21 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Xstga-0006Us-UU; Mon, 24 Nov 2014 13:28:12 +0000 Received: from mail-wg0-x231.google.com ([2a00:1450:400c:c00::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XstgV-00065a-CC for ath10k@lists.infradead.org; Mon, 24 Nov 2014 13:28:08 +0000 Received: by mail-wg0-f49.google.com with SMTP id x12so12121155wgg.22 for ; Mon, 24 Nov 2014 05:27:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=AGKeIxpj0DBCilOsN0avGnGVh6pc4/65wX1K48Jlg20=; b=eWkTIyzPx2sbkSNf2rWRyLs6HCKpDfJp6ZJy2nEJLzUAtyGD7vMhE2wybvoBK/0gqh YFpcbd1HG3DbhKrNPGJFi/Xt1srF5cjR1c6pUGkM2ffJP/RN7EOVaQ6nasyGcPW1rNjJ +cIGPUQgYuLliqtUkE6cQaiKd50DA50kD9Ews= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=AGKeIxpj0DBCilOsN0avGnGVh6pc4/65wX1K48Jlg20=; b=DMPFNWQVfBTH7Wgu8HcjJvpuVn966HsDZiaMQacpGTdhQkaS+UTGpwk0kNdKRrc0JP a7siCQGsDcb7DgrjzCW1GmyZ1aYQ1hmGCf1PqbGP1CJpPlbiebklSzeLk8JO1O0VtPkP GuAbZq/r32x6D08yGcvzV0WzChbXYuDb7pq4iyK4CKfv4ghXcL6fg9bRnMSWyIK1JL/x rh43hTAN4zRFErZBltbOWv1QhxLgyeRq4eoNZ2OMg/ZcWTMUaC8fKQT16V4puX3I4O4s Osq8L1frMREPeo8TaH0b9JhhmBdxeClWQvqzsQs10eakPO6XMW/iecdFYEnJaXnOlBN2 609w== X-Gm-Message-State: ALoCoQl1nhRvjQa3fOvkWqdkhdgLzX33E1EoyJxHBs83iQSoRK2RNEEb8B3C6ETuKBkM1qPtXsgy368E6hBoAdztn8h0X+bAvVOzvZnm67LAtW4ezepAminPIAQl2GohydBnzUXG9Hn+oaH9oFpMXeUukgidE2luPMLHBoL+KSq+em9Kojy4Z8s= X-Received: by 10.194.134.234 with SMTP id pn10mr34968200wjb.34.1416835660117; Mon, 24 Nov 2014 05:27:40 -0800 (PST) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id vy7sm21026912wjc.27.2014.11.24.05.27.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Nov 2014 05:27:39 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH 1/3] ath10k: add missing goto Date: Mon, 24 Nov 2014 14:15:07 +0100 Message-Id: <1416834909-7130-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141124_052807_630088_E0F45330 X-CRM114-Status: UNSURE ( 8.85 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This prevents warning spamming if peer creation fails during sta_state in some cases. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/mac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 1245ac8..7b5a888 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -3559,9 +3559,11 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, arvif->vdev_id, sta->addr, ar->num_peers); ret = ath10k_peer_create(ar, arvif->vdev_id, sta->addr); - if (ret) + if (ret) { ath10k_warn(ar, "failed to add peer %pM for vdev %d when adding a new sta: %i\n", sta->addr, arvif->vdev_id, ret); + goto exit; + } if (vif->type == NL80211_IFTYPE_STATION) { WARN_ON(arvif->is_started);