From patchwork Fri Jan 9 11:14:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5599041 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 86FB49FB37 for ; Fri, 9 Jan 2015 11:15:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AB6182051D for ; Fri, 9 Jan 2015 11:15:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 10FE5204FC for ; Fri, 9 Jan 2015 11:15:24 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y9XX8-0007kQ-UF; Fri, 09 Jan 2015 11:15:14 +0000 Received: from mail-we0-x229.google.com ([2a00:1450:400c:c03::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y9XX2-0006TV-Rz for ath10k@lists.infradead.org; Fri, 09 Jan 2015 11:15:10 +0000 Received: by mail-we0-f169.google.com with SMTP id m14so7356283wev.0 for ; Fri, 09 Jan 2015 03:14:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5m5y08mtVNtxD1IPqWLDYFLR2O16LMmFJi08g9wML9M=; b=cTfQgt6fnHklCx32XwJIekQVTLTkRAZD7ATB7n6XOotr0h+dG2x/j7xh3P7Nw7y+ix SecV/MHjzJclwDRg3gIhjO7UF2ETz/yeQvS7dlbBMFhIrsrSbw9V3rbjfUGATGzCqY0r vz2EHnNdWE+iBds+HKG8qza95bh0GIqVVUMtY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5m5y08mtVNtxD1IPqWLDYFLR2O16LMmFJi08g9wML9M=; b=XTA45wpvWVc3kVGCHazhL1E7e5B5vLkvooy992lKJX5gfRhg2Fy/K6A1hHZICQDPQL nDPuQojxfKREfsLCQaGAiX+J0ZW4UVCh7F1OcNvhApcfYuqghgGCl0ktZdez+/XTYFxF IVCHW6q0vRUuEb29WU8z3++WqFVr9bBZFlCT2Xx6hQTgCfOUU3l1Ivo+BHeI9MQ3jh9c Y0tCPsZ/bGwPDcrl9K1Svw7lAgi8Z94WrO2tO0RzRZUE6IXzWLVseS3SNoWcHRGYbOEa HBhyeFwzKVaN5mwDJbiUhR7Dpds5A4XBlZjQ1sUUXSuASNKqjrr7AtLqv7nYksHg7aOF doSA== X-Gm-Message-State: ALoCoQneQkiEp5AfQmHMMsUsKMrEsIjNXnzHsbvYaJsEY68o2y6+Nox5ygPQzfkJDyj5BPplqeNilry21+gBYAP5Rqxxxm/k5S/yT/I2fealtqNrONFMEonmk2Vr2EcHMrKmHIX8nIdQKBPN+AGU5G0Ifp1Nnl98smeMXF8miHwHqe2k099zwQk= X-Received: by 10.180.228.72 with SMTP id sg8mr4097203wic.48.1420802087222; Fri, 09 Jan 2015 03:14:47 -0800 (PST) Received: from localhost.localdomain ([91.198.246.8]) by mx.google.com with ESMTPSA id gb10sm9612608wjb.21.2015.01.09.03.14.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 09 Jan 2015 03:14:46 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [RFC 2/8] ath10k: allow empty ssid vdev config Date: Fri, 9 Jan 2015 12:14:03 +0100 Message-Id: <1420802049-11962-3-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1420802049-11962-1-git-send-email-michal.kazior@tieto.com> References: <1420802049-11962-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150109_031509_113106_70821789 X-CRM114-Status: UNSURE ( 8.56 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index df3ddb9..ea7fe78 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1295,8 +1295,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 1570feb..cf90f86 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4092,8 +4092,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))