From patchwork Tue Jan 20 10:26:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5667271 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1015C9F333 for ; Tue, 20 Jan 2015 10:27:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 484B920389 for ; Tue, 20 Jan 2015 10:27:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8656320254 for ; Tue, 20 Jan 2015 10:27:48 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YDW2D-00074s-3D; Tue, 20 Jan 2015 10:27:45 +0000 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YDW2A-0006vF-W2 for ath10k@lists.infradead.org; Tue, 20 Jan 2015 10:27:43 +0000 Received: by mail-wi0-f177.google.com with SMTP id r20so14303789wiv.4 for ; Tue, 20 Jan 2015 02:27:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=QBwWXhDWlNFc2F9qEkLgfW+4vDdsTEXLOBzQr2oaH3w=; b=Uj6BRymijBTtgUhybgnb60HLLXHSBJWVn2Y0mmSrvMJXHLTgNUusQkeVWYWCKAz2r6 CZV/WeagOjyocOPaKgG7A8n220bswt03TL7Wtfd5qYpQMPuZksEWrP1BN5ks4Qwo9TlZ Rb9ifOVC5PgdvFsxkQPWJHkL7TFP2ozeiuHaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QBwWXhDWlNFc2F9qEkLgfW+4vDdsTEXLOBzQr2oaH3w=; b=mWYbPnz4HoP3OsL55KVTIBTIrC2DD1mtJ2c9MvdI4A7YY+8U+B0osmM1rnZQ4vhm/8 05nldZIBsNhyONd8RQLEzGD/41Dh7sfq/I/iONpBjUWmT0PJ7RCEQ0HbjnCS3onJJXBb gGTHfkCjjukIDEQR5xog6pJir1md0CDSbQaMufwEp74CJtsKWO4E7DMZ7aJNwZGm8jQk 8T5g7egE6q+Cj2jTrj0uxPjHFUR4DgJcmc/eyeQ0rAlw5e/6505qTqj2A19TKNcCdspJ 5u/UKg/v6uT5iryyj/QekpBc73AmmrYA3usI7VEbBzKB7FRTp9JGhNNiaNU8cTtMcuSq st3g== X-Gm-Message-State: ALoCoQlYoXpm0BjFz6ui8jTTfOb4xXRxcESB0xGwFRg7PbAZYci6AeCvBO5JoBikrlyIrfyl9yNxLT03ibkHCkET+6uFn79cLuLqw2ngIGbLiPrOLmt8Dra+HnI9JuynOG25VefkKXbEwDuUZGQ+tLLFVe7ssH18SpTP/Rsa4lMpNkVZYrLpqaQ= X-Received: by 10.194.203.234 with SMTP id kt10mr14342505wjc.88.1421749639868; Tue, 20 Jan 2015 02:27:19 -0800 (PST) Received: from bob.homerouter.cpe (apn-46-76-65-212.dynamic.gprs.plus.pl. [46.76.65.212]) by mx.google.com with ESMTPSA id gu5sm2398430wib.24.2015.01.20.02.27.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2015 02:27:19 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: disable irqs after fw crash Date: Tue, 20 Jan 2015 11:26:43 +0100 Message-Id: <1421749603-11424-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150120_022743_171539_B1D3031D X-CRM114-Status: UNSURE ( 7.07 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It makes little sense to keep handling irqs if fw is dead. This prevents multiple fw register dumps upon crash on some devices (seen on QCA6174). Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 3b40a86..fba6618 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2047,6 +2047,7 @@ static void ath10k_msi_err_tasklet(unsigned long data) return; } + ath10k_pci_irq_disable(ar); ath10k_pci_fw_crashed_clear(ar); ath10k_pci_fw_crashed_dump(ar); } @@ -2116,6 +2117,7 @@ static void ath10k_pci_tasklet(unsigned long data) struct ath10k_pci *ar_pci = ath10k_pci_priv(ar); if (ath10k_pci_has_fw_crashed(ar)) { + ath10k_pci_irq_disable(ar); ath10k_pci_fw_crashed_clear(ar); ath10k_pci_fw_crashed_dump(ar); return;