From patchwork Fri Jan 30 12:31:20 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5749591 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 38C1BBF90F for ; Fri, 30 Jan 2015 12:34:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 01E4520268 for ; Fri, 30 Jan 2015 12:34:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 012CD2028D for ; Fri, 30 Jan 2015 12:34:06 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YHAlo-0000XG-6i; Fri, 30 Jan 2015 12:33:56 +0000 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YHAlm-0000Sr-Bo for ath10k@lists.infradead.org; Fri, 30 Jan 2015 12:33:54 +0000 Received: by mail-wi0-f179.google.com with SMTP id l15so2378631wiw.0 for ; Fri, 30 Jan 2015 04:33:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=w1W+CAmspXWaqppOnlZ3UYziFWc39lwGq2zSSKh8eKg=; b=WZPQLlXxDDmYV9rlzWZ/uRNVqBk6pAq8GuOTtPQimFGea5HZWhg/lIE6u192QM5b7y HBA2Z5AIVUfDpUf+F3RfzrDYE47earo6qAvsYh27XoR8rKddV00iaEG6qUZFl3bqvt/O 4z0+uAWFaFqWBOYkLNfJ5LTwgGBU/iUZ+yhws= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=w1W+CAmspXWaqppOnlZ3UYziFWc39lwGq2zSSKh8eKg=; b=MAKPsHIc49m4zP4SqLxWBfPb4Ika6XH2rn2+s5XyqzbcYZUVAXfn4BtGDmQt1fXvfC sWfXJRm9CHpcAAgeDxwWvlPOdPP+f/Qc4sJFIqH+CLYoAH93ZOwOtdaWJVdtyfmv9F8a Xsp6zkIEiYHVMmOxYsjXJMSEIIU/kpEhevQzzfLFOlkuLxaevKsapsAkdbRP7aMmyD1u fm6ghSYkcyFSinMKdA/hV7O+YdpVKFM4paSaJ+TrBzB17U9hQ+7xQlkNxrOKXTjT1pgQ yW+JuP9FmAULe5IzCVbjFTRlJ1Z4uVSMREyh+bRB25J6Gb7Ib9iwJJrUWiEfdvAnmcRE RkJA== X-Gm-Message-State: ALoCoQm0iHDR5ctFCMmABOjy7z+xT6mw7ZtxXa+8UElhgGjxEU8EiiOhHtnA7irJBNnxROSb/s4dD4URIYjOyf7nl0bQ+GlO06RfJyslBJEqYnYv24P+HlBgB0GxDS5B2f2EmmsHPJN/pTN2gQUOSG5IXLgUOGK0DsLWTw9SY3x1ONyW5TgE1ew= X-Received: by 10.180.79.106 with SMTP id i10mr4375267wix.35.1422621211705; Fri, 30 Jan 2015 04:33:31 -0800 (PST) Received: from bob.homerouter.cpe (apn-31-1-134-151.dynamic.gprs.plus.pl. [31.1.134.151]) by mx.google.com with ESMTPSA id fi10sm6730330wib.13.2015.01.30.04.33.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Jan 2015 04:33:31 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH v2 1/7] ath10k: allow empty ssid vdev config Date: Fri, 30 Jan 2015 13:31:20 +0100 Message-Id: <1422621086-28970-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 In-Reply-To: <1422621086-28970-1-git-send-email-michal.kazior@tieto.com> References: <1422607287-12289-1-git-send-email-michal.kazior@tieto.com> <1422621086-28970-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150130_043354_541371_01488FF7 X-CRM114-Status: UNSURE ( 8.44 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index be32db9..ccafb69 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1302,8 +1302,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index ce6f0c7..97ee2e9 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4264,8 +4264,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))