| Message ID | 1424437452-28161-2-git-send-email-rmanohar@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes: > Wrong symlink name is used on error path of thermal registration > and also correcting the error message. > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> Thanks, patch 2 applied. Not sure yet what to do with patch 1 and 3.
On Thu, Mar 12, 2015 at 03:00:32PM +0200, Kalle Valo wrote: > Rajkumar Manoharan <rmanohar@qti.qualcomm.com> writes: > > > Wrong symlink name is used on error path of thermal registration > > and also correcting the error message. > > > > Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> > > Thanks, patch 2 applied. Not sure yet what to do with patch 1 and 3. > Will rework on patch 1 (ath10k: add sysfs entry to configure quiet period) to use debugfs instead of sysfs. Patch 3 can be dropped. -Rajkumar
diff --git a/drivers/net/wireless/ath/ath10k/thermal.c b/drivers/net/wireless/ath/ath10k/thermal.c index 8992c17..7c54bb1 100644 --- a/drivers/net/wireless/ath/ath10k/thermal.c +++ b/drivers/net/wireless/ath/ath10k/thermal.c @@ -243,7 +243,7 @@ int ath10k_thermal_register(struct ath10k *ar) ret = sysfs_create_link(&ar->dev->kobj, &cdev->device.kobj, "cooling_device"); if (ret) { - ath10k_err(ar, "failed to create thermal symlink\n"); + ath10k_err(ar, "failed to create cooling device symlink\n"); goto err_cooling_destroy; } @@ -281,7 +281,7 @@ int ath10k_thermal_register(struct ath10k *ar) err_remove_file: sysfs_remove_file(&ar->dev->kobj, &dev_attr_quiet_period.attr); err_remove_link: - sysfs_remove_link(&ar->dev->kobj, "thermal_sensor"); + sysfs_remove_link(&ar->dev->kobj, "cooling_device"); err_cooling_destroy: thermal_cooling_device_unregister(cdev); return ret;
Wrong symlink name is used on error path of thermal registration and also correcting the error message. Signed-off-by: Rajkumar Manoharan <rmanohar@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)