From patchwork Wed Feb 25 10:39:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5879141 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 430449F536 for ; Wed, 25 Feb 2015 10:41:19 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6721A2034A for ; Wed, 25 Feb 2015 10:41:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D08A202F8 for ; Wed, 25 Feb 2015 10:41:17 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YQZOt-0004wN-Dy; Wed, 25 Feb 2015 10:41:07 +0000 Received: from mail-la0-x233.google.com ([2a00:1450:4010:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YQZOr-0004pD-M2 for ath10k@lists.infradead.org; Wed, 25 Feb 2015 10:41:06 +0000 Received: by labhv19 with SMTP id hv19so2878967lab.10 for ; Wed, 25 Feb 2015 02:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=zDpV4eFKoK5w/T2N2p6EzC3tEnDomuC5T/p84FFf1xY=; b=eUROwwRVZurYBfwX6RcsEyMmUoz0LqUFjBNwQhE62za5QiSDw0d3yY8IhFlhRR5FvC 5kEtPnzd4vuVm76Fof7AZwrIG9juv7OIiPLDkgT0U2804nu1j8+J3qXGVfInZqTbkuke BXqLclP+gOv/40EkRdYXmh1qgVkgkLacf9hGA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zDpV4eFKoK5w/T2N2p6EzC3tEnDomuC5T/p84FFf1xY=; b=Bp2ELGNBCctNJa8rDkxdEZs+7V3MVE5uwoVYFdktLuZjd6BrwCE4tB/uHWFQoUlKRB rQ4G8i435nSbAM+pW7QWYmhqLMMYY9jFURIJqSb/zYz0t6ezg/K6veoaUSZmPIovwGvo zFH9hkHeX63VdEg79pY7LvUKbFRBYEXlr9o7qie4TS5CZzUzHGl2jVkQ4RfTf5vSeXJg XuUzQLpluSBTbXdq4GwVnBedR4e9ZTfSo/Fkv/aSAkdecuFKKCQShLtFcsqfb6IfCJ64 iR7qibrn0osMP/COnfvlu4loBT6pbh1pvkmhnQc7tfympsUN8S69xyJF+U7/wS//x5Yl wqww== X-Gm-Message-State: ALoCoQlEW07sJBkGWsnIAUDuZT0tbod7+g6/UkFVgS6VoG+he0Ow2iHnSuk6PcTBukWDMinKVzOuAavx0Jo/r1LTYfALXWL+y0JsIJXA4Y1BTUPHDz1pPdFtx9rhExYndO3FyemLMJnnVcUV+LS7ELTHXFu9/ov+imQIsWjU5Dffbq1PG4iKFWA= X-Received: by 10.112.148.38 with SMTP id tp6mr2203626lbb.82.1424860843491; Wed, 25 Feb 2015 02:40:43 -0800 (PST) Received: from bob.homerouter.cpe (apn-77-113-114-198.dynamic.gprs.plus.pl. [77.113.114.198]) by mx.google.com with ESMTPSA id ms3sm7698964lbb.4.2015.02.25.02.40.42 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Feb 2015 02:40:42 -0800 (PST) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: fix ap u-apsd cmd on qca6174 w/ wmi-tlv Date: Wed, 25 Feb 2015 11:39:36 +0100 Message-Id: <1424860776-11668-1-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 1.8.5.3 X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150225_024105_911828_3CC45240 X-CRM114-Status: UNSURE ( 6.60 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The command was truncated so the parameter value was seen in fw as 0. This caused U-APSD enabled stations to be misconfigured and mistreated by AP. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index f34baa0..af5d858 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -2032,7 +2032,7 @@ ath10k_wmi_tlv_op_gen_set_ap_ps(struct ath10k *ar, u32 vdev_id, const u8 *mac, if (!mac) return ERR_PTR(-EINVAL); - skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd)); + skb = ath10k_wmi_alloc_skb(ar, sizeof(*tlv) + sizeof(*cmd)); if (!skb) return ERR_PTR(-ENOMEM);