From patchwork Tue Mar 10 13:29:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Markowski X-Patchwork-Id: 5977911 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4E60C9F399 for ; Tue, 10 Mar 2015 13:29:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5463B2020F for ; Tue, 10 Mar 2015 13:29:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 893AF201C0 for ; Tue, 10 Mar 2015 13:29:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YVKED-0006xh-Eo; Tue, 10 Mar 2015 13:29:45 +0000 Received: from mail-lb0-x22f.google.com ([2a00:1450:4010:c04::22f]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YVKEB-0006u2-6Z for ath10k@lists.infradead.org; Tue, 10 Mar 2015 13:29:44 +0000 Received: by lbiz11 with SMTP id z11so1703794lbi.3 for ; Tue, 10 Mar 2015 06:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=U5ObBrhuUynyc+tI6GEdP+06l8KlksZgkf169GrFicw=; b=s+l1+elcK8XvVycOOjXa11SJ1nIAQjNftk4wBxGy8h3A0OHv1NYMUi04ZjkSZx/Xgx ZJ0ESXgS1wc7Icsfo/Obxat1Q5/rSXO0Xy2O2AjYaThYMmk+S0r/g1UfJcpANtqH64f8 cefPgshIQ+oYZeLhASGVgVXuuebOeUeC8W8eg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=U5ObBrhuUynyc+tI6GEdP+06l8KlksZgkf169GrFicw=; b=euVNGjldtdML3E9e/8cSYJ39QRPwmtgka0zxO01KalpojwL2noWdMGcqTZ9NZxSS2/ Nq2kQskOPyLmE5MoSn7I6KgZGtxwrG0uNtXUT/qOopfjfWrsnc24H/Cex2H/rhzBdx2X 7RhHp3MrdHtHTNxPEURGPVJAVGfG2y0nUWQabIYfkmlpp6+DVGPWvFRjgRoWmnQiGyJU gATMirjauqVRF48ZeoJNEw+6UYp3dPJDsWoDFnfXDf/3fTpnUkXIVML8QghIr1OOey0v v257MjbpHAdrzjz7JYHBW2Sg5wSpsQKfQaV5CdfUgnpCL6NEHVkX8topi2mYs+Rk05Pt yn7w== X-Gm-Message-State: ALoCoQkTriU1SlIfh8X24h01D50YRlE3hQzlBlOamqlHqyTWXafSrLnknLpde2ugg3DbBNzL2S8ABv28GJmE0T40CZJ0YNmV12JmIRZs7L3FXXdhGvr0LTaN6MZklMsMGbjp6OA+AKatz23lA5lsq76VpyUKdputtwGehB55IRTVQtEyZe1JQkT80mXgNviGCH09m4oZw6nm X-Received: by 10.112.223.7 with SMTP id qq7mr30468168lbc.81.1425994154122; Tue, 10 Mar 2015 06:29:14 -0700 (PDT) Received: from uw000975.eu.tieto.com ([91.198.246.10]) by mx.google.com with ESMTPSA id w9sm121454laj.24.2015.03.10.06.29.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Mar 2015 06:29:13 -0700 (PDT) From: Bartosz Markowski To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: fix PMG by using AES-CMAC/IGTK software crypto Date: Tue, 10 Mar 2015 14:29:05 +0100 Message-Id: <1425994145-15574-1-git-send-email-bartosz.markowski@tieto.com> X-Mailer: git-send-email 2.1.2 X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150310_062943_427837_95B5A582 X-CRM114-Status: GOOD ( 10.60 ) X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Bartosz Markowski X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP While testing with older supplicant, .drv_set_key() was failing due to higher than ath10k firmware could handle key_index (WMI_MAX_KEY_INDEX == 3). --- wpa_driver_nl80211_set_key: ifindex=15 alg=4 addr=0x7f02b129fbe3 key_idx=4 set_tx=0 seq_len=6 key_len=16 broadcast key nl80211: set_key failed; err=-22 Invalid argument) wlan0: WPA: Failed to configure IGTK to the driver wlan0: RSN: Failed to configure IGTK -- In order to fix this case (PMF: AES-CMAC/IGTK) force the AES_CMAC cipher to be handled by software. Signed-off-by: Bartosz Markowski --- drivers/net/wireless/ath/ath10k/mac.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 1138f4f8923f..2264c06361b1 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -66,8 +66,8 @@ static int ath10k_send_key(struct ath10k_vif *arvif, arg.key_cipher = WMI_CIPHER_WEP; break; case WLAN_CIPHER_SUITE_AES_CMAC: - /* this one needs to be done in software */ - return 1; + WARN_ON(1) + return -EINVAL; default: ath10k_warn(ar, "cipher %d is not supported\n", key->cipher); return -EOPNOTSUPP; @@ -3995,6 +3995,10 @@ static int ath10k_set_key(struct ieee80211_hw *hw, enum set_key_cmd cmd, int ret = 0; u32 flags = 0; + /* this one needs to be done in software */ + if (key->cipher == WLAN_CIPHER_SUITE_AES_CMAC) + return 1; + if (key->keyidx > WMI_MAX_KEY_INDEX) return -ENOSPC;