From patchwork Tue Mar 24 12:43:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6078501 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 92BECBF90F for ; Tue, 24 Mar 2015 12:46:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AFB722024C for ; Tue, 24 Mar 2015 12:46:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E0BF5201D3 for ; Tue, 24 Mar 2015 12:46:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YaODo-0002eJ-OI; Tue, 24 Mar 2015 12:46:16 +0000 Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YaODm-0002ZF-AH for ath10k@lists.infradead.org; Tue, 24 Mar 2015 12:46:14 +0000 Received: by lbbug6 with SMTP id ug6so45497813lbb.3 for ; Tue, 24 Mar 2015 05:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HWWKEmvfgIR2N5GSnPq8tiO4DFcjaxKwVZuU1Tgw9lY=; b=iTyhQEdM9renYD9Ss4IVOY/q5X3ZhKRRZPoXXmuMkTS7IpNDN8LUH6gnXmTPixHcMz xC9tZHtFWpnMXSlXNR4xCDgQkmq8tbYr6zAGZkay6tnmfr3f4doL9TA9wWjScTJklZly WpRYN2lk00wPEtmuaDYiFfEAZsWjuWjLgKwac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HWWKEmvfgIR2N5GSnPq8tiO4DFcjaxKwVZuU1Tgw9lY=; b=aROkLVMlDkWx9//fUe1Ne+OD7pOIlutD2XRo3B1lPt8f2Btk59ORb/TiZoQE4tVX3E r0VJiZd6kijvGk63oqZ7fwz7/dJkFUV1H2hbIjhC1a/Mf7YA6KhToHv46is7Ru2lEO3/ YeAVaUVBXIFKSabcRB7od17awL8hZ+lAC/mPtI2s25B9ifiUY+kAppn7flmDpe5Md5Rg UX9qc1LFV1PT/peeQCnDp9JCzk9dBzgJ2xKokHxdhdpwapnd6g2RjVAHNAhZj2gSLx5S 45Gkmf1UhrenDk8yReamDS0a+xux0IsdSLFDyZ28HR1Kov1uWlhz6/n1RwO0jWpS9e+5 +CgQ== X-Gm-Message-State: ALoCoQnE9ikPONocsbxATyu2xpw4i4H6riBu06mV6bl4XU2GPqVO19jOJS2L1XElo9V8eZSS7UPKOvORuzZZ4hAclPgCOYpAUGD/He76QXB7bi5fH+JFky3mIeYPD1qber2LQXWf4B/MeqYAVe99DQgxkO8T+Wq+tA70w2wTQFfFt0r5/XwDpYQ= X-Received: by 10.152.27.202 with SMTP id v10mr3650090lag.90.1427201152068; Tue, 24 Mar 2015 05:45:52 -0700 (PDT) Received: from bob.homerouter.cpe (apn-77-113-71-242.dynamic.gprs.plus.pl. [77.113.71.242]) by mx.google.com with ESMTPSA id jp17sm901084lab.34.2015.03.24.05.45.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Mar 2015 05:45:51 -0700 (PDT) From: Michal Kazior To: ath10k@lists.infradead.org Subject: [PATCH v5 1/7] ath10k: allow empty ssid vdev config Date: Tue, 24 Mar 2015 12:43:07 +0000 Message-Id: <1427200993-7550-2-git-send-email-michal.kazior@tieto.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1427200993-7550-1-git-send-email-michal.kazior@tieto.com> References: <1427200993-7550-1-git-send-email-michal.kazior@tieto.com> X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150324_054614_545826_1B7A0871 X-CRM114-Status: UNSURE ( 8.18 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-wireless@vger.kernel.org, Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It doesn't make much sense to reject a valid firmware configuration combination. Since SSID isn't known early on it might make sense to allow driver to start vdev without SSID and restart it later. Signed-off-by: Michal Kazior --- drivers/net/wireless/ath/ath10k/wmi-tlv.c | 2 -- drivers/net/wireless/ath/ath10k/wmi.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index 467d88c780c7..d4804645f8c2 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -1518,8 +1518,6 @@ ath10k_wmi_tlv_op_gen_vdev_start(struct ath10k *ar, void *ptr; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid))) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 1f47636f204b..3ef41105b95c 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4248,8 +4248,6 @@ ath10k_wmi_op_gen_vdev_start(struct ath10k *ar, const char *cmdname; u32 flags = 0; - if (WARN_ON(arg->ssid && arg->ssid_len == 0)) - return ERR_PTR(-EINVAL); if (WARN_ON(arg->hidden_ssid && !arg->ssid)) return ERR_PTR(-EINVAL); if (WARN_ON(arg->ssid_len > sizeof(cmd->ssid.ssid)))