From patchwork Thu Jul 16 03:55:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maninder Singh X-Patchwork-Id: 6803891 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 83B189F2E8 for ; Thu, 16 Jul 2015 03:56:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B469A20763 for ; Thu, 16 Jul 2015 03:56:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD8DB20762 for ; Thu, 16 Jul 2015 03:56:49 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZFaHi-0002g5-V0; Thu, 16 Jul 2015 03:56:34 +0000 Received: from mailout4.samsung.com ([203.254.224.34]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZFaHf-0002eL-Ra for ath10k@lists.infradead.org; Thu, 16 Jul 2015 03:56:33 +0000 Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NRK00X93AXJNA30@mailout4.samsung.com> for ath10k@lists.infradead.org; Thu, 16 Jul 2015 12:56:07 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.125]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id 10.F9.17770.75B27A55; Thu, 16 Jul 2015 12:56:07 +0900 (KST) X-AuditID: cbfee691-f79ca6d00000456a-2a-55a72b575bf5 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id D1.F1.05312.75B27A55; Thu, 16 Jul 2015 12:56:07 +0900 (KST) Received: from localhost.localdomain ([107.108.92.210]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NRK002XAAX95X40@mmp1.samsung.com>; Thu, 16 Jul 2015 12:56:07 +0900 (KST) From: Maninder Singh To: kvalo@qca.qualcomm.com, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/1] ath10k: fixing wrong initialization of struct channel Date: Thu, 16 Jul 2015 09:25:33 +0530 Message-id: <1437018933-25832-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDLMWRmVeSWpSXmKPExsWyRsSkVjdce3moQcsjEYtHl44xW1z7P4fV 4vKuOWwWb1bcYbc4PL+NxeLYAjGLe2+2Mjmwe2xeUu9x6MMRVo++LasYPT5vkgtgieKySUnN ySxLLdK3S+DKePdmI1PBUvaKrqv3WBoYJ7J1MXJySAiYSDyad4cZwhaTuHBvPVCci0NIYCmj xMPp51hhij7cP8wCkVjEKDGjbQsrhPOTUeLR5PssIFVsAnoSq3btAasSEZjAKHHy0Qz2LkYO DmYBJ4npX/VAaoQFvCQe9jeArWMRUJU40bMDbAOvgLvEqsWbGUHKJQQUJOZMsgEZIyHwnU1i 9tT/LBD1AhLfJh9igaiRldh0AOpqSYmDK26wTGAUXMDIsIpRNLUguaA4Kb3IVK84Mbe4NC9d Lzk/dxMjMFBP/3s2cQfj/QPWhxgFOBiVeHg3/FgWKsSaWFZcmXuI0RRow0RmKdHkfGA85JXE GxqbGVmYmpgaG5lbmimJ8+pI/wwWEkhPLEnNTk0tSC2KLyrNSS0+xMjEwSnVwGgf73n6aZC5 xb/pgXyPFQ78s9T+Y3x03opX2sJGQdaJEX32bDaO//o2J6lG5gfe+ZTrYrZKqrP6uegkplsO TdzpLmybXeU+1+sIK3icOWX51U2jUF0+YF3991qXxs9cFvyhgU6RdzLWnb+q/k+seNcx+V7N 1cyNG5ac3MN08oiGCL/G50AhJZbijERDLeai4kQAPGvyg08CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpjkeLIzCtJLcpLzFFi42I5/e+xgG649vJQg+sXeS0eXTrGbHHt/xxW i8u75rBZvFlxh93i8Pw2FotjC8Qs7r3ZyuTA7rF5Sb3HoQ9HWD36tqxi9Pi8SS6AJaqB0SYj NTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6AAlhbLEnFKg UEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8a7NxuZCpayV3RdvcfSwDiRrYuRk0NC wETiw/3DLBC2mMSFe+uB4lwcQgKLGCVmtG1hhXB+Mko8mnwfrIpNQE9i1a49LCAJEYEJjBIn H81g72Lk4GAWcJKY/lUPpEZYwEviYX8DM4jNIqAqcaJnByuIzSvgLrFq8WZGkHIJAQWJOZNs JjByL2BkWMUomlqQXFCclJ5rpFecmFtcmpeul5yfu4kRHAfPpHcwrmqwOMQowMGoxMPL8XtZ qBBrYllxZe4hRgkOZiURXq+XQCHelMTKqtSi/Pii0pzU4kOMpkDLJzJLiSbnA2M0ryTe0NjE 3NTY1NLEwsTMUkmc92S+T6iQQHpiSWp2ampBahFMHxMHp1QDo9HR6Uu3/J1+bqpi68U/Z+XZ 9ENtGt9I1KzYxKH7d7ZgzX3hzQENfQLiT2f9PtL7R05td9sdv/V2O495c/Zy1jB7nNHxXvLP zO7/rC0qwX5xEx1cm+wSDNZuMpI+o86jahLxKCOR7yvzxV0/W55IsDj+0s6YHPgthuXkm28N F/Ury//Gs/BaKbEUZyQaajEXFScCAKaJfW2ZAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150715_205632_054561_DD64B485 X-CRM114-Status: GOOD ( 10.78 ) X-Spam-Score: -8.3 (--------) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maninder Singh , pankaj.m@samsung.com MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP chandef is initialized with NULL and on the very next line, we are using it to get channel, which is not correct. channel should be initialized after obtaining chandef. Signed-off-by: Maninder Singh --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 218b6af..3d196b5 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -836,7 +836,7 @@ static inline int ath10k_vdev_setup_sync(struct ath10k *ar) static int ath10k_monitor_vdev_start(struct ath10k *ar, int vdev_id) { struct cfg80211_chan_def *chandef = NULL; - struct ieee80211_channel *channel = chandef->chan; + struct ieee80211_channel *channel = NULL; struct wmi_vdev_start_request_arg arg = {}; int ret = 0;