| Message ID | 1440162756-4025-1-git-send-email-rmani@qti.qualcomm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
Raja Mani <rmani@qti.qualcomm.com> writes: > Below compilation warnings are observed in gcc version 4.8.2. > Even though it's not seen in bit older gcc versions (for ex, 4.7.3), > It's good to fix it by changing format specifier from %d to > %zd in wmi pull phyerr functions. > > wmi.c: In function 'ath10k_wmi_op_pull_phyerr_ev': > wmi.c:3567:8: warning: format '%d' expects argument of type 'int', > but argument 4 has type 'long unsigned int' [-Wformat=] > left_len, sizeof(*phyerr)); > ^ > wmi.c: In function 'ath10k_wmi_10_4_op_pull_phyerr_ev': > wmi.c:3612:8: warning: format '%d' expects argument of type 'int', > but argument 4 has type 'long unsigned int' [-Wformat=] > left_len, sizeof(*phyerr)); > ^ > Fixes: 991adf71a6cd ("ath10k: refactor phyerr event handlers") > Fixes: 2b0a2e0d7c2f ("ath10k: handle 10.4 firmware phyerr event") > > Signed-off-by: Raja Mani <rmani@qti.qualcomm.com> Thanks, applied.
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 42c0aba..fe150e8 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -3563,7 +3563,7 @@ int ath10k_wmi_op_pull_phyerr_ev(struct ath10k *ar, int i; if (left_len < sizeof(*phyerr)) { - ath10k_warn(ar, "wrong phyerr event head len %d (need: >=%d)\n", + ath10k_warn(ar, "wrong phyerr event head len %d (need: >=%zd)\n", left_len, sizeof(*phyerr)); return -EINVAL; } @@ -3608,7 +3608,7 @@ static int ath10k_wmi_10_4_op_pull_phyerr_ev(struct ath10k *ar, int i; if (left_len < sizeof(*phyerr)) { - ath10k_warn(ar, "wrong phyerr event head len %d (need: >=%d)\n", + ath10k_warn(ar, "wrong phyerr event head len %d (need: >=%zd)\n", left_len, sizeof(*phyerr)); return -EINVAL; }
Below compilation warnings are observed in gcc version 4.8.2. Even though it's not seen in bit older gcc versions (for ex, 4.7.3), It's good to fix it by changing format specifier from %d to %zd in wmi pull phyerr functions. wmi.c: In function 'ath10k_wmi_op_pull_phyerr_ev': wmi.c:3567:8: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=] left_len, sizeof(*phyerr)); ^ wmi.c: In function 'ath10k_wmi_10_4_op_pull_phyerr_ev': wmi.c:3612:8: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=] left_len, sizeof(*phyerr)); ^ Fixes: 991adf71a6cd ("ath10k: refactor phyerr event handlers") Fixes: 2b0a2e0d7c2f ("ath10k: handle 10.4 firmware phyerr event") Signed-off-by: Raja Mani <rmani@qti.qualcomm.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)