| Message ID | 1440679653-20289-1-git-send-email-michal.kazior@tieto.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On 27 August 2015 at 14:47, Michal Kazior <michal.kazior@tieto.com> wrote: > From: Bartosz Markowski <bartosz.markowski@tieto.com> > > All beamformee supporting chips have the ability to support > VHT NDP in up to 4 STSs. Change the published beamformee > STS cap accordingly to 3 as it should be Nsts-1. > > This makes it possible to actually make full use > of. e.g. a 4SS MU-MIMO capable AP. > > Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> > Signed-off-by: Michal Kazior <michal.kazior@tieto.com> > --- Kalle, please drop this one for now. It looks like we need to discuss about this a bit more still. > drivers/net/wireless/ath/ath10k/mac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c > index 64674c955d44..54ced30f5364 100644 > --- a/drivers/net/wireless/ath/ath10k/mac.c > +++ b/drivers/net/wireless/ath/ath10k/mac.c > @@ -4074,7 +4074,7 @@ static int ath10k_mac_set_txbf_conf(struct ath10k_vif *arvif) > > if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE | > IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) > - value |= SM((ar->num_rf_chains - 1), WMI_TXBF_STS_CAP_OFFSET); > + value |= SM(3, WMI_TXBF_STS_CAP_OFFSET); > > if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE | > IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE)) > @@ -6804,7 +6804,7 @@ static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar) > > if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE | > IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) { > - val = ar->num_rf_chains - 1; > + val = 3; > val <<= IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT; > val &= IEEE80211_VHT_CAP_BEAMFORMEE_STS_MASK; > > -- > 2.1.4 >
On 28 August 2015 at 14:56, Bartosz Markowski <bartosz.markowski@tieto.com> wrote: > On 27 August 2015 at 14:47, Michal Kazior <michal.kazior@tieto.com> wrote: >> From: Bartosz Markowski <bartosz.markowski@tieto.com> >> >> All beamformee supporting chips have the ability to support >> VHT NDP in up to 4 STSs. Change the published beamformee >> STS cap accordingly to 3 as it should be Nsts-1. >> >> This makes it possible to actually make full use >> of. e.g. a 4SS MU-MIMO capable AP. >> >> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> >> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> >> --- > > Kalle, please drop this one for now. It looks like we need to discuss > about this a bit more still. I have sent a follow up on this, splitting it into 2 patches (vht nsts and sounding dimensions), addressing the concerns raised about the lack of firmware passing the needed bits in vht_cap_info. Bartosz
Bartosz Markowski <bartosz.markowski@tieto.com> writes: > On 28 August 2015 at 14:56, Bartosz Markowski > <bartosz.markowski@tieto.com> wrote: >> On 27 August 2015 at 14:47, Michal Kazior <michal.kazior@tieto.com> wrote: >>> From: Bartosz Markowski <bartosz.markowski@tieto.com> >>> >>> All beamformee supporting chips have the ability to support >>> VHT NDP in up to 4 STSs. Change the published beamformee >>> STS cap accordingly to 3 as it should be Nsts-1. >>> >>> This makes it possible to actually make full use >>> of. e.g. a 4SS MU-MIMO capable AP. >>> >>> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> >>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> >>> --- >> >> Kalle, please drop this one for now. It looks like we need to discuss >> about this a bit more still. > > I have sent a follow up on this, splitting it into 2 patches (vht nsts > and sounding dimensions), addressing the concerns raised about the > lack of firmware passing the needed bits in vht_cap_info. Ok, patch 1 dropped. I assume patch 2 is still valid.
On 2 September 2015 at 15:55, Kalle Valo <kvalo@qca.qualcomm.com> wrote: > Bartosz Markowski <bartosz.markowski@tieto.com> writes: > >> On 28 August 2015 at 14:56, Bartosz Markowski >> <bartosz.markowski@tieto.com> wrote: >>> On 27 August 2015 at 14:47, Michal Kazior <michal.kazior@tieto.com> wrote: >>>> From: Bartosz Markowski <bartosz.markowski@tieto.com> >>>> >>>> All beamformee supporting chips have the ability to support >>>> VHT NDP in up to 4 STSs. Change the published beamformee >>>> STS cap accordingly to 3 as it should be Nsts-1. >>>> >>>> This makes it possible to actually make full use >>>> of. e.g. a 4SS MU-MIMO capable AP. >>>> >>>> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com> >>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> >>>> --- >>> >>> Kalle, please drop this one for now. It looks like we need to discuss >>> about this a bit more still. >> >> I have sent a follow up on this, splitting it into 2 patches (vht nsts >> and sounding dimensions), addressing the concerns raised about the >> lack of firmware passing the needed bits in vht_cap_info. > > Ok, patch 1 dropped. I assume patch 2 is still valid. correct.
diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 64674c955d44..54ced30f5364 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -4074,7 +4074,7 @@ static int ath10k_mac_set_txbf_conf(struct ath10k_vif *arvif) if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE | IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) - value |= SM((ar->num_rf_chains - 1), WMI_TXBF_STS_CAP_OFFSET); + value |= SM(3, WMI_TXBF_STS_CAP_OFFSET); if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE | IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE)) @@ -6804,7 +6804,7 @@ static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar) if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE | IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) { - val = ar->num_rf_chains - 1; + val = 3; val <<= IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT; val &= IEEE80211_VHT_CAP_BEAMFORMEE_STS_MASK;