From patchwork Tue Oct 27 19:02:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: punit vara X-Patchwork-Id: 7501391 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1F6519F327 for ; Tue, 27 Oct 2015 19:04:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4CF00208CE for ; Tue, 27 Oct 2015 19:04:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86AE7208CD for ; Tue, 27 Oct 2015 19:04:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zr9Xs-0001lr-3c; Tue, 27 Oct 2015 19:04:32 +0000 Received: from mail-wi0-x243.google.com ([2a00:1450:400c:c05::243]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zr9Xq-0001dU-B0 for ath10k@lists.infradead.org; Tue, 27 Oct 2015 19:04:30 +0000 Received: by wibvt6 with SMTP id vt6so29606450wib.3 for ; Tue, 27 Oct 2015 12:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l34SaQzFZtdokVOmDtp49JFufp1s0ofei+/zo8eGhzI=; b=vGtb67mKi6hm9C1+EWyBq0U9fbUs05NfEW0wQwG+fH2Fb+TAxwb6iqvzrmCZzUQ7HE r5m6tZuVJ3D19SBY0AwDNqDCGype8VZWnhB7bFGotfCzj0Ch5FZWYcDf/1bm+AFDrD0T MSANtswphjBnRtFwO/N09TvkODktq3hHCNHyZJy7jcyss/piBp06ZT7nQlYNd5ALhXX6 zM/znaV1Ztz777n0uCtd+Xck5Oww7v1kiPCg6IUA79jM4a7PcxFflesXAsh8TmDzwmY4 5TN8ZyzIdiMS//3iLpnXTcNtRkTws3ghe/bo2fjz/1PXm9QqQpbGVp67lnnatLj2MNdG fztA== X-Received: by 10.194.143.43 with SMTP id sb11mr54050141wjb.120.1445972648839; Tue, 27 Oct 2015 12:04:08 -0700 (PDT) Received: from localhost.localdomain ([163.47.15.144]) by smtp.gmail.com with ESMTPSA id hk5sm46320620wjb.6.2015.10.27.12.04.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Oct 2015 12:04:07 -0700 (PDT) From: Punit Vara To: kvalo@qca.qualcomm.com Subject: [RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Date: Wed, 28 Oct 2015 00:32:41 +0530 Message-Id: <1445972565-14963-6-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> References: <1445972565-14963-1-git-send-email-punitvara@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151027_120430_533949_5CCBF4BE X-CRM114-Status: GOOD ( 10.39 ) X-Spam-Score: 0.6 (/) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Punit Vara , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RCVD_IN_SBL_CSS, RP_MATCHES_RCVD, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170/phy.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c index dca6df1..f3b5434 100644 --- a/drivers/net/wireless/ath/carl9170/phy.c +++ b/drivers/net/wireless/ath/carl9170/phy.c @@ -966,7 +966,6 @@ static const struct carl9170_phy_freq_entry carl9170_phy_freq_params[] = { static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, u32 freq, enum carl9170_bw bw) { - int err; u32 d0, d1, td0, td1, fd0, fd1; u8 chansel; u8 refsel0 = 1, refsel1 = 0; @@ -1024,11 +1023,7 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, carl9170_regwrite(0x1c58e8, fd1); carl9170_regwrite_finish(); - err = carl9170_regwrite_result(); - if (err) - return err; - - return 0; + return carl9170_regwrite_result(); } static const struct carl9170_phy_freq_params *