From patchwork Tue Oct 27 19:02:44 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: punit vara X-Patchwork-Id: 7501441 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D4A04BEEA4 for ; Tue, 27 Oct 2015 19:04:56 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 13949208D1 for ; Tue, 27 Oct 2015 19:04:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43B26208CE for ; Tue, 27 Oct 2015 19:04:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zr9YB-0001wn-7C; Tue, 27 Oct 2015 19:04:51 +0000 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Zr9Y8-0001k3-KO for ath10k@lists.infradead.org; Tue, 27 Oct 2015 19:04:49 +0000 Received: by wijp11 with SMTP id p11so228419139wij.0 for ; Tue, 27 Oct 2015 12:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=nKfBxFG5/+tGl5RpGZCrkk00qZqA0WO2v47T2V5QAkQ=; b=eXosMhoS0pfEANxajBqAKbf6+EQ7NyKy1C3YPTMz7kCPsQr4RsDRmrsztADfCPoFDX HJshVN3npr+kRAREBICraVblZr1BP/I6tBCFw9ulxt3CsKfps4kJVScrZpAbRop2SZJh WaPrHNE/zE4oPkjFUiOOg1bVdaTEIl2OYC4i1Fq5PPoOzw5x6eTOh7qkDZm/QTYYgPcq hCIs5N4OrAnwh8EvUxyN0HPZ8VrYrLtsZ54lLvh4ZLy6cf5SM1fcekTRVGJgM2TlXLJF Sc+GEsL+82IfGavU4JigG47gKm6upzu5EIfRq4L0IkF25t2kL49URQ1MAI8mEhqE0Xju VYDQ== X-Received: by 10.194.78.35 with SMTP id y3mr29864567wjw.3.1445972667140; Tue, 27 Oct 2015 12:04:27 -0700 (PDT) Received: from localhost.localdomain ([163.47.15.144]) by smtp.gmail.com with ESMTPSA id hk5sm46320620wjb.6.2015.10.27.12.04.22 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Oct 2015 12:04:26 -0700 (PDT) From: Punit Vara To: kvalo@qca.qualcomm.com Subject: [RESEND PATCH 09/10] net: wireless: brcm80211: Remove unneeded variable ret_code returning 0 Date: Wed, 28 Oct 2015 00:32:44 +0530 Message-Id: <1445972565-14963-9-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> References: <1445972565-14963-1-git-send-email-punitvara@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151027_120448_843751_8F77909D X-CRM114-Status: GOOD ( 10.78 ) X-Spam-Score: 0.6 (/) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Punit Vara , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RCVD_IN_SBL_CSS, RP_MATCHES_RCVD, T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch is to the brcmsmac/stf.c that fixes up warning caught by coccicheck: -Unneeded variable: "ret_code". Return "0" on line 328 Remove unneccesary variable ret_code created to return zero. Signed-off-by: Punit Vara --- drivers/net/wireless/brcm80211/brcmsmac/stf.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/brcm80211/brcmsmac/stf.c b/drivers/net/wireless/brcm80211/brcmsmac/stf.c index dd91627..71ddf42 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/stf.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/stf.c @@ -306,7 +306,6 @@ int brcms_c_stf_txchain_set(struct brcms_c_info *wlc, s32 int_val, bool force) */ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) { - int ret_code = 0; u8 prev_stf_ss; u8 upd_stf_ss; @@ -325,7 +324,7 @@ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) PHY_TXC1_MODE_SISO : PHY_TXC1_MODE_CDD; } else { if (wlc->band != band) - return ret_code; + return 0; upd_stf_ss = (wlc->stf->txstreams == 1) ? PHY_TXC1_MODE_SISO : band->band_stf_ss_mode; } @@ -334,7 +333,7 @@ int brcms_c_stf_ss_update(struct brcms_c_info *wlc, struct brcms_band *band) brcms_b_band_stf_ss_set(wlc->hw, upd_stf_ss); } - return ret_code; + return 0; } int brcms_c_stf_attach(struct brcms_c_info *wlc)