From patchwork Tue Mar 29 11:02:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajkumar Manoharan X-Patchwork-Id: 8685771 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id EC717C0553 for ; Tue, 29 Mar 2016 11:03:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 25FE520253 for ; Tue, 29 Mar 2016 11:03:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07A662014A for ; Tue, 29 Mar 2016 11:03:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1akrQH-0000rE-6v; Tue, 29 Mar 2016 11:02:57 +0000 Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1akrQF-0000iU-7n for ath10k@lists.infradead.org; Tue, 29 Mar 2016 11:02:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1459249375; x=1490785375; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=wSdu2PibS69zUrv3GgsPECbK9BXTkWRvrOR0+W86gX4=; b=xXaq1dJSy4miXufOVsbpaM2xSYDtI8vVDQlpsHLcAG3N7oHiLSQ77IkM 7iU+6lXR1hlbchKsT/79JOTgoxoOrXgWI9ku3lfuOuceC14wnlh8SyQgN c1oFS/jD122P0wJjF3qTCqebttqtb6+AOsDyy6ybI6fMd5RWDkOspqY7G g=; X-IronPort-AV: E=Sophos;i="5.24,410,1455004800"; d="scan'208";a="180600911" Received: from ironmsg04-l-new.qualcomm.com (HELO Ironmsg04-L.qualcomm.com) ([10.53.140.111]) by wolverine01.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 29 Mar 2016 04:02:34 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8118"; a="1091922691" Received: from nasanexm01h.na.qualcomm.com ([10.85.0.34]) by Ironmsg04-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 29 Mar 2016 04:02:34 -0700 Received: from aphydexm01b.ap.qualcomm.com (10.252.127.11) by NASANEXM01H.na.qualcomm.com (10.85.0.34) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Tue, 29 Mar 2016 04:02:33 -0700 Received: from APHYDEXM01E.ap.qualcomm.com (10.252.127.13) by aphydexm01b.ap.qualcomm.com (10.252.127.11) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Tue, 29 Mar 2016 16:32:28 +0530 Received: from APHYDEXM01E.ap.qualcomm.com ([10.252.127.13]) by APHYDEXM01E.ap.qualcomm.com ([10.252.127.13]) with mapi id 15.00.1130.005; Tue, 29 Mar 2016 16:32:28 +0530 From: "Manoharan, Rajkumar" To: Sebastian Gottschall , "ath10k@lists.infradead.org" , Rajkumar Manoharan Subject: Re: latest ath10k pending tree bug's Thread-Topic: latest ath10k pending tree bug's Thread-Index: AQHRiZtQCoMKoMsnj02yFntWxukRt59wPhfh Date: Tue, 29 Mar 2016 11:02:27 +0000 Message-ID: <1459249346817.95969@qti.qualcomm.com> References: <1458647539-17213-1-git-send-email-rmanohar@qti.qualcomm.com> <1458647539-17213-2-git-send-email-rmanohar@qti.qualcomm.com> <8760wcdnws.fsf@kamboji.qca.qualcomm.com> <1458834773112.89396@qti.qualcomm.com> <87bn5xd96c.fsf@kamboji.qca.qualcomm.com>, <276aecc9-73a9-d71e-5aac-69c4eacf38d8@dd-wrt.com> In-Reply-To: <276aecc9-73a9-d71e-5aac-69c4eacf38d8@dd-wrt.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160329_040255_393278_DCD8EBBB X-CRM114-Status: UNSURE ( 8.27 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -8.0 (--------) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP > the new introduced code which initialized the precal data for new > chipsets will break QCA99XX support. > so ath10k fails to initialize. > i commented out > ret = ath10k_core_pre_cal_config(ar); > and > ret = ath10k_core_pre_cal_download(ar); > > to get it working again. this might not affect real pcie cards. but on > IPQ8064 based boards with on board wifi cards it shows that behaviour. > Can you please try below change? > in addition this message here floods the kernel log > [125917.204121] ath10k_pci 0001:01:00.0: failed to increase tx mgmt > pending count: -16, dropping > but it has no further visible side effects > Yeah... It is harmless but better to lower debug level. -Rajkumar diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h index ca45da3..cf90c87 100644 --- a/drivers/net/wireless/ath/ath10k/core.h +++ b/drivers/net/wireless/ath/ath10k/core.h @@ -725,10 +725,8 @@ struct ath10k { const void *firmware_data; size_t firmware_len; - union { - const struct firmware *pre_cal_file; - const struct firmware *cal_file; - }; + const struct firmware *pre_cal_file; + const struct firmware *cal_file; struct { const void *firmware_codeswap_data;