| Message ID | 1462835475-11079-16-git-send-email-greearb@candelatech.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi Ben, On Mon, May 09, 2016 at 04:11:09PM -0700, greearb@candelatech.com wrote: > From: Ben Greear <greearb@candelatech.com> > > Add placeholder so CT firmware can more easily co-exist with upstream > kernel. [shafi] nitpick: good to provide an expansion in commit log as well, so that if we can easily figure out in git log alone, rather than going through the change and suggesting that it supports more vif's etc > > Signed-off-by: Ben Greear <greearb@candelatech.com> > --- > drivers/net/wireless/ath/ath10k/core.c | 1 + > drivers/net/wireless/ath/ath10k/core.h | 3 +++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > index fa71d57..49c85c3 100644 > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -235,6 +235,7 @@ static const char *const ath10k_core_fw_feature_str[] = { > [ATH10K_FW_FEATURE_SUPPORTS_ADAPTIVE_CCA] = "adaptive-cca", > [ATH10K_FW_FEATURE_MFP_SUPPORT] = "mfp", > [ATH10K_FW_FEATURE_PEER_FLOW_CONTROL] = "peer-flow-ctrl", > + [ATH10K_FW_FEATURE_WMI_10X_CT] = "wmi-10.x-CT", > }; > > static unsigned int ath10k_core_get_fw_feature_str(char *buf, > diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h > index 1a75e2e..dd38f34 100644 > --- a/drivers/net/wireless/ath/ath10k/core.h > +++ b/drivers/net/wireless/ath/ath10k/core.h > @@ -566,6 +566,9 @@ enum ath10k_fw_features { > */ > ATH10K_FW_FEATURE_PEER_FLOW_CONTROL = 13, > > + /* Firmware from Candela Technologies, enables more VIFs, etc */ > + ATH10K_FW_FEATURE_WMI_10X_CT = 31, > + > /* keep last */ > ATH10K_FW_FEATURE_COUNT, > }; > regards, shafi > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k
On 05/10/2016 12:20 AM, Mohammed Shafi Shajakhan wrote: > Hi Ben, > > On Mon, May 09, 2016 at 04:11:09PM -0700, greearb@candelatech.com wrote: >> From: Ben Greear <greearb@candelatech.com> >> >> Add placeholder so CT firmware can more easily co-exist with upstream >> kernel. > > [shafi] nitpick: good to provide an expansion in commit log as well, so that > if we can easily figure out in git log alone, rather than going through > the change and suggesting that it supports more vif's etc CT firmware supports a great deal of things, such as IBSS, tx-rate reporting, more control over tx-buffer allocation, rate-ctrl improvements and so forth. I have another hundred or so patches that can enable and take advantage of this sort of thing, but in the past, there has been no desire to allow these patches upstream, so I am trying to feed some of the least controversial patches first in case attitudes have changed. If you would like to see my full patch tree, it is here: http://dmz2.candelatech.com/?p=linux-4.4.dev.y/.git;a=summary And, you can clone it: git clone git://dmz2.candelatech.com/linux-4.4.dev.y With regard to the patches in this series to dump the BSS regions and similar, I would be happy to share my packaging script with QCA folks so they can add that info to their own firmware. With BSS and Stack dumps, you can walk back through null-pointer exceptions in the firmware and get a full backtrace instead of just the last call location. This means you can remove a huge number of ASSERTS, which frees up IRAM and overall makes the code faster. Thanks, Ben
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index fa71d57..49c85c3 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -235,6 +235,7 @@ static const char *const ath10k_core_fw_feature_str[] = { [ATH10K_FW_FEATURE_SUPPORTS_ADAPTIVE_CCA] = "adaptive-cca", [ATH10K_FW_FEATURE_MFP_SUPPORT] = "mfp", [ATH10K_FW_FEATURE_PEER_FLOW_CONTROL] = "peer-flow-ctrl", + [ATH10K_FW_FEATURE_WMI_10X_CT] = "wmi-10.x-CT", }; static unsigned int ath10k_core_get_fw_feature_str(char *buf, diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h index 1a75e2e..dd38f34 100644 --- a/drivers/net/wireless/ath/ath10k/core.h +++ b/drivers/net/wireless/ath/ath10k/core.h @@ -566,6 +566,9 @@ enum ath10k_fw_features { */ ATH10K_FW_FEATURE_PEER_FLOW_CONTROL = 13, + /* Firmware from Candela Technologies, enables more VIFs, etc */ + ATH10K_FW_FEATURE_WMI_10X_CT = 31, + /* keep last */ ATH10K_FW_FEATURE_COUNT, };