From patchwork Fri Jul 8 10:09:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajkumar Manoharan X-Patchwork-Id: 9220379 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1AF236044F for ; Fri, 8 Jul 2016 10:10:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0AA2C28661 for ; Fri, 8 Jul 2016 10:10:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id F356728664; Fri, 8 Jul 2016 10:10:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8DC8C28661 for ; Fri, 8 Jul 2016 10:10:06 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLSjJ-0002rY-DA; Fri, 08 Jul 2016 10:09:53 +0000 Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bLSjH-0002pm-HZ for ath10k@lists.infradead.org; Fri, 08 Jul 2016 10:09:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1467972591; x=1499508591; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=WrUWvcWoHWrj5xYAv55AF3lcTU7hT5pHwcXknUerHWA=; b=lq6DfAoA0HTlwCsxzqmpkFuXgQYI3DQaUYwi9jDA1y931/rHnexrLaQh 7NAdYcZymqkWy/YhDr+AJYYngujKQvph7mCdErkvw8QV7fG7dXGz1Z0Dz 3OLFhNzu+vvutoJ2QBn47xvlDG0neRU8bKbjkwGqS764pKTRlh4U2WbqC Y=; X-IronPort-AV: E=Sophos;i="5.28,329,1464678000"; d="scan'208";a="301900683" Received: from unknown (HELO Ironmsg03-R.qualcomm.com) ([10.53.140.107]) by wolverine02.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 08 Jul 2016 03:09:29 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8219"; a="1177761678" Received: from nasanexm01e.na.qualcomm.com ([10.85.0.31]) by Ironmsg03-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 08 Jul 2016 03:09:28 -0700 Received: from APHYDEXM01E.ap.qualcomm.com (10.252.127.13) by NASANEXM01E.na.qualcomm.com (10.85.0.31) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 8 Jul 2016 03:09:28 -0700 Received: from aphydexm01b.ap.qualcomm.com (10.252.127.11) by APHYDEXM01E.ap.qualcomm.com (10.252.127.13) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Fri, 8 Jul 2016 15:39:22 +0530 Received: from aphydexm01b.ap.qualcomm.com ([10.252.127.11]) by aphydexm01b.ap.qualcomm.com ([10.252.127.11]) with mapi id 15.00.1178.000; Fri, 8 Jul 2016 15:39:22 +0530 From: "Manoharan, Rajkumar" To: Krishna Chaitanya , linux-wireless , ath10k Subject: Re: ath10k + iw set bitrates is causing FW crash Thread-Topic: ath10k + iw set bitrates is causing FW crash Thread-Index: AQHR2G+T1eIkIme5UE+r3U2t7k/kPqAM760AgAFgbAM= Date: Fri, 8 Jul 2016 10:09:21 +0000 Message-ID: <1467972560885.99812@qti.qualcomm.com> References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160708_030951_713277_2451B8CE X-CRM114-Status: UNSURE ( 5.81 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP >> I am using ath10k driver with qca988x hw2.0 and trying to limit it to use >> VHT MCS0-7 (iw set bitrates vht-mcs-5 2:0-7). >> >> But the command it causing a FW crash, if it disable HW_HAS_RATE_CONTROL >> no crash is observed but it still uses MCS9. >> >> tree: wireless-drivers-next: commit#535633a5ba4ea2504fa6c33176633becf0e59339 >> >> 1) If i disable HW_RATE_CONTROL, will ath10k honor >> the mac80211 rates? >> > Thanks for reporting the issue. Could you please try with below change? diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 5e1cc8f4c43c..cfa7e01a6103 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2812,6 +2812,9 @@ static int ath10k_station_assoc(struct ath10k *ar, return ret; } + if (vif->type != NL80211_IFTYPE_ADHOC) + peer_arg.peer_reassoc = reassoc; + ret = ath10k_wmi_peer_assoc(ar, &peer_arg); if (ret) { ath10k_warn(ar, "failed to run peer assoc for STA %pM vdev %i: %d\n",