From patchwork Wed Aug 24 15:39:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajkumar Manoharan X-Patchwork-Id: 9298023 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DC8DA60757 for ; Wed, 24 Aug 2016 15:40:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CC7B826907 for ; Wed, 24 Aug 2016 15:40:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1167290DE; Wed, 24 Aug 2016 15:40:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C021426907 for ; Wed, 24 Aug 2016 15:40:44 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bcaI0-0007uW-Ts; Wed, 24 Aug 2016 15:40:28 +0000 Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bcaHu-0006gG-7f for ath10k@lists.infradead.org; Wed, 24 Aug 2016 15:40:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1472053222; x=1503589222; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=oG2qfd/UXWuVp8mzz7SI8fe8NmTDr7kCfihitO5WxiY=; b=tE0QyLN6fI+6WDvhF0JW/dXh8Cydl686ApDfWzUKv9vP7wbz85xDMcQy /FfeRWhlsSb2q0N7U/qPc8BF0qghDdgwevePrJfN5RWE2nKNwICDISpnr s7hRBpZBRpyHnV0Mo74QwUmHpzKXZntvDck3SD4TPcv3DH+bpvMnhhJ9i s=; X-IronPort-AV: E=Sophos;i="5.28,571,1464678000"; d="scan'208";a="219187633" Received: from unknown (HELO ironmsg02-L.qualcomm.com) ([10.53.140.109]) by wolverine01.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 24 Aug 2016 08:40:00 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8267"; a="761930702" X-Amp-Result: CLEAN Received: from nasanexm01a.na.qualcomm.com ([10.85.0.81]) by ironmsg02-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 24 Aug 2016 08:40:00 -0700 Received: from eusanexr01f.eu.qualcomm.com (10.85.0.101) by nasanexm01a.na.qualcomm.com (10.85.0.81) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 24 Aug 2016 08:39:59 -0700 Received: from aphydexm01b.ap.qualcomm.com (10.252.127.11) by eusanexr01f.eu.qualcomm.com (10.85.0.101) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 24 Aug 2016 08:39:56 -0700 Received: from aphydexm01b.ap.qualcomm.com ([10.252.127.11]) by aphydexm01b.ap.qualcomm.com ([10.252.127.11]) with mapi id 15.00.1178.000; Wed, 24 Aug 2016 21:09:54 +0530 From: "Manoharan, Rajkumar" To: "Valo, Kalle" Subject: Re: master-pending: ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core] Thread-Topic: master-pending: ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core] Thread-Index: AQHR/ICqE/VRVktQHUSFnOSIejfpQaBYP3ZW Date: Wed, 24 Aug 2016 15:39:53 +0000 Message-ID: <1472053193355.82012@qti.qualcomm.com> References: <874m6i15ct.fsf@kamboji.qca.qualcomm.com> <878tvtyo1b.fsf@kamboji.qca.qualcomm.com> <1471608887214.2763@qti.qualcomm.com>, <87a8g4x4rw.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87a8g4x4rw.fsf@kamboji.qca.qualcomm.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [199.106.107.6] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160824_084022_366203_CBF595F0 X-CRM114-Status: UNSURE ( 9.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ath10k@lists.infradead.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP [...] >>>> >>>> [ 277.244673] ------------[ cut here ]------------ >>>> [ 277.244685] WARNING: CPU: 2 PID: 2162 at lib/debugobjects.c:263 debug_print_object+0x85/0xa0 >>>> [ 277.244707] ODEBUG: free active (active state 0) object type: timer_list hint: ath10k_htt_rx_ring_refill_retry+0x0/0x10 [ath10k_core] >>>> >>>> I bisected this to: >>>> >>>> [v2] ath10k: implement NAPI support >>> >>> https://patchwork.kernel.org/patch/9240975/ >>> >>> I'll reply to that patch for more info. >>> >> Oops.. my bad.. Sorry for the regression..Good that it is captured at >> earliest. Thanks Kalle for reporting the issue. >> >> It seems during deinit, driver is not waiting for NAPI completion. >> What debug options should be enabled to see this warning? > > I usually test with all sane[1] kernel debug infrastructure enabled. I have > attached a kernel config I use with my x86 32-bit laptop. > > [1] sane == not too spammy and still keeps the laptop barely usable > Yes indeed. With your kernel config, I can able to repro the issue but machine is really slow ;) Thanks a lot for sharing the config. It really helps. >> If possible, could you please try below change? >> >> diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c >> index 33380fba5948..29fc9052e51a 100644 >> --- a/drivers/net/wireless/ath/ath10k/pci.c >> +++ b/drivers/net/wireless/ath/ath10k/pci.c >> @@ -1759,6 +1759,7 @@ void ath10k_pci_ce_deinit(struct ath10k *ar) >> >> void ath10k_pci_flush(struct ath10k *ar) >> { >> + napi_synchronize(&ar->napi); >> ath10k_pci_rx_retry_sync(ar); >> ath10k_pci_buffer_cleanup(ar); >> } > > Sorry, didn't help: > It seems napi synchronization alone is not sufficient. NAPI should be disabled. Need your help again. ;) With below change WARNING & KASAN BUG is gone. Could you please help to verify below change? ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 6e21fa1478ea..04ff45deb173 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1775,6 +1775,8 @@ static void ath10k_pci_hif_stop(struct ath10k *ar) */ ath10k_pci_safe_chip_reset(ar); + napi_synchronize(&ar->napi); + napi_disable(&ar->napi); ath10k_pci_irq_disable(ar); ath10k_pci_irq_sync(ar); ath10k_pci_flush(ar); @@ -2531,6 +2533,7 @@ static int ath10k_pci_hif_power_up(struct ath10k *ar) ath10k_err(ar, "could not wake up target CPU: %d\n", ret); goto err_ce; } + napi_enable(&ar->napi); return 0; @@ -2878,7 +2881,6 @@ void ath10k_pci_init_napi(struct ath10k *ar) { netif_napi_add(&ar->napi_dev, &ar->napi, ath10k_pci_napi_poll, ATH10K_NAPI_BUDGET); - napi_enable(&ar->napi); } -Rajkumar _______________________________________________