From patchwork Tue Feb 21 09:04:33 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Rokicki X-Patchwork-Id: 9584067 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8C486600C1 for ; Tue, 21 Feb 2017 09:05:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D36F288D9 for ; Tue, 21 Feb 2017 09:05:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 622BB288E7; Tue, 21 Feb 2017 09:05:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B0FEF288D9 for ; Tue, 21 Feb 2017 09:05:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=FVO8O+TJqSnRhXLjLLAN66u9mz48ICyG3u3bLDHykcg=; b=A+F TmNGoKZPanZDEx+aO84Oa3C0xZ9N++nlssZk/4npqOs/iyc/oOExMD6fQ4rY1rnZQ182Qn6RpTnXY KyMZkr8s8lTB2edcZJKK/lRa1Tlk294k6WsxN1JciOkpnx544+eapfSGu4PfZJ2ErIQ7ipL1Am8x5 dfLvK6D9mvs6T4ymeWWmYV5D5RPPe0pXWqktCaogFtjq+YSGeVmYxYd4HCi3Ljxpc0FFF/f67NYB/ 1Qzxl3f1D+2TfNvbqBBn7xJPXO65fP90FJkpdH8FdNst+qegEDJ1UIF/7nO1P6XOe8wm3AtRWSEPi 5rLUPmdfvgcJrxj70irBVCiLIclXuUA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cg6Nb-0002gb-SI; Tue, 21 Feb 2017 09:05:03 +0000 Received: from mail-lf0-x22b.google.com ([2a00:1450:4010:c07::22b]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cg6NX-0002YT-Nz for ath10k@lists.infradead.org; Tue, 21 Feb 2017 09:05:01 +0000 Received: by mail-lf0-x22b.google.com with SMTP id l12so23537164lfe.0 for ; Tue, 21 Feb 2017 01:04:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=from:to:cc:subject:date:message-id; bh=xmQdIBY/tzAIw6bJcAusWyTt1JOm/2EA6yvX21XC/hQ=; b=1NZhuJtJ7XvHhE4UsQLxPwsH4UOluZZgjqOpGMV+GMQ7XFoBrbkFw4gpBgbiyf//15 Wp48x+xcCqlA5XPQfkqINxcwH3vlOc1UuBxhQbYO28YdAQmXJq8vCgE8IIxX7laIUIBj mNuzqE2tnp2u45loHvoSYeXOMERgXfEhMWhRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xmQdIBY/tzAIw6bJcAusWyTt1JOm/2EA6yvX21XC/hQ=; b=JSHKUv/cX96Tkqy/Q4hzx2AQJ8KFFHHq1sYK07iOgCB5kEbCl/nx4J3WHIofpTv5T9 OFM1hYWBpWaOthwGAKu8K6Z6RM0RQPX+SeLUia2+32a0LDfF1tC5VsQCb7jUsyJgI90d nUC6CjEI9VGR6f4yT5osRHrjavbHoFgzjKubmKVk2AmoJWv6cOAMXmMWYLbDRZWpO4DP G1aMJScE/NvBILdKteBnHFVF3toeJCtWgcxThY8LZ6x0QUmGS3ikyaSsbi3LbD0jLJBy 61Ixeiy7CvC9kFpn/46/M4JgZ8XDR02DF3ya0IDxO/sNW1KVPhEKobzGrHDVKHoDutyc 9pIQ== X-Gm-Message-State: AMke39mP3BdLqf0a8ZMOnYKRrZVatU3nkldVqhCjr96iELNkRbqoRGM4yYnWBbT6Ba5s5MIHX5+KAJHGTjOh1jNDLBfkJC4FvONDUdTwJx22jhgPfs+DuzkkvOJSWxYSlpavjUJCIg/N60+7cSmdd3w4FvHIngtfKSx0ghy9gPwepTIA0rOCEuIGuP/3UVp+mjo= X-Received: by 10.46.88.7 with SMTP id m7mr6889499ljb.58.1487667875673; Tue, 21 Feb 2017 01:04:35 -0800 (PST) Received: from localhost.localdomain ([91.198.246.8]) by smtp.gmail.com with ESMTPSA id u126sm5998770lja.25.2017.02.21.01.04.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 21 Feb 2017 01:04:35 -0800 (PST) From: Marcin Rokicki To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: Remove return statement from a void function Date: Tue, 21 Feb 2017 10:04:33 +0100 Message-Id: <1487667873-3493-1-git-send-email-marcin.rokicki@tieto.com> X-Mailer: git-send-email 2.7.4 X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170221_010459_969965_471933A6 X-CRM114-Status: UNSURE ( 8.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The empty 'return;' statement in a void function should be used to return from somewhere else then the end. Signed-off-by: Marcin Rokicki --- drivers/net/wireless/ath/ath10k/core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 59729aa..d65850e 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -2268,7 +2268,7 @@ static void ath10k_core_register_work(struct work_struct *work) status = ath10k_core_probe_fw(ar); if (status) { ath10k_err(ar, "could not probe fw (%d)\n", status); - goto err; + return; } status = ath10k_mac_register(ar); @@ -2307,11 +2307,10 @@ static void ath10k_core_register_work(struct work_struct *work) ath10k_mac_unregister(ar); err_release_fw: ath10k_core_free_firmware_files(ar); -err: - /* TODO: It's probably a good idea to release device from the driver - * but calling device_release_driver() here will cause a deadlock. - */ - return; + +/* TODO: It's probably a good idea to release device from the driver + * but calling device_release_driver() here will cause a deadlock. + */ } int ath10k_core_register(struct ath10k *ar, u32 chip_id)