From patchwork Sat Aug 19 14:36:22 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Stromdahl X-Patchwork-Id: 9910529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 784C360386 for ; Sat, 19 Aug 2017 14:37:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6825628D5A for ; Sat, 19 Aug 2017 14:37:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5940828D6F; Sat, 19 Aug 2017 14:37:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id CE02A28D5A for ; Sat, 19 Aug 2017 14:37:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=/5lEYn4+3Ztqg/efbYcaqd9/8KYpqYtKSUEHFWl9mus=; b=KNu D8yMV/7HRg2vWCafmVIhZBH1Av+xTEaMtf0DoTKK+gNs1fEkWdlqg4FR0sepK8ehwhrNUcFYmcPX3 1jIiclYqeEroViGyjcU2Rp1c0XguuSGp1ZxZKgklzRxmRoHosMCN8Cq/TO5Hv+qQcRVY/Jz5SkMkz +2gxeVlnt/iWzFNXDCc2JUewBRH8tmmgik1s8yveXG7LN+/tRMCPndFSLiMi0OBIS1eAknudk2Q26 gVsAeHPEzEIiyd37XGNmudHXgmIZzuvo7zHy9nxUGmtcFXcMK0zMHmgNv7oYWK7Wv+DIJYTGJ3hr5 Byis8sXxWIAsETQpQ6pStXo2bWIXNhQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dj4ry-0004WQ-EM; Sat, 19 Aug 2017 14:36:58 +0000 Received: from mail-lf0-x244.google.com ([2a00:1450:4010:c07::244]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dj4ru-0004US-SO for ath10k@lists.infradead.org; Sat, 19 Aug 2017 14:36:56 +0000 Received: by mail-lf0-x244.google.com with SMTP id f26so561571lfh.1 for ; Sat, 19 Aug 2017 07:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=D5TnYK9EiTm2qgatLeWML8biRfl+6ree1uA9gqaymDU=; b=fQ+cNP4Ntl//NrFKogJTm9lpdvZ+whcs1KFMM2hEXHTgvDU8GaPHXvqNxzTYYHbV7e 7w3D9HSPdTwzoOAWveo8pl/5dWjRREwIjvbU7j8u5iX3T6yvKqZqilFqIczKiS16W+MI Sw8A83ThyAnJVxR2CL135XYSiASHpoW/Kn51rWAQN5AohmIAhMZyYLMHw8zTN64XTtJp MLW5RdVMzfXwUMhinSU/LVT9h3MFdNN6NafOFJp2vYYNsfG2N30YR9UXirkqiPfSQOQu P1jGpIakxL/l3AceoS4as99nArvcdkTcyYR4Ez5QLSsB6dOOaMiIh6gz+5omGHqlMIhv JWvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=D5TnYK9EiTm2qgatLeWML8biRfl+6ree1uA9gqaymDU=; b=QniFJHZIvqZaBDyiZUHFnPgY5CaCHG7Yfp04hfE2ETBN/i+PTXzpfGrDt8rH6r2MWt W5lBdiITSCdtDqEbD/WmLOHxU+OI1s/flbKe2wjHNBRXJ5r+JXTUaYkVTneohLmhthTJ sciwj0tRnp61xDvjOA0XUVgwUNRngAoqlV2VW55LR2jcuCQIbz4k0Cgx8fRrfGpcwUmI aoTC809bSugP3X03xxmqirtIeaAwQliorV8wFVbl994ptCqLY9TUYrCXF4aItoapHkNQ bXKpuClY05WKddo9z1aNcJQbwCOqZ68+XIeA+CNzkH1Hl1bgog79+LIgubjtvk8A3g/O NEug== X-Gm-Message-State: AHYfb5hRhznNQVvF2jqxYiCpbwzN6+pIIWR/eEN8aO1eA3RtqqZbw/Si s2544iNDyXhw2Q== X-Received: by 10.46.83.2 with SMTP id h2mr4348588ljb.22.1503153389794; Sat, 19 Aug 2017 07:36:29 -0700 (PDT) Received: from erik-mate-1604.lan (90-227-62-61-no75.tbcn.telia.com. [90.227.62.61]) by smtp.gmail.com with ESMTPSA id f194sm1748746lfe.70.2017.08.19.07.36.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 19 Aug 2017 07:36:28 -0700 (PDT) From: Erik Stromdahl To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH] ath10k: sdio: remove unused struct member Date: Sat, 19 Aug 2017 16:36:22 +0200 Message-Id: <1503153382-11100-1-git-send-email-erik.stromdahl@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170819_073655_131042_9992992B X-CRM114-Status: UNSURE ( 8.97 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Stromdahl MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP irq_wq in struct ath10k_sdio is a remnant from an earlier version of the sdio patchset. It's use was removed as a result of Kalle's review, but somehow the struct member survived. It is not used and can therefore safely be removed. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/sdio.c | 4 ---- drivers/net/wireless/ath/ath10k/sdio.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 48268f0..03a69e5 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -1344,8 +1344,6 @@ static void ath10k_sdio_irq_handler(struct sdio_func *func) sdio_claim_host(ar_sdio->func); - wake_up(&ar_sdio->irq_wq); - if (ret && ret != -ECANCELED) ath10k_warn(ar, "failed to process pending SDIO interrupts: %d\n", ret); @@ -2000,8 +1998,6 @@ static int ath10k_sdio_probe(struct sdio_func *func, goto err_free_bmi_buf; } - init_waitqueue_head(&ar_sdio->irq_wq); - for (i = 0; i < ATH10K_SDIO_BUS_REQUEST_MAX_NUM; i++) ath10k_sdio_free_bus_req(ar, &ar_sdio->bus_req[i]); diff --git a/drivers/net/wireless/ath/ath10k/sdio.h b/drivers/net/wireless/ath/ath10k/sdio.h index 3f61c67..4ff7b54 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.h +++ b/drivers/net/wireless/ath/ath10k/sdio.h @@ -210,8 +210,6 @@ struct ath10k_sdio { /* temporary buffer for BMI requests */ u8 *bmi_buf; - wait_queue_head_t irq_wq; - bool is_disabled; struct workqueue_struct *workqueue;