From patchwork Wed Aug 23 19:32:58 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Stromdahl X-Patchwork-Id: 9918197 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id EB9FA602CB for ; Wed, 23 Aug 2017 19:34:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DCB59289F3 for ; Wed, 23 Aug 2017 19:34:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D17A428A1C; Wed, 23 Aug 2017 19:34:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6C561289F3 for ; Wed, 23 Aug 2017 19:34:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=BgWXZgjCfjDpceX7du0Oh15ulh21mNWicfGhpQKdZrI=; b=hu8 ZlwCI8VoGyuIVL+xriKYxDQJx8Q8xtwObq3VOWUowZLNLqi+slJO8WZDM/HdgLvW590veYEbrfpvx CwRCyPQB27XVvM4RZjhS0OHY0MyQOGAMzhHP8bYzlKrTj5l0/pkkmBUqSH7pnNNCgggIBTBHCRNN1 HulRavsETbN/9qqYehZNMJbKfdkd5ZuCYwbEqxznvquBUS1YsQ3e+mV5gedOjOqU5xUr4qwWC9GIp mgTF3eEbLkAGchnocwRrkhgZMzMirKlK4xFzTUex/9o3DWvOqyY0AdwCdt5Fre/ol3eu9TQFOuOgE 8E7enInCaPL/LRkMrx8SY4S/oXuxu9A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dkbPR-0004nr-Fk; Wed, 23 Aug 2017 19:33:49 +0000 Received: from mail-lf0-x243.google.com ([2a00:1450:4010:c07::243]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dkbP9-0004Wl-Ub for ath10k@lists.infradead.org; Wed, 23 Aug 2017 19:33:33 +0000 Received: by mail-lf0-x243.google.com with SMTP id v79so314223lfa.1 for ; Wed, 23 Aug 2017 12:33:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=nFDmY4sEGBoymCV9cZVz0GTSHT/NYiorN6uwOIhNGao=; b=t/Y4tFVSjn7I3+UX5HuNTn25nnvTpK2kYBL9Chgp0jcNqXbO3qtk30l5wk5DN49G4T l3IMfCZiiBr2C7wI9lwDkOKC827odt4wPRJ5KVEt/nGz1ZUL73X1NTafU7K8kwOITuNa jzVqqhB8vl+H+/5FAwXASHyXdQnT2OoVvjqRxrkiKfAGMrpSElI3dxe9LjtsWon7np7O 0HVZH3Hn9gc2OzknARgDSDMGdRK3B1ginZ1x5r/rWpNnU/vxoejsAeYJn/baxdWJ97/2 9JxzA+ml+pYe8o+E+hJKldlVktNT+sGFWvtBMSnCMilRTW6Yssg6Go5T4d/pplcvg949 HU9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=nFDmY4sEGBoymCV9cZVz0GTSHT/NYiorN6uwOIhNGao=; b=mRj1RxPIjakinAw96XWryuao5HwfUjI+CHzlz+d+GzSNa4Ns57KzSjj1QroqqHC3OP i2JwPLW1lysjqhKIr0Cgaq4jEdvA0UUq9TfpQBLqo7oB5EOMaVNKF5eJ7rV1b5xfo+/s +hwTQg7wpOA/t6TDjJ/f6zzTnVCWxLUtZ4lugw8RNG2u+Lv2FGTrkLYfdpptOiJWNZzt CebiRw/GCwznitVuC3gJWtVYNFISkhE3peQ3amIzopvn6hYJNs/36+IYQBPz/uxRZgB2 dkiRgEykV0Aaipd9RPdbMH98onuGFRqbfLliG+qlz9RNoT7acbaOXmd2jnVf/iNh1BxS QMqg== X-Gm-Message-State: AHYfb5i8G6Xk/HKFJtL8TDrm4ZOFDB34LUKNnog96n64vMvpVgtDIb2G Q6H96VL9F7jrfw== X-Received: by 10.25.81.131 with SMTP id g3mr1184452lfl.259.1503516787979; Wed, 23 Aug 2017 12:33:07 -0700 (PDT) Received: from erik-mate-1604.lan (90-227-62-61-no75.tbcn.telia.com. [90.227.62.61]) by smtp.gmail.com with ESMTPSA id r196sm368509lfe.38.2017.08.23.12.33.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 23 Aug 2017 12:33:07 -0700 (PDT) From: Erik Stromdahl To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v2] ath10k: sdio: remove unused struct member Date: Wed, 23 Aug 2017 21:32:58 +0200 Message-Id: <1503516778-5835-1-git-send-email-erik.stromdahl@gmail.com> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170823_123332_174249_C5DB29B3 X-CRM114-Status: UNSURE ( 8.76 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Stromdahl MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP irq_wq in struct ath10k_sdio is a remnant from an earlier version of the sdio patchset. Its use was removed as a result of Kalle's review, but somehow the struct member survived. It is not used and can therefore safely be removed. Signed-off-by: Erik Stromdahl --- V2: Fix typo in commit log (It's -> Its) --- drivers/net/wireless/ath/ath10k/sdio.c | 4 ---- drivers/net/wireless/ath/ath10k/sdio.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c index 48268f0..03a69e5 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -1344,8 +1344,6 @@ static void ath10k_sdio_irq_handler(struct sdio_func *func) sdio_claim_host(ar_sdio->func); - wake_up(&ar_sdio->irq_wq); - if (ret && ret != -ECANCELED) ath10k_warn(ar, "failed to process pending SDIO interrupts: %d\n", ret); @@ -2000,8 +1998,6 @@ static int ath10k_sdio_probe(struct sdio_func *func, goto err_free_bmi_buf; } - init_waitqueue_head(&ar_sdio->irq_wq); - for (i = 0; i < ATH10K_SDIO_BUS_REQUEST_MAX_NUM; i++) ath10k_sdio_free_bus_req(ar, &ar_sdio->bus_req[i]); diff --git a/drivers/net/wireless/ath/ath10k/sdio.h b/drivers/net/wireless/ath/ath10k/sdio.h index 3f61c67..4ff7b54 100644 --- a/drivers/net/wireless/ath/ath10k/sdio.h +++ b/drivers/net/wireless/ath/ath10k/sdio.h @@ -210,8 +210,6 @@ struct ath10k_sdio { /* temporary buffer for BMI requests */ u8 *bmi_buf; - wait_queue_head_t irq_wq; - bool is_disabled; struct workqueue_struct *workqueue;