From patchwork Tue Sep 19 03:15:12 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: yintang@qti.qualcomm.com X-Patchwork-Id: 9958087 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A29E26056A for ; Tue, 19 Sep 2017 03:15:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFAFF28DE2 for ; Tue, 19 Sep 2017 03:15:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B46BF28DE9; Tue, 19 Sep 2017 03:15:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D06A828DEC for ; Tue, 19 Sep 2017 03:15:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ozqTs2riBnzsq9Ox+JnsskczYXTsGB8jLr/nMo2DoKo=; b=QLaplk1shTRlys 3LK4XzsnoXGYw3cmQsKHvTJhcRKKoDXPu4UnagmA1xY3E11KdL7k3SpvhfUH7O/M6obEym6kmeDDD v7gKe6Ka+vEJgJIGRH14y8sZvTzcNSsRvy8Ww++W7bEuX6Kju1tbjRUw2hIKmpw4cf5gSjpYzqeDl 3bQWFeq8+cncxlbT+BWaf2kPcnvegTZhIk0YLI3CLYijejtUDC5X70BLE8Tt6DUNLPWyReLsQM01G TQKl2oWR+cstI0CX97tK9ERPxuhtPIRgWuam7Y5tl10Olb5EwjDzeQzLGGFmxML28lOzEcScCAfqd 4n1f9TJW7xc95MqIo6eA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1du8zv-0002Lh-7p; Tue, 19 Sep 2017 03:14:55 +0000 Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1du8zU-0001yv-VK for ath10k@lists.infradead.org; Tue, 19 Sep 2017 03:14:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qti.qualcomm.com; i=@qti.qualcomm.com; q=dns/txt; s=qcdkim; t=1505790868; x=1537326868; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=tquXOw4znmLASXVHhwribt5EaqnfmQyVKA05DiRmi74=; b=murDvNYxk64NnhZyluV+ChLc2WjIlnfcfRkq5HkGCg4Lt6yz6LH+33w9 Y8+I6qUvvmEXQR43rMlwjLB4Ykhr3fuv9L8cIc7eyZMZ+XuiirejsBYGx QXDkg9rQlyqR7Iylq6s4eeQ+tjxmuRSCjWn7381Le6/UvSfPW/Zsl3XW7 s=; X-IronPort-AV: E=Sophos;i="5.42,415,1500966000"; d="scan'208";a="115109240" Received: from unknown (HELO Ironmsg04-R.qualcomm.com) ([10.53.140.108]) by sabertooth01.qualcomm.com with ESMTP; 18 Sep 2017 20:14:10 -0700 X-IronPort-AV: E=McAfee;i="5900,7806,8658"; a="1494311375" X-MGA-submission: =?us-ascii?q?MDFw7RiqgBRXlBkAQaN6P0ESz+bkKBQSdOHZOE?= =?us-ascii?q?iwk1Kq3VozrJfg3t099FbAPelvZiH8aCXnITS12xrkqEXxRGmPgvyE8M?= =?us-ascii?q?X2njUeIQ5qmLQ35tmHqS9OMTr/Pkvb6b33Xhi5BLe9GEnmO4agtUiLhH?= =?us-ascii?q?iJ?= Received: from nasanexm02e.na.qualcomm.com ([10.85.0.86]) by Ironmsg04-R.qualcomm.com with ESMTP/TLS/AES256-SHA; 18 Sep 2017 20:14:10 -0700 Received: from aptaiexm02b.ap.qualcomm.com (10.249.150.12) by nasanexm02e.na.qualcomm.com (10.85.0.86) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Mon, 18 Sep 2017 20:14:09 -0700 Received: from yintang-HP-EliteBook-1.qca.qualcomm.com (10.80.80.8) by aptaiexm02b.ap.qualcomm.com (10.249.150.12) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Tue, 19 Sep 2017 11:14:04 +0800 From: To: Subject: [TDLS PATCH V3 4/5] ath10k: Avoid to set WEP key for TDLS peer Date: Tue, 19 Sep 2017 11:15:12 +0800 Message-ID: <1505790913-28377-5-git-send-email-yintang@qti.qualcomm.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1505790913-28377-1-git-send-email-yintang@qti.qualcomm.com> References: <1505790913-28377-1-git-send-email-yintang@qti.qualcomm.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01C.na.qualcomm.com (10.85.0.83) To aptaiexm02b.ap.qualcomm.com (10.249.150.12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170918_201429_604839_A8273B25 X-CRM114-Status: UNSURE ( 7.26 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yingying Tang TDLS peer do not need WEP key. Setting WEP key will lead to TDLS setup failure. Add fix to avoid setting WEP key for TDLS peer. Signed-off-by: Yingying Tang --- drivers/net/wireless/ath/ath10k/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 399f9ba..f6702cb 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -2966,7 +2966,7 @@ static int ath10k_station_assoc(struct ath10k *ar, } /* Plumb cached keys only for static WEP */ - if (arvif->def_wep_key_idx != -1) { + if ((arvif->def_wep_key_idx != -1) && (!sta->tdls)) { ret = ath10k_install_peer_wep_keys(arvif, sta->addr); if (ret) { ath10k_warn(ar, "failed to install peer wep keys for vdev %i: %d\n",