From patchwork Fri Dec 22 13:38:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 10130495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B0E0460318 for ; Fri, 22 Dec 2017 13:39:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A323929F9A for ; Fri, 22 Dec 2017 13:39:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 980C12A04C; Fri, 22 Dec 2017 13:39:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 85CB929F9A for ; Fri, 22 Dec 2017 13:39:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vKx6He98CPs9cH6RJE1ToGN5aqwGj2QPDp1i6YxR650=; b=iWJ0bTy+nxPx7R WzlpGb5tX1GNNrxSGiR4peZPO+lyWl56pIY7+rNLG1GEUA87tBZxN87wHSM2Nkax0BX8inkZfLneH ogG8ADMocVZN0NSUOKiCx4gAg3XBRDrJHo4DKc28aJZgBCdaiZFvAixwXBddhc6K1dXoStMuOvbqa b6fXvO4phOlQJqZ8hX4zZ25dlPKx+498QJeKACYg3wMlseN5g7nGYuvhru2/RqG1j3kS1MJVIL6/B ooTDReo7xJWZgwCR+nfV2PQpKFL5VQYad6q7cxhYrCISIjAAI7LIe1ShjdQchG1SIChx+/721wZSL 68iq8SyLM/lJ3Q4O2Usw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eSNXM-00027y-Eb; Fri, 22 Dec 2017 13:38:56 +0000 Received: from alexa-out.qualcomm.com ([129.46.98.28]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eSNXI-00023X-0W for ath10k@lists.infradead.org; Fri, 22 Dec 2017 13:38:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1513949932; x=1545485932; h=subject:from:to:cc:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=X2iaEvwYUnBN1AtlU6Be4zXw3+6LQsOSE5ggbGN5yyQ=; b=Qz4cH/BSscPXmg5Bta2KyTp8bPoN4MnLwjdU90TRPQTWwWEaNDrfyv3R JwOuRW5U6w0c4+dGNsAHzeXVJfp+zXIPz2e2DE1Vt6na2y+6l6X2ST1ao WsbQ79DWI52j0t4aQE88/87OxbTx+SmJXIWLfX1CKNAIcYbsksktiXqVY E=; Received: from ironmsg04-r-new.qualcomm.com (HELO Ironmsg04-R.qualcomm.com) ([10.53.140.108]) by alexa-out.qualcomm.com with ESMTP; 22 Dec 2017 05:38:40 -0800 X-IronPort-AV: E=McAfee;i="5900,7806,8752"; a="1553968456" X-MGA-submission: =?us-ascii?q?MDGhoUdTKSdFKiAfnTQsRzZVZpy9amIpVanN5z?= =?us-ascii?q?0T4VDEyCdHv5nzU8TeBnryn+CnbvNBaMvqwcP4Q4HwrmPYEeQrYHlUwA?= =?us-ascii?q?0cjaBgWfPQCMfxn9uLIhAUEnSxpn+DybrL+UAi0OCZhas0/drHjMjvBJ?= =?us-ascii?q?JA?= Received: from nasanexm03e.na.qualcomm.com ([10.85.0.48]) by Ironmsg04-R.qualcomm.com with ESMTP/TLS/AES256-SHA; 22 Dec 2017 05:38:39 -0800 Received: from euamsexm01a.eu.qualcomm.com (10.251.127.40) by nasanexm03e.na.qualcomm.com (10.85.0.48) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Fri, 22 Dec 2017 05:38:38 -0800 Received: from potku.adurom.net (10.80.80.8) by euamsexm01a.eu.qualcomm.com (10.251.127.40) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Fri, 22 Dec 2017 14:38:33 +0100 Subject: [PATCH v2 1/6] ath10k: remove deprecated fw_crash_dump debugfs file From: Kalle Valo To: Date: Fri, 22 Dec 2017 15:38:29 +0200 Message-ID: <151394990944.9382.5479713630153339961.stgit@potku.adurom.net> In-Reply-To: <151394982311.9382.1300230032038350642.stgit@potku.adurom.net> References: <151394982311.9382.1300230032038350642.stgit@potku.adurom.net> User-Agent: StGit/0.17.1-17-ge4e0 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01G.na.qualcomm.com (10.85.0.33) To euamsexm01a.eu.qualcomm.com (10.251.127.40) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171222_053852_137192_D387BC1F X-CRM114-Status: UNSURE ( 5.25 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The fw_crash_dump file was deprecated by commmit 727000e6af34 ("ath10k: support dev_coredump for crash dump") in v4.11 in favor of dev_coredump interface, remove it now for good. Everyone should use dev_coredump now. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/debug.c | 46 ------------------------------- 1 file changed, 46 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index 181fd8e2e615..358c34eeb2d2 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -851,49 +851,6 @@ int ath10k_debug_fw_devcoredump(struct ath10k *ar) return 0; } -static int ath10k_fw_crash_dump_open(struct inode *inode, struct file *file) -{ - struct ath10k *ar = inode->i_private; - struct ath10k_dump_file_data *dump; - - ath10k_warn(ar, "fw_crash_dump debugfs file is deprecated, please use /sys/class/devcoredump instead."); - - dump = ath10k_build_dump_file(ar, true); - if (!dump) - return -ENODATA; - - file->private_data = dump; - - return 0; -} - -static ssize_t ath10k_fw_crash_dump_read(struct file *file, - char __user *user_buf, - size_t count, loff_t *ppos) -{ - struct ath10k_dump_file_data *dump_file = file->private_data; - - return simple_read_from_buffer(user_buf, count, ppos, - dump_file, - le32_to_cpu(dump_file->len)); -} - -static int ath10k_fw_crash_dump_release(struct inode *inode, - struct file *file) -{ - vfree(file->private_data); - - return 0; -} - -static const struct file_operations fops_fw_crash_dump = { - .open = ath10k_fw_crash_dump_open, - .read = ath10k_fw_crash_dump_read, - .release = ath10k_fw_crash_dump_release, - .owner = THIS_MODULE, - .llseek = default_llseek, -}; - static ssize_t ath10k_reg_addr_read(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) @@ -2460,9 +2417,6 @@ int ath10k_debug_register(struct ath10k *ar) debugfs_create_file("simulate_fw_crash", 0600, ar->debug.debugfs_phy, ar, &fops_simulate_fw_crash); - debugfs_create_file("fw_crash_dump", 0400, ar->debug.debugfs_phy, ar, - &fops_fw_crash_dump); - debugfs_create_file("reg_addr", 0600, ar->debug.debugfs_phy, ar, &fops_reg_addr);