| Message ID | 1533292805-9709-1-git-send-email-vijay.bvb@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/1] ath10k: avoid possible memory access violation | expand |
VIJAYAKUMAAR K T <vijay.bvb@samsung.com> writes:
> It would be great, if this patch could be reviewed.
It's in the queue and you can check the state from patchwork:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
"K.T.VIJAYAKUMAAR" <vijay.bvb@samsung.com> wrote: > array "ctl_power_table" access index "pream" is initialized with -1 and > is raised as a static analysis tool issue. > [drivers\net\wireless\ath\ath10k\wmi.c:4719] -> > [drivers\net\wireless\ath\ath10k\wmi.c:4730]: (error) Array index -1 is > out of bounds. > > Since the "pream" index for accessing ctl_power_table array is initialized > with -1, there is a chance of memory access violation for the cases below. > 1) wmi_pdev_tpc_final_table_event change frequency is between 2483 and 5180 > 2) pream_idx is out of the enumeration ranges of wmi_tpc_pream_2ghz, > wmi_tpc_pream_5ghz > > Signed-off-by: K.T.VIJAYAKUMAAR <vijay.bvb@samsung.com> > [kvalo@codeaurora.org: clean up the warning message] > Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Patch applied to ath-next branch of ath.git, thanks. 97c69a70dc2c ath10k: avoid possible memory access violation
diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index 877249a..23502cd 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -4721,6 +4721,13 @@ ath10k_wmi_tpc_final_get_rate(struct ath10k *ar, } } + if (pream == -1) { + ath10k_warn(ar, "unknown wmi tpc final: pream_idx[%u], chan_freq[%u]\n", + pream_idx, __le32_to_cpu(ev->chan_freq)); + tpc = 0; + goto out; + } + if (pream == 4) tpc = min_t(u8, ev->rates_array[rate_idx], ev->max_reg_allow_pow[ch]);
array "ctl_power_table" access index "pream" is initialized with -1 and is raised as a static analysis tool issue. [drivers\net\wireless\ath\ath10k\wmi.c:4719] -> [drivers\net\wireless\ath\ath10k\wmi.c:4730]: (error) Array index -1 is out of bounds. Since the "pream" index for accessing ctl_power_table array is initialized with -1, there is a chance of memory access violation for the cases below. 1) wmi_pdev_tpc_final_table_event change frequency is between 2483 and 5180 2) pream_idx is out of the enumeration ranges of wmi_tpc_pream_2ghz, wmi_tpc_pream_5ghz Signed-off-by: K.T.VIJAYAKUMAAR <vijay.bvb@samsung.com> --- drivers/net/wireless/ath/ath10k/wmi.c | 7 +++++++ 1 file changed, 7 insertions(+)