From patchwork Fri Feb 22 07:20:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Surabhi Vishnoi X-Patchwork-Id: 10825355 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA45E139A for ; Fri, 22 Feb 2019 07:21:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AF53030F20 for ; Fri, 22 Feb 2019 07:21:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A2E9C30F64; Fri, 22 Feb 2019 07:21:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3B8EC30F20 for ; Fri, 22 Feb 2019 07:21:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=E++eNHmNSDY2jxflvnghDYV+zYtSLHRN+93vIZvRqBc=; b=inudOHviAPFAZRPEHbMN7kF355 2PtKw+SRxWR/w0Whp8Q4KpFLT9fPByzk3UZcYIz0XEwf2MXo22sjA0nQTdcklCIKeDJ/KxiaWbzdd YIeH+PEenChKsbXtagbDHlAGvvTv/B1GMJPMHgLlqoHd+3d/94hZzYn8/x3Z9lU81q4brFayTEnto npJGjpzyme9FXqD9WH3zvDLnQTqXKvFk9LlWLJaqsr/a7wr2ikOp70n9j484n1d7EeIB+UuD9RdPS JlTDa9kLEmhpGOb8OKbJVJuV9nZFCQIc1IqPUWlyUk9YMTWP5azA3kxmK81AcEnvAy0F0mE8/UkxY cunpE2vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gx58q-0008Vr-KQ; Fri, 22 Feb 2019 07:21:04 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gx58m-0008MX-MQ for ath10k@lists.infradead.org; Fri, 22 Feb 2019 07:21:02 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2C32160A44; Fri, 22 Feb 2019 07:21:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550820060; bh=ZoCengWbElX2M6EjafFC20lVt92p4OFtqidaUF/E16Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NJzGWT5pvATcRfbMK5zMXE2onMsbumE5NOT7KrJFBoTGXGyfqdO21n7shjsXoLgne yctL8fs1cnd0r3QrXPCmURWg0l2S4gTfRYtIkyBqKJF9wkiArfzqRAsCayT/Dddz0c 80Cm6CUqIvcspponAE2lp9XAhztxHwTfweJYqe5g= Received: from svishnoi-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: svishnoi@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id ECE09609BD; Fri, 22 Feb 2019 07:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550820058; bh=ZoCengWbElX2M6EjafFC20lVt92p4OFtqidaUF/E16Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ggDmQ7XudoQVmwwAfIP3x0HEWZdnwSneHIUtLeQdoIBVEBwfT6uRN+9OFlt6WAbj3 O57AGOosuAzywsNyU+8odPiEYoH/qE0mPXqWzPqJigqNyeqtfZF4sA6mvOsRc6lNny dDB6va2FylMHLqTc9cjJpc+ZGjwIYo5qZFdcy6og= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org ECE09609BD Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=svishnoi@codeaurora.org From: Surabhi Vishnoi To: ath10k@lists.infradead.org Subject: [PATCH 3/4] ath10k: Fix the wrong updation of SGI in tx_stats debugfs Date: Fri, 22 Feb 2019 12:50:33 +0530 Message-Id: <1550820034-18603-4-git-send-email-svishnoi@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1550820034-18603-1-git-send-email-svishnoi@codeaurora.org> References: <1550820034-18603-1-git-send-email-svishnoi@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190221_232100_775849_2E38BFF1 X-CRM114-Status: GOOD ( 11.50 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org, Surabhi Vishnoi MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The SGI is updated wrongly in tx stats table in debugfs per sta entry. To know whether the packets/bytes are sent with SHORT GI, test whether the SGI bit(ATH10K_RATE_INFO_FLAGS_SGI_BIT) is set or not in the txrate flags. Tested HW: WCN3990 Tested FW: WLAN.HL.3.1-00784-QCAHLSWMTPLZ-1 Fixes: a904417fc876 ("ath10k: add extended per sta tx statistics support") Signed-off-by: Surabhi Vishnoi --- drivers/net/wireless/ath/ath10k/htt_rx.c | 3 ++- drivers/net/wireless/ath/ath10k/wmi.h | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index 3a02a76..5b1dd58 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -2924,12 +2924,13 @@ static inline s8 ath10k_get_legacy_rate_idx(struct ath10k *ar, u8 rate) struct rate_info *txrate = &arsta->txrate; struct ath10k_htt_tx_stats *tx_stats; int idx, ht_idx, gi, mcs, bw, nss; + unsigned long flags; if (!arsta->tx_stats) return; tx_stats = arsta->tx_stats; - gi = (arsta->txrate.flags & RATE_INFO_FLAGS_SHORT_GI); + gi = test_bit(ATH10K_RATE_INFO_FLAGS_SGI_BIT, &flags); ht_idx = txrate->mcs + txrate->nss * 8; mcs = txrate->mcs; bw = txrate->bw; diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index 7053db4..b727232 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -5062,6 +5062,7 @@ enum wmi_rate_preamble { #define ATH10K_GI_NUM 2 #define ATH10K_HT_MCS_NUM 32 #define ATH10K_RATE_TABLE_NUM 320 +#define ATH10K_RATE_INFO_FLAGS_SGI_BIT 2 /* Value to disable fixed rate setting */ #define WMI_FIXED_RATE_NONE (0xff)