From patchwork Tue Nov 14 03:10:07 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Greear X-Patchwork-Id: 10057017 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E67FC60365 for ; Tue, 14 Nov 2017 03:10:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF3ED2906E for ; Tue, 14 Nov 2017 03:10:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C41662907A; Tue, 14 Nov 2017 03:10:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id C52A62906E for ; Tue, 14 Nov 2017 03:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MKU8/eKumO+C11EzWVI3kM3TyYOiAoqnBCIru9Wx5dA=; b=GGDFX2nHlvHePT9AgoR0PGwR4 qTw1NbDBSEvfXJG5jrq0AhxXw+O0AfMMD/eDVW6Rffbqwy9JlRoLS01CRnNGiQ+/UKr6iOi4zNdEo TfH5IV0+JNxtNDt0bJybm7IgBS46CvSufY67jZDSvCI3TKVKNFK0GyPzY0rHlbiNIJy4jnbTqq6CR lI1NgULdwjT2mygFpCgXxLw5I5F154WL+Kz6jRDMvDqu9hQstXwn3MO/QJsdl99MYbSb5FggscynH OpvJtrTcbpbmNg2su/gV3hINSLmphGbrjwxqfHOZ4sZJfyphfCA1VzqpIc5NhBIhTLpQiQJLKEqWr 0ZcnAjMGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eERcc-0003OB-9g; Tue, 14 Nov 2017 03:10:46 +0000 Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eERcZ-0003Me-IL for ath10k@lists.infradead.org; Tue, 14 Nov 2017 03:10:45 +0000 Received: from [192.168.254.4] (unknown [50.34.170.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail2.candelatech.com (Postfix) with ESMTPSA id AC8B1409E08; Mon, 13 Nov 2017 19:10:14 -0800 (PST) Subject: Re: Anyone get txbf to work on ath10k when using the linux driver? To: Sebastian Gottschall , ath10k@lists.infradead.org References: <5A0A21C7.20505@candelatech.com> From: Ben Greear Message-ID: <1d1fd019-cb3e-17e5-f7d5-dfe1debf95d5@candelatech.com> Date: Mon, 13 Nov 2017 19:10:07 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171113_191043_638506_E0DE34A7 X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 11/13/2017 06:05 PM, Sebastian Gottschall wrote: > Am 13.11.2017 um 23:50 schrieb Ben Greear: >> From what I can tell, the 10.4 firmware will not even enable txbf unless the driver >> tells it too, and I don't think the driver is doing the correct call to enable this >> (it is a testing interface hack, it appears). >> >> But, maybe I am missing something? > so the firmware does not take care about the vht flags? There is a flag to enable implicit beamforming, but it is mis-defined in the driver as far as I can tell: Possibly that bit is somehow set anyway, dunno. And the other explicit-beamforming appears to need a special hack to enable the feature in the firmware. But, someone using my firmware gets txbf to work, so I must be missing something. I will dig into it more tomorrow. Thanks, Ben diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h index ff15c37..9522f22 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.h +++ b/drivers/net/wireless/ath/ath10k/wmi.h @@ -5195,7 +5195,8 @@ enum wmi_10_4_vdev_param { #define WMI_VDEV_PARAM_TXBF_MU_TX_BFER BIT(3) #define WMI_TXBF_STS_CAP_OFFSET_LSB 4 -#define WMI_TXBF_STS_CAP_OFFSET_MASK 0xf0 +#define WMI_TXBF_STS_CAP_OFFSET_MASK 0x70 +#define WMI_TXBF_CONF_IMPLICIT_BF BIT(7) #define WMI_BF_SOUND_DIM_OFFSET_LSB 8 #define WMI_BF_SOUND_DIM_OFFSET_MASK 0xf00