| Message ID | 20151125133804.25507.64575.stgit@potku.adurom.net (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
but consider to ignore the result. this code will still fail on all IPQ SOC's with embedded QCA99XX cards. they do not contain any valid otp and this function will always fail. so the result must be ignored. this problem has been seen on Linksys EA8500, Netgear R7500 and Trendnet TEW827 so far all router based solutions using QCA99XX are affected Am 25.11.2015 um 14:38 schrieb Kalle Valo: > We check board id from all board types, not just qca99x0, so the error message > was misleading. > > Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> > --- > drivers/net/wireless/ath/ath10k/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > index f128adbae454..78fe1863ad04 100644 > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -1753,7 +1753,7 @@ static int ath10k_core_probe_fw(struct ath10k *ar) > > ret = ath10k_core_get_board_id_from_otp(ar); > if (ret && ret != -EOPNOTSUPP) { > - ath10k_err(ar, "failed to get board id from otp for qca99x0: %d\n", > + ath10k_err(ar, "failed to get board id from otp: %d\n", > ret); > return ret; > } > > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k >
diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index f128adbae454..78fe1863ad04 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -1753,7 +1753,7 @@ static int ath10k_core_probe_fw(struct ath10k *ar) ret = ath10k_core_get_board_id_from_otp(ar); if (ret && ret != -EOPNOTSUPP) { - ath10k_err(ar, "failed to get board id from otp for qca99x0: %d\n", + ath10k_err(ar, "failed to get board id from otp: %d\n", ret); return ret; }
We check board id from all board types, not just qca99x0, so the error message was misleading. Signed-off-by: Kalle Valo <kvalo@qca.qualcomm.com> --- drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)