From patchwork Fri Nov 10 00:48:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 10052199 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3AE2660631 for ; Fri, 10 Nov 2017 00:49:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BF2C2B175 for ; Fri, 10 Nov 2017 00:49:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D55E2B20C; Fri, 10 Nov 2017 00:49:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=2.0 tests=BAYES_00,DKIM_ADSP_ALL, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8D6102B175 for ; Fri, 10 Nov 2017 00:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=KL1HASsGqVUqALV2EmcSD6sBemhqPj2hDmEVDc7fEwg=; b=jH2Z6Kr8dHGYST bW+LF7AyPjGq08tBEp2wmunnRmIz1Tthk17ZzYTs+PNkQDWXLeUXe7sieTTB/Aac5JUPvsrrF/Rj4 YFq4dKcM3VTlg4w8V2C0aWgfBtKbzNRSrfK+WNQQStXFRvnwTm+TnaD91DSWAub/Zpe/7dwL9t4nt vcEzW6D/HeiGPbYpceYQ0b1QdxAC0ztNcBgJGNExmNtqbaJST0LFU4yDjg+B45ToJKqpb8GzpXHTU TCTlBCtygMeszRJ/7Sw1YlQOT8aG8nXIeIgWrf74S6xsoWgpjS1uu0G0P7CQj3VV4sdOICNeqpUZC K0nhtiY/INWYNKjuEvJA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eCxVi-0006Uj-Rg; Fri, 10 Nov 2017 00:49:30 +0000 Received: from mail.toke.dk ([52.28.52.200]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eCxVf-0006Sy-82 for ath10k@lists.infradead.org; Fri, 10 Nov 2017 00:49:29 +0000 From: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=toke.dk; s=20161023; t=1510274933; bh=S2bdUb1Vx2qPzsGmbv73aTmleXbEfvzt718+qPALGBY=; h=From:To:Cc:Subject:Date:From; b=ZCeiE899KKqAjlN+VxoE5hgTfMSHgJF8orWZaUkLA4k0ydDfvsVYh0156IiNDwHjd 8t/6Yk/LYP2RN1wW3QEt7Scup3G9sfB9mbrNbUmm4HsbBVIaNK3TiRIn8sBLikKZqA Id43dn2wWRU8vZ6McTE4SNY8YWDtNMK0KSFWDqUdrvTA5Aff4n3XZrnpA2lBjY00gY FA+BvObam7uMTp8DmqCry8+rtT0663UdUVEYsRkjsBM1s8Z6xRfbIOp1mnZw0kA+aZ LyljdFwvbxxz3OHmsrK/HDsXKIjci630l7CmGOED7U3MqY/CmHxDR4xfnryLI50i9W +Br0+AkZVbmKA== To: make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [PATCH v2] ath10k: Re-enable TXQs for all devices Date: Fri, 10 Nov 2017 09:48:39 +0900 Message-Id: <20171110004839.7478-1-toke@toke.dk> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171109_164927_605264_70981422 X-CRM114-Status: UNSURE ( 6.55 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 4ca1807815aa6801aaced7fdefa9edacc2521767 disables the use of the mac80211 TXQs for some devices because of a theoretical throughput regression. The original regression report[1] was related to fq_codel qdisc drop performance, which was fixed in 9d18562a227874289fda8ca5d117d8f503f1dcca. Since then, we have not seen the TXQ-related regression, so it should be safe to re-enable TXQs. [1] http://lists.infradead.org/pipermail/ath10k/2016-April/007266.html Signed-off-by: Toke Høiland-Jørgensen --- This has been in LEDE trunk for a couple of months now with good results. Changes since v1: - Update commit message to refer to original report and the fix for it. - Add ath10k list to cc drivers/net/wireless/ath/ath10k/mac.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 0a947eef348d..ca596ecd2d64 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -8329,15 +8329,6 @@ int ath10k_mac_register(struct ath10k *ar) ath10k_warn(ar, "failed to initialise DFS pattern detector\n"); } - /* Current wake_tx_queue implementation imposes a significant - * performance penalty in some setups. The tx scheduling code needs - * more work anyway so disable the wake_tx_queue unless firmware - * supports the pull-push mechanism. - */ - if (!test_bit(ATH10K_FW_FEATURE_PEER_FLOW_CONTROL, - ar->running_fw->fw_file.fw_features)) - ar->ops->wake_tx_queue = NULL; - ret = ath10k_mac_init_rd(ar); if (ret) { ath10k_err(ar, "failed to derive regdom: %d\n", ret);