From patchwork Sun Jun 3 18:20:29 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Erik Stromdahl X-Patchwork-Id: 10445531 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 42D9860234 for ; Sun, 3 Jun 2018 18:22:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 322C328A4D for ; Sun, 3 Jun 2018 18:22:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2555228B1C; Sun, 3 Jun 2018 18:22:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BB7AB28A4D for ; Sun, 3 Jun 2018 18:22:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=n0+DJbY1EX5HvV67dv4lhocDE2jp6spPu6B82lk/YEM=; b=ElszEhutmV/2G6HkztaT+hoOXr f29zbAvYLRARWMXJ/ZYWZ6bvIW6l/7sIRXI6+RRjCH0kKcyl1l4C6RpJnj1dNWWBxZxazyq1XCBMc 4r1K46CxJKeCQQ29Le6PYQYy1oMWWTFKgnkJfLRJpAE8ghGANdQG3LoGFmrvysmar9JNhhaGFJZ8y FpZwM5Fkl5MIe5vmDNZ5uMdEOARGonCFn/n1x4EBkeV6lJwwHVfVJKGusZbHhxGIvN162Bj1KSwjQ 4ZYE7plfdpcXBdBbmLwe3H3wjJBBlR4P88ILXsj4zloeVeeHQ2RLCjvZxOTwr7AqN+P8BxoeBh1+V pSyvQvHA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fPXeM-0006hC-JK; Sun, 03 Jun 2018 18:22:42 +0000 Received: from mail-lf0-x242.google.com ([2a00:1450:4010:c07::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fPXe1-0006WY-8j for ath10k@lists.infradead.org; Sun, 03 Jun 2018 18:22:24 +0000 Received: by mail-lf0-x242.google.com with SMTP id d24-v6so21804032lfa.8 for ; Sun, 03 Jun 2018 11:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+hNqRkdCbLifgAf6h3leWhWXt5sGFJ6IF04iRU8porg=; b=dsoqYyT8AddsOXCS9O9DipgWaNUJJ//cL+4gYzBeLCZS4wziTkKVQ7mRrT9a+1v+85 BW3JXMaG1ZCuuAmNa49wJfHsl+tIMsYkgq71Is3PAvvVXPXeb6qfnl8zlVjcqmlD6fZA Jsf1XENshUQWydO18riLmI+OEdDgV0UOsAqzGpZ3HGk0lEKB/jUNGidwmsBRn4xgiq4g Bx44XLUaBwLpLHeFM1yYKrFQhZZkrk4PuSG9xzTk1YJCwzwiWK0RDWxvN9yRTVn1oEA0 Wv11AgkHBgYOzF8z03ncT1pDj/2ixdYrHa0AG0q4jhqT+FP4OGAB5lhjlmo4Y6UoNt+e T5yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+hNqRkdCbLifgAf6h3leWhWXt5sGFJ6IF04iRU8porg=; b=R2MNWcbybF1YPVuFVVyj/XPmdN0XzgrJXEozh/A4fhJhqXwD38JhiPUJcLgmnsBH1C /NlYnkrIqd/BLQx/A0R4/hKV7jDs+K4nR/wpZjCz50OlASyizV7mq/ffgCJFqbIg8wx3 93YMAGNganbOaQEIWItB2MP7YC8xR3i4uBtI4ggOw8LiuX6jBAuQl/V2MA0C7zqHHgEq 5w3XAn27/K0tPrdXLmTHI0I7FdvVUvk0xBzklt72wAMHxyldkWxCov00PpeQXuwX7h0p sYSQrkSGM8iMDvRAkGRzeC+rCtCM3jBSkF3FfzEkjzvwPP/MCB+4V9LSfiE6En0KGIgE N8Ig== X-Gm-Message-State: ALKqPweBuDoQIx869vPMKuF++u7ZiM1W+CTo0uJ1GoqESVCaMTCGX8Ay CTfwFVdQF1UepZeYaJmBpdo= X-Google-Smtp-Source: ADUXVKINQqjUMkD1mLpFzDUHZEVmZGbKkVesz5mAe3knhPKQNWHwNfb/OdDWcPgvnAWHnJ4b28V+Nw== X-Received: by 2002:a19:290b:: with SMTP id p11-v6mr10590236lfp.108.1528050139721; Sun, 03 Jun 2018 11:22:19 -0700 (PDT) Received: from localhost.localdomain (90-227-62-61-no75.tbcn.telia.com. [90.227.62.61]) by smtp.gmail.com with ESMTPSA id l200-v6sm4980562lfe.77.2018.06.03.11.22.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Jun 2018 11:22:19 -0700 (PDT) From: Erik Stromdahl To: kvalo@qca.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: [RFC v5 12/12] ath10k: wmi: disable softirq's while calling ieee80211_rx Date: Sun, 3 Jun 2018 20:20:29 +0200 Message-Id: <20180603182029.8914-13-erik.stromdahl@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180603182029.8914-1-erik.stromdahl@gmail.com> References: <20180603182029.8914-1-erik.stromdahl@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180603_112221_301918_6C81664D X-CRM114-Status: GOOD ( 10.47 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Erik Stromdahl MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This is done in order not to trig the below warning in ieee80211_rx_napi: WARN_ON_ONCE(softirq_count() == 0); ieee80211_rx_napi requires that softirq's are disabled during execution. The High latency bus drivers (SDIO and USB) sometimes call the wmi ep_rx_complete callback from non softirq context, resulting in a trigger of the above warning. Calling ieee80211_rx_ni with softirq's already disabled (e.g., from softirq context) should be safe as the local_bh_disable and local_bh_enable functions (called from ieee80211_rx_ni) are fully reentrant. Signed-off-by: Erik Stromdahl --- drivers/net/wireless/ath/ath10k/wmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index f97ab795cf2e..c3237a6d77a2 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2423,7 +2423,8 @@ int ath10k_wmi_event_mgmt_rx(struct ath10k *ar, struct sk_buff *skb) status->freq, status->band, status->signal, status->rate_idx); - ieee80211_rx(ar->hw, skb); + ieee80211_rx_ni(ar->hw, skb); + return 0; }