From patchwork Mon Jun 11 18:19:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10458639 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6B0FE6020F for ; Mon, 11 Jun 2018 18:20:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5CA302859F for ; Mon, 11 Jun 2018 18:20:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4B3BD285A2; Mon, 11 Jun 2018 18:20:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0497F285A5 for ; Mon, 11 Jun 2018 18:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=TavBpuIhFCjxm/Pa3+sW3q5DSaDIhG8kIe/byiY3oOw=; b=NXp AemgbdGONT2Rt44FljdRQEz9EDx/I61QdFBehG2RFqWNwmNEly/jP1qCZbN7Pk51uyj2W4PezgswQ P/xLSuNid+HEKtiDlNOR9vVPgZv7skbqHhYiU/yWJSUAydEt7JE+1jemgz+QyUFmNvPHGQlGOn79/ OLunBtI262fZthbFooIu5/pZS8TPCxmmfzvPIfj01R2tT030TkiqsIqc6fXnGeeYhoW0xgnBnSjwJ YGEWUr7sejevNLbeiAASsK9cc7cqAXUPkT7G8shCXmO78Txo3zKTpq2o5h8yvTpgxxeFeIzyKaVb8 HNZrHzswtO3kk8ejEzQ4YoVsWC+2HuQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSRQO-0002Ll-5N; Mon, 11 Jun 2018 18:20:16 +0000 Received: from mail-pf0-x241.google.com ([2607:f8b0:400e:c00::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSRQ5-0001YA-23 for ath10k@lists.infradead.org; Mon, 11 Jun 2018 18:20:13 +0000 Received: by mail-pf0-x241.google.com with SMTP id y8-v6so1598994pfm.10 for ; Mon, 11 Jun 2018 11:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=FoqW5kbSQry1ZnHepDpW0njGWC1OzjUWOfc/81TfeoQ=; b=WK/UUfe5baloKX9dn+zKH4Tabs3ICKmaVja5SB1EiXqL+LPnU9XOKGPB/Ht1kXz+/Y APpSPah+IKlzSxOMTlvirD+/GbQKbq/7tUewxD+4w41/y+B+BUBfL45706KMutV+lekJ 5FgZj+lV648SGWg7XJpn7uYgMoDs8fMVpZqQg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FoqW5kbSQry1ZnHepDpW0njGWC1OzjUWOfc/81TfeoQ=; b=LDDh6I2Veimif6RpJiJvgdb5Gol9dQNlzWnHNP70qEV8K4AK1ygt7keMA2tjfhbz6j Q5ZT9RqWRkjaJT45/Mx+G9SaJVFHa/HnHxuXwH3PYMVgU1W04m+wojr5zIjar6lYYAot zD3d5TeaTNEgz2NFvepu1Qtw+Pm+AGVMcQV/eVIi1/jqM0wUANlZjbDna02k8ABFgTOH uIHOFnahUW9qa0q8wpJxO5mSKk/+WRZNBwHrsaqdH/VL5943gb+PXpal2slWazqmWMwy HeLX0D2yZ4+Tyk/hd/ZVgn+KbepMj6ETrUITQYVKRk2K9L8WFiuvPraqf7W9oSD6ZyYr Xc1g== X-Gm-Message-State: APt69E2k1HB8qdVZ0O8bpNo/6x1NxL6PpYr07K9y/QSJwbIw3X9DcgPc 18E68GagyyeMASNWLK1lq4rLkRxKZP4= X-Google-Smtp-Source: ADUXVKJFDLqlQr5upph3MZIYJ0EIEJ9b82ibF3X6vm2MvuB4Al4NeGkuC8n7I4NzEcgATc6YjfIiGQ== X-Received: by 2002:a62:211a:: with SMTP id h26-v6mr250263pfh.133.1528741184923; Mon, 11 Jun 2018 11:19:44 -0700 (PDT) Received: from ban.mtv.corp.google.com ([2620:0:1000:1501:bc2f:3082:9938:5d41]) by smtp.gmail.com with ESMTPSA id q82-v6sm81502560pfg.170.2018.06.11.11.19.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Jun 2018 11:19:43 -0700 (PDT) From: Brian Norris To: Kalle Valo Subject: [PATCH] ath10k: use crash_dump enum instead of magic numbers Date: Mon, 11 Jun 2018 11:19:35 -0700 Message-Id: <20180611181935.155032-1-briannorris@chromium.org> X-Mailer: git-send-email 2.18.0.rc1.242.g61856ae69a-goog X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180611_111957_160637_F209662A X-CRM114-Status: UNSURE ( 7.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Brian Norris , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The comments are telling you what the enum could tell you instead. Signed-off-by: Brian Norris --- drivers/net/wireless/ath/ath10k/core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 4cf54a7ef09a..eae46a04f503 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -41,10 +41,8 @@ static bool uart_print; static bool skip_otp; static bool rawmode; -/* Enable ATH10K_FW_CRASH_DUMP_REGISTERS and ATH10K_FW_CRASH_DUMP_CE_DATA - * by default. - */ -unsigned long ath10k_coredump_mask = 0x3; +unsigned long ath10k_coredump_mask = BIT(ATH10K_FW_CRASH_DUMP_REGISTERS) | + BIT(ATH10K_FW_CRASH_DUMP_CE_DATA); /* FIXME: most of these should be readonly */ module_param_named(debug_mask, ath10k_debug_mask, uint, 0644);