From patchwork Wed Jun 13 06:48:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Govind Singh X-Patchwork-Id: 10461679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 72A15603B4 for ; Wed, 13 Jun 2018 06:48:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 772A128AB4 for ; Wed, 13 Jun 2018 06:48:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6AD3528ABA; Wed, 13 Jun 2018 06:48:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 16B9828AB4 for ; Wed, 13 Jun 2018 06:48:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=PC6S7bqkR/+XYbffZ/l7aYEFzX+2IOlW2hyy+VHBRjU=; b=aoN TeF8R0h/J+3ZpmK6+k/LSPr7ZBRY4AjKpWlaSJqQdTlu/SXpY08aPgD4Q/IcXCaoDpY0ZCA6U8Ila DXAr+30TGvcrHNCrM8WpD3yw/LYYtFLCbTjJiLarMa9qpKxxUnDSc3phdS6VeSu3A/gtnJ38VfDD5 Jk9tQHQPEOMHNLVV64MXo+wV/T8kBp2SQKmV9YCd1KRlDSbJL/4aMMa1ODedKTAzpeOIkZl4RcJ0Y 8AHVgYLfiGVEFTSbEoOyJkIXLI5CmFICbXV/362arw0jMQNKnuXOjndKv8uyDYDXzdeT0eP8KKJoj lXGxOiN/PEZCEeNry1hQdivIGfullbg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSzZy-0006H2-2v; Wed, 13 Jun 2018 06:48:26 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fSzZu-0006FE-Kg for ath10k@lists.infradead.org; Wed, 13 Jun 2018 06:48:23 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id AD54260792; Wed, 13 Jun 2018 06:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1528872491; bh=x++g5P4a2tHcVKV0GEJ3ejORKraZvWq98vHIZl3OKes=; h=From:To:Cc:Subject:Date:From; b=Ju2FvBH0TlftrFsEvPRfinTxjzOPctYpK/l72oFzjs+ixpV8yrIqXflktqunJr/bp qa6tBSVR+zJQpt73Awq+ed7NjYgHxAo4yWdayvQkt5rGUtCjD0nUsWQmUnW0dB2ZS8 N6GTsiiDFAkUB5sk0eZusr+J9pibUc0HV1nvtfWw= Received: from govinds-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: govinds@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3E56460351; Wed, 13 Jun 2018 06:48:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1528872491; bh=x++g5P4a2tHcVKV0GEJ3ejORKraZvWq98vHIZl3OKes=; h=From:To:Cc:Subject:Date:From; b=Ju2FvBH0TlftrFsEvPRfinTxjzOPctYpK/l72oFzjs+ixpV8yrIqXflktqunJr/bp qa6tBSVR+zJQpt73Awq+ed7NjYgHxAo4yWdayvQkt5rGUtCjD0nUsWQmUnW0dB2ZS8 N6GTsiiDFAkUB5sk0eZusr+J9pibUc0HV1nvtfWw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3E56460351 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=govinds@codeaurora.org From: Govind Singh To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: Handle resource init failure case Date: Wed, 13 Jun 2018 12:18:06 +0530 Message-Id: <20180613064806.32286-1-govinds@codeaurora.org> X-Mailer: git-send-email 2.17.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180612_234822_719317_FF962DAD X-CRM114-Status: UNSURE ( 9.07 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Govind Singh , linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Return type of resource init method is not assigned. Handle resource init failures for graceful exit. Signed-off-by: Govind Singh --- drivers/net/wireless/ath/ath10k/snoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c index aa8a9b36250e..a0504b8e003c 100644 --- a/drivers/net/wireless/ath/ath10k/snoc.c +++ b/drivers/net/wireless/ath/ath10k/snoc.c @@ -1500,13 +1500,13 @@ static int ath10k_snoc_probe(struct platform_device *pdev) ar_snoc->ce.bus_ops = &ath10k_snoc_bus_ops; ar->ce_priv = &ar_snoc->ce; - ath10k_snoc_resource_init(ar); + ret = ath10k_snoc_resource_init(ar); if (ret) { ath10k_warn(ar, "failed to initialize resource: %d\n", ret); goto err_core_destroy; } - ath10k_snoc_setup_resource(ar); + ret = ath10k_snoc_setup_resource(ar); if (ret) { ath10k_warn(ar, "failed to setup resource: %d\n", ret); goto err_core_destroy;