From patchwork Wed Feb 6 12:14:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Govind Singh X-Patchwork-Id: 10799259 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C99361669 for ; Wed, 6 Feb 2019 12:15:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B81612AA4A for ; Wed, 6 Feb 2019 12:15:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id ACB882AA5B; Wed, 6 Feb 2019 12:15:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 40D212AA90 for ; Wed, 6 Feb 2019 12:15:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uGBIZSzxFKC4wkprg7e+9NTBfqufSMOVbFBJQhwmv+Y=; b=sfvA2jSnUMyE27 HAI5zUqVAKQNM0ASfzUPdw1RAVJryFJZNNPFhDMwyVN8LNQ/tTpayOBSdNKaa2AbtLYIWmaj9FbUx eZRpaFcEttt7m68xxO0MGmvF4Z/PTkGRDxOB2dvLzf+gVn9e0pAUnmzJLbfPztt8VRcwA5kh+RlZq usTekLWGlbUkeKvRRVtgSSoro3NcEH9GdOq2Zm9zL+HTnRdqAZusFBc1WwYeD4roZFfV6//6mwlPs upq5lbS6e5xQOiB9t5hT9jmux/lRyiA7yXCIrzfaGa1TKjYtZVpMAGpw9+9YMHWcjoOJwR3qmiGWx kJxUkAUFs1w1ZapOVN0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1grM6X-0006uP-5y; Wed, 06 Feb 2019 12:15:01 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1grM6P-0006ma-V5 for ath10k@lists.infradead.org; Wed, 06 Feb 2019 12:14:56 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 36B3A608EA; Wed, 6 Feb 2019 12:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549455293; bh=/nRid3yHLDg30Gwil/kLAeJdUVQULE5g5jP/kGRXhGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NbnvUF/RBRlxfnFEAFLTh+sAoPOkCW/P77GXRnhUcDE7q5vBVxPLVqQJYlnKwIYAn l/3aIPW2BWKSmphjBwgibm+CxG/wRcTsZE3cK4w7j/K+yJU7wCNQtHnOCVKc6FknpW vhH2eUQg49dadMysF8DsFQD16Wtng+UQF25miW/k= Received: from govinds-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: govinds@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 84D7B608EA; Wed, 6 Feb 2019 12:14:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549455291; bh=/nRid3yHLDg30Gwil/kLAeJdUVQULE5g5jP/kGRXhGs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lCI9kae8Ik4KeTQQfvndV66D57jv8YC+811OU0NRzitO38MLWIp9/NdNpHt9Y8C25 HneMPGSbTagaMloiIAiO29z6hcrV0uTICK73hhGJzGQez/wVqXAkDQP1aeP7sOf8lI ftlhuJ9vmOgJ0Q8SfnWX/SyoRQKx9leX8rKszhzE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 84D7B608EA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=govinds@codeaurora.org From: Govind Singh To: ath10k@lists.infradead.org Subject: [PATCH v3 3/3] ath10k: Request credit report if flow control enabled on ep Date: Wed, 6 Feb 2019 17:44:33 +0530 Message-Id: <20190206121433.11606-4-govinds@codeaurora.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190206121433.11606-1-govinds@codeaurora.org> References: <20190206121433.11606-1-govinds@codeaurora.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190206_041454_497693_77B8F895 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Govind Singh , linux-wireless@vger.kernel.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP FW credit flow control is enabled for only WMI ctrl service(CE3) but credit update is requested unconditionally on all HTC services as part of HTC tx in CE3/CE0/CE4. This is causing WOW failure as FW is not expecting credit report request on other end-points(CE0/CE4). Request credit report only on those endpoints where credit flow control is enabled. Testing: Tested on WCN3990 HW. Tested FW: WLAN.HL.2.0-01192-QCAHLSWMTPLZ-1. Signed-off-by: Govind Singh --- drivers/net/wireless/ath/ath10k/htc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/htc.c b/drivers/net/wireless/ath/ath10k/htc.c index 7654a21323ce..5aa57a01c033 100644 --- a/drivers/net/wireless/ath/ath10k/htc.c +++ b/drivers/net/wireless/ath/ath10k/htc.c @@ -88,7 +88,8 @@ static void ath10k_htc_prepare_tx_skb(struct ath10k_htc_ep *ep, hdr->eid = ep->eid; hdr->len = __cpu_to_le16(skb->len - sizeof(*hdr)); hdr->flags = 0; - hdr->flags |= ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE; + if (ep->tx_credit_flow_enabled) + hdr->flags |= ATH10K_HTC_FLAG_NEED_CREDIT_UPDATE; spin_lock_bh(&ep->htc->tx_lock); hdr->seq_no = ep->seq_no++;