diff mbox

[v2] ath10k: use MAC clock rate same as FW uses for survey accuracy

Message ID 6a113cdb1b0dbbb6d98ab6b363b4912474c32bac.1428701627.git.poh@qca.qualcomm.com (mailing list archive)
State Accepted
Headers show

Commit Message

Peter Oh April 13, 2015, 6:01 p.m. UTC
WLAN survey data provides several informative values on each channels
such as noise, active time, transmit time, and etc.
Regarding the channel activity time data, it is reported from firmware
in different form which is number of cycles instead of time itself.
Hence host driver converts it to time unit by dividing it by clock rate
that is used at baseband MAC.

Using difference clock rate from that actual HW is using will result in
inaccurate survey data. For instance, channel active time can be reported
with bigger than 150ms even though we set Dwell time to 150ms.
Therefore set the clock rate to 88000 (88 MHz) which is ath10k baseband
MAC is using.

Signed-off-by: Peter Oh <poh@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath10k/wmi.h | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Kalle Valo April 17, 2015, 6:44 a.m. UTC | #1
Peter Oh <poh@qca.qualcomm.com> writes:

> WLAN survey data provides several informative values on each channels
> such as noise, active time, transmit time, and etc.
> Regarding the channel activity time data, it is reported from firmware
> in different form which is number of cycles instead of time itself.
> Hence host driver converts it to time unit by dividing it by clock rate
> that is used at baseband MAC.
>
> Using difference clock rate from that actual HW is using will result in
> inaccurate survey data. For instance, channel active time can be reported
> with bigger than 150ms even though we set Dwell time to 150ms.
> Therefore set the clock rate to 88000 (88 MHz) which is ath10k baseband
> MAC is using.
>
> Signed-off-by: Peter Oh <poh@qca.qualcomm.com>

Thanks, applied.
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/wmi.h b/drivers/net/wireless/ath/ath10k/wmi.h
index d0942b0..2c03496 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.h
+++ b/drivers/net/wireless/ath/ath10k/wmi.h
@@ -4653,9 +4653,7 @@  struct wmi_peer_sta_kickout_event {
 } __packed;
 
 #define WMI_CHAN_INFO_FLAG_COMPLETE BIT(0)
-
-/* FIXME: empirically extrapolated */
-#define WMI_CHAN_INFO_MSEC(x) ((x) / 76595)
+#define WMI_CHAN_INFO_MSEC(x) ((x) / 88000)
 
 /* Beacon filter wmi command info */
 #define BCN_FLT_MAX_SUPPORTED_IES	256