From patchwork Wed Mar 23 13:00:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 8649721 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F38D8C0553 for ; Wed, 23 Mar 2016 13:00:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1D7AD2038A for ; Wed, 23 Mar 2016 13:00:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8EC8E2037F for ; Wed, 23 Mar 2016 13:00:55 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aiiOx-0004h2-Ts; Wed, 23 Mar 2016 13:00:43 +0000 Received: from wolverine02.qualcomm.com ([199.106.114.251]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aiiOv-0004dU-WD for ath10k@lists.infradead.org; Wed, 23 Mar 2016 13:00:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1458738041; x=1490274041; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=9ZKVbcIiGB4/Ucy6XYAn6bZ4pTFCk5Rk41dWWJ71m5k=; b=lAFgwY4+0yd/VyOLLe6pwght7gVuiV6Ig3kTzdBIlmPinDq6AQdp2D59 vUZApW0PCUQGcX7KKQHkOJh1OObQEFVAvGS1OJe3mbJtrBVpQXt98f6Mz 0nlHzKwCvsN89n1NXLnVV9ksgfFm5KNqDAzJPNc1tJJv/dT7Gl74IOaRj o=; X-IronPort-AV: E=Sophos;i="5.24,382,1455004800"; d="scan'208";a="273863625" Received: from ironmsg04-r-new.qualcomm.com (HELO Ironmsg04-R.qualcomm.com) ([10.53.140.108]) by wolverine02.qualcomm.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 23 Mar 2016 06:00:21 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8112"; a="1161931450" Received: from nasanexm01a.na.qualcomm.com ([10.85.0.81]) by Ironmsg04-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 23 Mar 2016 06:00:11 -0700 Received: from aphydexm01f.ap.qualcomm.com (10.252.127.15) by nasanexm01a.na.qualcomm.com (10.85.0.81) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Wed, 23 Mar 2016 06:00:10 -0700 Received: from euamsexm01a.eu.qualcomm.com (10.251.127.40) by aphydexm01f.ap.qualcomm.com (10.252.127.15) with Microsoft SMTP Server (TLS) id 15.0.1130.7; Wed, 23 Mar 2016 18:30:04 +0530 Received: from euamsexm01a.eu.qualcomm.com ([10.251.127.40]) by euamsexm01a.eu.qualcomm.com ([10.251.127.40]) with mapi id 15.00.1130.005; Wed, 23 Mar 2016 14:00:01 +0100 From: "Valo, Kalle" To: "Shajakhan, Mohammed Shafi (Mohammed Shafi)" Subject: Re: [PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4 Thread-Topic: [PATCH v1 3/3] ath10k: Enable parsing per station rx duration for 10.4 Thread-Index: AQHRhQPpl0Pj/gGVTkGmmth2fMGRiQ== Date: Wed, 23 Mar 2016 13:00:01 +0000 Message-ID: <8737rhfiy7.fsf@kamboji.qca.qualcomm.com> References: <1458132214-4896-1-git-send-email-mohammed@qca.qualcomm.com> <1458132214-4896-3-git-send-email-mohammed@qca.qualcomm.com> In-Reply-To: <1458132214-4896-3-git-send-email-mohammed@qca.qualcomm.com> (Mohammed Shafi Shajakhan's message of "Wed, 16 Mar 2016 18:13:34 +0530") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-ID: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160323_060042_130009_DC848B4B X-CRM114-Status: UNSURE ( 6.87 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.0 (-------) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mohammed@codeaurora.org" , "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Mohammed Shafi Shajakhan writes: > From: Mohammed Shafi Shajakhan > > Rx duration support for per station is part of extended peer > stats, enable provision to parse the same and provide backward > compatibility based on the 'stats_id' event > > Signed-off-by: Mohammed Shafi Shajakhan There was a new sparse warning: drivers/net/wireless/ath/ath10k/wmi.c:2978:42: warning: incorrect type in assignment (different base types) drivers/net/wireless/ath/ath10k/wmi.c:2978:42: expected unsigned int [unsigned] [usertype] rx_duration drivers/net/wireless/ath/ath10k/wmi.c:2978:42: got restricted __le32 const [usertype] rx_duration I fixed it like this in the pending branch, please double check: --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -2975,7 +2975,7 @@ static int ath10k_wmi_10_4_op_pull_fw_stats(struct ath10k *ar, ath10k_wmi_10_4_pull_peer_stats(&src->common, dst); /* FIXME: expose 10.4 specific values */ if (extd_peer_stats) - dst->rx_duration = src->rx_duration; + dst->rx_duration = __le32_to_cpu(src->rx_duration); list_add_tail(&dst->list, &stats->peers); }