From patchwork Wed Aug 31 07:04:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 9306407 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 69A49601C0 for ; Wed, 31 Aug 2016 07:05:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5BA2428D01 for ; Wed, 31 Aug 2016 07:05:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4ED7D28D88; Wed, 31 Aug 2016 07:05:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EB8BB28D01 for ; Wed, 31 Aug 2016 07:05:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bezaG-0000TQ-AN; Wed, 31 Aug 2016 07:05:16 +0000 Received: from wolverine01.qualcomm.com ([199.106.114.254]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bezaD-0008DF-KE for ath10k@lists.infradead.org; Wed, 31 Aug 2016 07:05:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1472627113; x=1504163113; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=x4V3wAEwm2ZqfyJ7kel7BsrBBc9/fWCbdPnZMg7VDr0=; b=KHXN7EK1r/+txJUcXWO+7YNjitysyPTvJ3XOwuAibyCqlGgfuATPyfew PCt7AzKnPwTi+FN47lmzoiWKLrhxjdMR2ZGyMeQrOX+huEMxKhTWjozgt QJRDjHHvgBsZovydEGmxVHMO0qb9V3++RnpnY1KP9lQOM6KnVoeQDDLz9 w=; X-IronPort-AV: E=Sophos;i="5.30,261,1470726000"; d="scan'208";a="220769104" Received: from unknown (HELO ironmsg02-L.qualcomm.com) ([10.53.140.109]) by wolverine01.qualcomm.com with ESMTP; 31 Aug 2016 00:04:52 -0700 X-IronPort-AV: E=McAfee;i="5700,7163,8273"; a="765834041" X-Amp-Result: CLEAN Received: from nasanexm02d.na.qualcomm.com ([10.85.0.44]) by ironmsg02-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 31 Aug 2016 00:04:51 -0700 Received: from aphydexm01a.ap.qualcomm.com (10.252.127.10) by NASANEXM02D.na.qualcomm.com (10.85.0.44) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 31 Aug 2016 00:04:50 -0700 Received: from euamsexm01a.eu.qualcomm.com (10.251.127.40) by aphydexm01a.ap.qualcomm.com (10.252.127.10) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 31 Aug 2016 12:34:44 +0530 Received: from euamsexm01a.eu.qualcomm.com ([10.251.127.40]) by euamsexm01a.eu.qualcomm.com ([10.251.127.40]) with mapi id 15.00.1178.000; Wed, 31 Aug 2016 09:04:43 +0200 From: "Valo, Kalle" To: Julian Calaby Subject: Re: [PATCHv3 1/3] ath10k: move firmware_swap_code_seg_info to ath10k_fw_file Thread-Topic: [PATCHv3 1/3] ath10k: move firmware_swap_code_seg_info to ath10k_fw_file Thread-Index: AQHSA1XyRRBcDOaUrky1jKZsM8KV3w== Date: Wed, 31 Aug 2016 07:04:42 +0000 Message-ID: <87poop4dx2.fsf@kamboji.qca.qualcomm.com> References: <1467356767-31646-1-git-send-email-c_traja@qti.qualcomm.com> In-Reply-To: (Julian Calaby's message of "Mon, 4 Jul 2016 10:49:55 +1000") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] Content-ID: <7C404886E6E015418BA390AA4BD06BA7@qualcomm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160831_000513_828764_90A32E74 X-CRM114-Status: GOOD ( 10.37 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Raja, Tamizh Chelvam" , linux-wireless , "tamizhchelvam@codeaurora.org" , "ath10k@lists.infradead.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Julian Calaby writes: > Hi Tamizh, > > On Fri, Jul 1, 2016 at 5:06 PM, wrote: >> From: Tamizh chelvam >> >> Preparation to make use of firmware_swap_code_seg_info for UTF binary. >> >> Signed-off-by: Tamizh chelvam >> --- >> drivers/net/wireless/ath/ath10k/core.c | 6 +++--- >> drivers/net/wireless/ath/ath10k/core.h | 6 ++---- >> drivers/net/wireless/ath/ath10k/swap.c | 26 ++++++++++++++------------ >> drivers/net/wireless/ath/ath10k/swap.h | 11 ++++++++--- >> 4 files changed, 27 insertions(+), 22 deletions(-) >> >> diff --git a/drivers/net/wireless/ath/ath10k/core.h b/drivers/net/wireless/ath/ath10k/core.h >> index 3da18c9..e69e7e7 100644 >> --- a/drivers/net/wireless/ath/ath10k/core.h >> +++ b/drivers/net/wireless/ath/ath10k/core.h >> @@ -654,6 +654,8 @@ struct ath10k_fw_file { >> >> const void *codeswap_data; >> size_t codeswap_len; >> + /* FIXME: add a comment */ >> + struct ath10k_swap_code_seg_info *firmware_swap_code_seg_info; > > Why not just add a comment? Adding FIXMEs makes the patch look incomplete to me. Actually I'm here to blame, I asked Tamizh to add the fixme so I can add a proper comment. I did it now: --- a/drivers/net/wireless/ath/ath10k/core.h +++ b/drivers/net/wireless/ath/ath10k/core.h @@ -663,7 +663,14 @@ struct ath10k_fw_file { const void *codeswap_data; size_t codeswap_len; - /* FIXME: add a comment */ + + /* The original idea of struct ath10k_fw_file was that it only + * contains struct firmware and pointers to various parts (actual + * firmware binary, otp, metadata etc) of the file. This seg_info + * is actually created separate but as this is used similarly as + * the other firmware components it's more convenient to have it + * here. + */ struct ath10k_swap_code_seg_info *firmware_swap_code_seg_info; };