From patchwork Wed Oct 4 09:49:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 9984119 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1CCF560365 for ; Wed, 4 Oct 2017 09:50:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0DB0328A64 for ; Wed, 4 Oct 2017 09:50:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0236728AA4; Wed, 4 Oct 2017 09:50:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 81C9728A64 for ; Wed, 4 Oct 2017 09:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=79JDYj7V25QOYOFlfJDOekTi/MIsqBVibN9U3xdA/3s=; b=siyC5ntvaiV0h2 7MPV39TCu3IzJrFFQA0Cybku4RKjJErkOIsGlgmUHO+2Qv+Yt6O6e6IAqRxu8JgKtJ3VIJbAFnfff lGnWjvOEtjCg5ZaPD6OQn+h7bHiwgmqJAvxA6UH+41KCEZ9GJ4nY3fzcyfWe/7cSZkUEmYI3IX+QL 3cTyJhDJm/xBrwlWaykIkXWLJkijWbi7QHS05IoxJkFWr9AJV/X4+daNI6gw8QQc+yf0xOe9XnSeF JGRrtljk2jNuiP8+sA2K9vLV0xjsMg9qWxwFDsBEFZgLbCBQDeqq5a6IB+FjPP8BWF1VPSgwt8TRr 9OuJspNqoLTNu7slgXTw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dzgJP-0002ul-Nl; Wed, 04 Oct 2017 09:49:55 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dzgJO-0002uG-7s for ath10k@bombadil.infradead.org; Wed, 04 Oct 2017 09:49:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Transfer-Encoding: Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pO7X/fW/BSNEtdLnKlwRO7J7bo079nHzyXFrOrc+uW8=; b=A59WCbyNuE0EQbdESif4ntnYxR 4Qr5XmUPGaeakz6vxTKRh+VZhGdV3wGyx/Z6Iafn6QSZO1eRgu9PhY5DBbsLyth9cSEqAEND0kX5n Q0AWZZU7MKPVpyn4PazRg1ePkI7WOPq1s/5f4eJulARVpXNNjOfsRHcSpcAuAU5QiwOge9n9ii2G9 QYnz7M+yV5BMBgpCcGzBSXRxc3+PmuC8YK+lR52o4hxnQ2kTKy7Klg7VTEPCMr8y0CYdJowTjjHpn aVg+3/o86BT4dxopcPw0bX2/TAMZJ3eplBhcbH6iKbXw1c8Gvr9t3YvHj1E5r1WHU9nNXjL1IiBGW fKGphmkA==; Received: from alexa-out.qualcomm.com ([129.46.98.28]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dzgJJ-0002xE-Ms for ath10k@lists.infradead.org; Wed, 04 Oct 2017 09:49:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1507110590; x=1538646590; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OKBoegNaUDNR7Ywdawpkmf2rwRJsFAk5XhDDEVgkbU0=; b=yYrak9CLs+zZ98bA6JYw8OON+AZ2qpcOltsDd4r/vTqhiwRuydgnKCro T5c991SbzcpXYJzM4dyfuaBh99vhlEYi1bbH7+UieKA7hmHK5NqXJJY35 z2kgYaHLEgeCY9LknZZk4HiItCz5J85V3BUmQsGZVimgQhH/OzbEkJFzE 0=; X-IronPort-AV: E=Sophos;i="5.42,477,1500966000"; d="scan'208";a="6061076" Received: from ironmsg03-l-new.qualcomm.com (HELO Ironmsg03-L.qualcomm.com) ([10.53.140.110]) by alexa-out.qualcomm.com with ESMTP; 04 Oct 2017 02:49:24 -0700 X-IronPort-AV: E=McAfee;i="5900,7806,8673"; a="1458787623" X-MGA-submission: =?us-ascii?q?MDGjsKawfTx8eWNpVuwNdjF+QPEb9inPu5z7LT?= =?us-ascii?q?y+ZCDTBX3SsX5r04o6JUI2xb1W+0wNMSQU7I8mOzhsD3VK5QP2EvwcKn?= =?us-ascii?q?OH2yb7Zb5vbKMiYYFT3SLEQKHDpcfF8TvV4486xZfkolhKJU3P+o9Anq?= =?us-ascii?q?n4?= Received: from nasanexm02h.na.qualcomm.com ([10.85.0.89]) by Ironmsg03-L.qualcomm.com with ESMTP/TLS/AES256-SHA; 04 Oct 2017 02:49:23 -0700 Received: from euamsexm01e.eu.qualcomm.com (10.251.127.42) by nasanexm02h.na.qualcomm.com (10.85.0.89) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Wed, 4 Oct 2017 02:49:22 -0700 Received: from euamsexm01e.eu.qualcomm.com (10.251.127.42) by euamsexm01e.eu.qualcomm.com (10.251.127.42) with Microsoft SMTP Server (TLS) id 15.0.1293.2; Wed, 4 Oct 2017 11:49:19 +0200 Received: from euamsexm01e.eu.qualcomm.com ([10.251.127.42]) by euamsexm01e.eu.qualcomm.com ([10.251.127.42]) with mapi id 15.00.1293.002; Wed, 4 Oct 2017 11:49:18 +0200 From: Kalle Valo To: "silexcommon@gmail.com" Subject: Re: [PATCH 08/11] ath10k_sdio: common read write Thread-Topic: [PATCH 08/11] ath10k_sdio: common read write Thread-Index: AQHTPPYLZV1O5v+hvEKGFNUdKTMTtA== Date: Wed, 4 Oct 2017 09:49:18 +0000 Message-ID: <87wp4bw8de.fsf@kamboji.qca.qualcomm.com> References: <1506793068-27445-1-git-send-email-alagusankar@silex-india.com> <1506793068-27445-9-git-send-email-alagusankar@silex-india.com> In-Reply-To: <1506793068-27445-9-git-send-email-alagusankar@silex-india.com> (silexcommon@gmail.com's message of "Sat, 30 Sep 2017 23:07:45 +0530") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171004_104950_037032_9A75FE5E X-CRM114-Status: UNSURE ( 8.74 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alagu Sankar , "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP silexcommon@gmail.com writes: > From: Alagu Sankar > > convert different read write functions in sdio hif to bring it under a > single read-write path. This helps in having a common dma bounce buffer > implementation. Also helps in address modification that is required > specific to change in certain mbox addresses of sdio_write. > > Signed-off-by: Alagu Sankar This didn't compile for me: drivers/net/wireless/ath/ath10k/sdio.c:320:12: error: conflicting types for 'ath10k_sdio_read' drivers/net/wireless/ath/ath10k/sdio.c:39:12: note: previous declaration of 'ath10k_sdio_read' was here drivers/net/wireless/ath/ath10k/sdio.c:365:12: error: conflicting types for 'ath10k_sdio_write' drivers/net/wireless/ath/ath10k/sdio.c:41:12: note: previous declaration of 'ath10k_sdio_write' was here drivers/net/wireless/ath/ath10k/sdio.c:39:12: warning: 'ath10k_sdio_read' used but never defined drivers/net/wireless/ath/ath10k/sdio.c:41:12: warning: 'ath10k_sdio_write' used but never defined gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609 I fixed it like below in the pending branch. But I'll review more carefully later, I have quite a lot of patches pending right now. --- a/drivers/net/wireless/ath/ath10k/sdio.c +++ b/drivers/net/wireless/ath/ath10k/sdio.c @@ -37,9 +37,9 @@ #define ATH10K_SDIO_DMA_BUF_SIZE (32 * 1024) static int ath10k_sdio_read(struct ath10k *ar, u32 addr, void *buf, - u32 len, bool incr); + size_t len, bool incr); static int ath10k_sdio_write(struct ath10k *ar, u32 addr, const void *buf, - u32 len, bool incr); + size_t len, bool incr); /* inlined helper functions */