From patchwork Mon Mar 2 12:20:08 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 5911961 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0BE2CBF440 for ; Mon, 2 Mar 2015 12:20:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 38EB220166 for ; Mon, 2 Mar 2015 12:20:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 640E62015E for ; Mon, 2 Mar 2015 12:20:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YSPKq-0004Wo-JY; Mon, 02 Mar 2015 12:20:32 +0000 Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YSPKo-0004Sb-J0 for ath10k@lists.infradead.org; Mon, 02 Mar 2015 12:20:31 +0000 Received: by wggx12 with SMTP id x12so32993611wgg.11 for ; Mon, 02 Mar 2015 04:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=iF37pNNvPQnlQszGNu+3BTg73rGjnVZsrr03SCv+4Mw=; b=YU/TkfDyp43sWv1N0oRMifGm291E6md+oKdDWGymQ/qPtuFXpDz1eeyogoQYJJrzaW 4YNc/KkgLX8rmTbFGqt6nr83dNf46VeUz1KSaGH5Cwg73jlronS4DVeNRUnbIVdF+pgz MP33lcShToefN43uN0132mA6+/ChWlUiOdrbM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=iF37pNNvPQnlQszGNu+3BTg73rGjnVZsrr03SCv+4Mw=; b=c1AhY/BfDVzMrwdjsplZAkpQZx8IU7vrmcIfD5vKAbuRPpoKvFTXIfalXoAgyq1vh4 7XMRBGIF9fjH6TPWcInZpCYKslhYzPXRLm/DTlmQrX+OLGjMFvZ78X1Xn5gntKR2H0fd 6OV4+oh9AQ7Zv7fWnyYnpzCBveL2eVht8XtvIPDqh6CRgbRgkuB17gHeMyaHtpfmvZVE qmaT0gMUeubv8sswS29CbcuSAoQGb8Bg7Bd9QiEyzWeDSCTa0N8P4oY/Zet4ygW45I6Z Oeng36AB0+0mG1Dn7+KC4mXRHQLA8VqW9SDZgQX4AHrwabPx+GQWzzmeY07a/MXbgDQm Ymkw== X-Gm-Message-State: ALoCoQkdKyEUSLb+4PCQ3TUzRZO5q9enGbje7P1xnqHPMDOYUhZCFE6iq1+64fPxIfsFGPNe9rsFTJxPXG9mA36B0ZQs2IeVGRPNZtsPKRUwzrvCaT2v/yYlNo2J+Fl3kvSBgcTg6nwa MIME-Version: 1.0 X-Received: by 10.180.206.143 with SMTP id lo15mr10343351wic.22.1425298808219; Mon, 02 Mar 2015 04:20:08 -0800 (PST) Received: by 10.27.51.202 with HTTP; Mon, 2 Mar 2015 04:20:08 -0800 (PST) In-Reply-To: <54EB3C30.60302@sophos.com> References: <54EB264D.5040805@sophos.com> <54EB2ED5.8040104@sophos.com> <54EB3C30.60302@sophos.com> Date: Mon, 2 Mar 2015 13:20:08 +0100 Message-ID: Subject: Re: ath10k + INTEL_IDLE aka. cstates == firmware crash From: Michal Kazior To: Fabian Wittenberg X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150302_042030_770598_5B08F1CB X-CRM114-Status: GOOD ( 10.21 ) X-Spam-Score: -0.8 (/) Cc: "ath10k@lists.infradead.org" X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 23 February 2015 at 15:41, Fabian Wittenberg wrote: > Hi Michal, > > I already did this approach. This works fine and is the current > workaround to get the product out, but I would like to know what the > basic problem is. > The power consumption increases by ~1.25W on idle devices if you disable > cstates. This is not a real problem but a low mem corruption is one. > So I assume a bug in the ath10k-driver/firmware. Hi Fabian, Can you try the following diff with _INTEL_IDLE=y, please? Micha? --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -2531,6 +2531,11 @@ static int ath10k_pci_claim(struct ath10k *ar) pci_set_master(pdev); + /* Disable RETRY_TIMEOUT register to prevent PCI Tx retries from + * interfering with C3 CPU state. + */ + pci_write_config_byte(pdev, 0x41, 0); + /* Workaround: Disable ASPM */ pci_read_config_dword(pdev, 0x80, &lcr_val); pci_write_config_dword(pdev, 0x80, (lcr_val & 0xffffff00));