diff mbox

[v4,6/6] ath10k: introduce basic tdls functionality

Message ID CADnKcVhg8ZVD8Nn7pqjtCUWWOiO_8Zp7-U0zaMh4FKL-pj3bLg@mail.gmail.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Marek Puzyniak March 27, 2015, 2:33 p.m. UTC 
Hi Kalle,

On 20 March 2015 at 07:02, Marek Puzyniak <marek.puzyniak@tieto.com> wrote:
> This patch introduces tdls without tdls peer uapsd
> and tdls channel switching.
> Transmitting tdls data frames works only for ethernet
> type frames, that's why data addressed to tdls sta
> is in ethernet format.
>
> This patch depends on:
> mac80211: initialize rate control earlier for tdls station
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> Signed-off-by: Marek Kwaczynski <marek.kwaczynski@tieto.com>
> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
> ---
[...]

> +static int ath10_mac_tdls_vifs_count(struct ieee80211_hw *hw)
[...]
> +               num_tdls_vifs = ath10_mac_tdls_vifs_count(hw);
[...]

I found typo in my patch. This can be fixed by


@@ -4704,7 +4704,7 @@ static int ath10k_sta_state(struct ieee80211_hw *hw,
                        goto exit;

                num_tdls_stations = ath10k_mac_tdls_vif_stations_count(hw, vif);
-               num_tdls_vifs = ath10_mac_tdls_vifs_count(hw);
+               num_tdls_vifs = ath10k_mac_tdls_vifs_count(hw);

                if (num_tdls_vifs >= ar->max_num_tdls_vdevs &&
                    num_tdls_stations == 0) {


Should I resend this patch or whole patch-set, or maybe it can be
handled in another way.

Marek

Comments

Kalle Valo March 27, 2015, 5:43 p.m. UTC | #1 
Marek Puzyniak <marek.puzyniak@tieto.com> writes:

> Hi Kalle,
>
> On 20 March 2015 at 07:02, Marek Puzyniak <marek.puzyniak@tieto.com> wrote:
>> This patch introduces tdls without tdls peer uapsd
>> and tdls channel switching.
>> Transmitting tdls data frames works only for ethernet
>> type frames, that's why data addressed to tdls sta
>> is in ethernet format.
>>
>> This patch depends on:
>> mac80211: initialize rate control earlier for tdls station
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>> Signed-off-by: Marek Kwaczynski <marek.kwaczynski@tieto.com>
>> Signed-off-by: Marek Puzyniak <marek.puzyniak@tieto.com>
>> ---
> [...]
>
>> +static int ath10_mac_tdls_vifs_count(struct ieee80211_hw *hw)
> [...]
>> +               num_tdls_vifs = ath10_mac_tdls_vifs_count(hw);
> [...]
>
> I found typo in my patch. This can be fixed by

Thanks, I fixed this directly in the pending branch.
diff mbox

Patch

diff --git a/drivers/net/wireless/ath/ath10k/mac.c
b/drivers/net/wireless/ath/ath10k/mac.c
index 4e2be87..5eb6c98 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -4613,7 +4613,7 @@  static void ath10k_mac_tdls_vifs_count_iter(void
*data, u8 *mac,
                (*num_tdls_vifs)++;
 }

-static int ath10_mac_tdls_vifs_count(struct ieee80211_hw *hw)
+static int ath10k_mac_tdls_vifs_count(struct ieee80211_hw *hw)
 {
        int num_tdls_vifs = 0;