From patchwork Fri Mar 27 14:33:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Puzyniak X-Patchwork-Id: 6107881 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4ACF7BF90F for ; Fri, 27 Mar 2015 14:34:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2A1A4203FB for ; Fri, 27 Mar 2015 14:34:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41CD22041B for ; Fri, 27 Mar 2015 14:34:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YbVL8-0004dC-Uv; Fri, 27 Mar 2015 14:34:27 +0000 Received: from mail-ie0-x231.google.com ([2607:f8b0:4001:c03::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YbVL5-0004O4-ER for ath10k@lists.infradead.org; Fri, 27 Mar 2015 14:34:24 +0000 Received: by iedfl3 with SMTP id fl3so80706953ied.1 for ; Fri, 27 Mar 2015 07:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=d3tr9qdqmj+9pGzgCuiyIe+WkXl21WajkngdpAjFEfk=; b=gtN3R401mI5R7VAkpIxXgUOFfhPpxQr/OJw5dvmLjnXiM2E0gdot9i3rmrb5/XpZX9 i2iJOu9maICjgJKVfEJgAjcRuWlokFmwUHFb1WcZz3uwIPKc8cS8zG0gHSlSg4LH3cUb xvwnneirdW/IR2dXyMejf6FVkd0yOFI5PnDTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=d3tr9qdqmj+9pGzgCuiyIe+WkXl21WajkngdpAjFEfk=; b=A6XZnilK3/ZFit7d0GpigWrQxO4M6g36/z0ov/XgFllbHWTA7SLvLsxh1LX8TDlZdB 3jtgr6lov08/0ceCjAKBGPeKNnuWIhtfL1Ij2ZZ0ZC5YXnkjc63w7WI30v2w7BRX9PKu Ds5KUhbaDG9NH9GBaxPanyPJA3Vd/PWcA5Zb1HFDd9NJu/FGmF0dZFVEXELuqXAgOFjr dqRrHpthkZN2TRYBwAMprBpdDmQoID8yKwzOKtaBzMf/czBoQuaC/+np5enrSNpI+nK5 9bxtR3dcZymDLq+RvgOzPiQZ89OmfFeJACwad4Bxw9JQSWkItOQayPfgUyZBRWOlMU95 mWFg== X-Gm-Message-State: ALoCoQnpQ5wrrtTja2G6gdWA5mYTv7MlumSMI2TWff6ZS5HrVRV7lx91kW/u059CuXlpBZenu8owGnWNC2Vh7oWry7y/oy72AjMoc5z3aY3RQiVbN0nQzBrW94TLy/acwWvohN5ya/a6 MIME-Version: 1.0 X-Received: by 10.50.32.7 with SMTP id e7mr45058257igi.21.1427466836145; Fri, 27 Mar 2015 07:33:56 -0700 (PDT) Received: by 10.36.80.133 with HTTP; Fri, 27 Mar 2015 07:33:56 -0700 (PDT) In-Reply-To: <1426849379-7562-7-git-send-email-marek.puzyniak@tieto.com> References: <1426849379-7562-1-git-send-email-marek.puzyniak@tieto.com> <1426849379-7562-7-git-send-email-marek.puzyniak@tieto.com> Date: Fri, 27 Mar 2015 10:33:56 -0400 Message-ID: Subject: Re: [PATCH v4 6/6] ath10k: introduce basic tdls functionality From: Marek Puzyniak To: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150327_073423_531644_7404B98E X-CRM114-Status: GOOD ( 10.75 ) X-Spam-Score: -0.8 (/) Cc: Marek Kwaczynski , Marek Puzyniak , Michal Kazior X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Kalle, On 20 March 2015 at 07:02, Marek Puzyniak wrote: > This patch introduces tdls without tdls peer uapsd > and tdls channel switching. > Transmitting tdls data frames works only for ethernet > type frames, that's why data addressed to tdls sta > is in ethernet format. > > This patch depends on: > mac80211: initialize rate control earlier for tdls station > > Signed-off-by: Michal Kazior > Signed-off-by: Marek Kwaczynski > Signed-off-by: Marek Puzyniak > --- [...] > +static int ath10_mac_tdls_vifs_count(struct ieee80211_hw *hw) [...] > + num_tdls_vifs = ath10_mac_tdls_vifs_count(hw); [...] I found typo in my patch. This can be fixed by @@ -4704,7 +4704,7 @@ static int ath10k_sta_state(struct ieee80211_hw *hw, goto exit; num_tdls_stations = ath10k_mac_tdls_vif_stations_count(hw, vif); - num_tdls_vifs = ath10_mac_tdls_vifs_count(hw); + num_tdls_vifs = ath10k_mac_tdls_vifs_count(hw); if (num_tdls_vifs >= ar->max_num_tdls_vdevs && num_tdls_stations == 0) { Should I resend this patch or whole patch-set, or maybe it can be handled in another way. Marek diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index 4e2be87..5eb6c98 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -4613,7 +4613,7 @@ static void ath10k_mac_tdls_vifs_count_iter(void *data, u8 *mac, (*num_tdls_vifs)++; } -static int ath10_mac_tdls_vifs_count(struct ieee80211_hw *hw) +static int ath10k_mac_tdls_vifs_count(struct ieee80211_hw *hw) { int num_tdls_vifs = 0;