From patchwork Wed May 8 14:45:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkateswara Naralasetty X-Patchwork-Id: 10935837 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 496FA1515 for ; Wed, 8 May 2019 14:45:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3770B276D6 for ; Wed, 8 May 2019 14:45:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B930283E8; Wed, 8 May 2019 14:45:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 16B3B2844B for ; Wed, 8 May 2019 14:45:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=9AlYHzEta7dlBT7uuJ0d+NkQekHcZ7J3Y0r9iT4ITuc=; b=tay RnAA1ejihlKo6blXxUBxxH4jRFDOI/p003Y/4OZCg4tBa/Kc+X6MK7Uu6LAHHaWnY6xRqwD/jm84n fDSSC2meRRd8noFvds1kzCMwd2YDUz8uhcwOAkMYwDQlPKHv3XDP7ICHeBr81sFwNnT4RaVIpo7Rx +ibTPR5eumQ1IJ4dq6b/AFl3admFWC6sjbwTwanX5vhKWqLdW6kzhLro6FLOrdTWf9aXTa3IaPX4H HA8yg+M/0N1U3gUYErZHVBiTiwr1I/O8IM6fRc2KPDh/LcjbYjG539sM0lnkFmU/62VOCUoy2lrcm p4cBNNVKJ/5Krmtfif1utHJxtMZGGKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hONpB-0007Xs-Cp; Wed, 08 May 2019 14:45:37 +0000 Received: from alexa-out-blr-02.qualcomm.com ([103.229.18.198] helo=alexa-out-blr.qualcomm.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hONp8-0007X0-Ky for ath11k@lists.infradead.org; Wed, 08 May 2019 14:45:36 +0000 Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by alexa-out-blr.qualcomm.com with ESMTP/TLS/AES256-SHA; 08 May 2019 20:15:29 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9250"; a="8583290" Received: from vnaralas-linux.qualcomm.com ([10.201.26.231]) by ironmsg02-blr.qualcomm.com with ESMTP; 08 May 2019 20:15:29 +0530 Received: by vnaralas-linux.qualcomm.com (Postfix, from userid 443942) id 5E8421A1D; Wed, 8 May 2019 20:15:28 +0530 (IST) From: Venkateswara Naralasetty To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: fix target assert when unload driver Date: Wed, 8 May 2019 20:15:26 +0530 Message-Id: <1557326726-29837-1-git-send-email-vnaralas@codeaurora.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190508_074535_134188_DEDFA57E X-CRM114-Status: UNSURE ( 7.68 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Venkateswara Naralasetty MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Currently ath11k_ahb_ext_irq_disable() called before ath11k_mac_unregister which will disable napi before mac_unregister and still we might receive packets on all active devices which results reo_dest_ring full. Fix this issue by moving ath11k_ahb_ext_irq_disable() after ath11k_mac_unregister(). Signed-off-by: Venkateswara Naralasetty --- drivers/net/wireless/ath/ath11k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index dc56df5..e3e6b64 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -486,6 +486,7 @@ static int ath11k_core_pdev_create(struct ath11k_base *sc) static void ath11k_core_pdev_destroy(struct ath11k_base *sc) { ath11k_mac_unregister(sc); + ath11k_ahb_ext_irq_disable(sc); ath11k_dp_pdev_free(sc); } @@ -781,7 +782,6 @@ void ath11k_core_deinit(struct ath11k_base *sc) { mutex_lock(&sc->core_lock); - ath11k_ahb_ext_irq_disable(sc); ath11k_core_pdev_destroy(sc); ath11k_core_stop(sc);