From patchwork Mon Jun 3 10:54:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasanthakumar Thiagarajan X-Patchwork-Id: 10972749 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EAE2E76 for ; Mon, 3 Jun 2019 10:54:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8C032872F for ; Mon, 3 Jun 2019 10:54:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB710287CD; Mon, 3 Jun 2019 10:54:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6A5582872F for ; Mon, 3 Jun 2019 10:54:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=xktQZ7+6JyBSAmkzw2YPs3qez6HJnqcf+6rhhk+4VtM=; b=cR7PBTk6lYUpfg NxnE9ms5pzS113a1cuDz6WR7TDmYsRij4sq2/zSJJ9zqOasDoMwx7cBYlFhccyaQ5Dh9tbT6OYRZS hAIhr+T28tLV2jJV3v1D83UjwG3Kd5qLDXJnqXduuUmNcbfexR16WTWRf5kcvvxypUGTVrKtXiz15 fC8QzCZbqb5bzBoPPRdNfsK15+A719MsVlAMttRMCuRxZz0xc/a3KjQQISzDoKtrX+hkeZjgn43LD zf5dJ9aP/h1yTrwIN6wUjTvcD4n7QPpv92o7N60jRUVZNhFUQ5vr29lzpMRfI8hUAKIPXe9KLF+vF O3VV0cRDQ/k3A6WY0UTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXkcE-0001DM-4l; Mon, 03 Jun 2019 10:54:58 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hXkcA-0000wS-Q5 for ath11k@lists.infradead.org; Mon, 03 Jun 2019 10:54:56 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B6E22609D4; Mon, 3 Jun 2019 10:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559559293; bh=KOpcqXBBpaxXyurjSTBwNGw7K8HPt/sEVHjCwyUCOKY=; h=From:To:Subject:Date:From; b=OlMWcjr3TboUAoWfq/0HtXctq9ro/FIISNDiFbBpDS1kAyUqcGnzF/Qwip2arEsvN FpcthD7FjKI2WOeaMuXYo+DHPrahOWN5VNe1FDtBVEDZFvrcj0HVZp20slIc7JRYvO lVs0g2S5AQR2FikADOfsNDSKBVi2iqE6HZ0Nv5ns= Received: from vasanth-lnx.qca.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vthiagar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9DE626043F for ; Mon, 3 Jun 2019 10:54:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559559293; bh=KOpcqXBBpaxXyurjSTBwNGw7K8HPt/sEVHjCwyUCOKY=; h=From:To:Subject:Date:From; b=OlMWcjr3TboUAoWfq/0HtXctq9ro/FIISNDiFbBpDS1kAyUqcGnzF/Qwip2arEsvN FpcthD7FjKI2WOeaMuXYo+DHPrahOWN5VNe1FDtBVEDZFvrcj0HVZp20slIc7JRYvO lVs0g2S5AQR2FikADOfsNDSKBVi2iqE6HZ0Nv5ns= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9DE626043F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vthiagar@codeaurora.org From: Vasanthakumar Thiagarajan To: ath11k@lists.infradead.org Subject: [PATCH] ath11k/dp_tx: Remove endian conversion in HTT_H2T_MSG_TYPE_RX_RING_SELECTION_CFG Date: Mon, 3 Jun 2019 16:24:37 +0530 Message-Id: <1559559277-21696-1-git-send-email-vthiagar@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190603_035454_885126_E3B127A5 X-CRM114-Status: UNSURE ( 9.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP With copyengine performing byte-swap when host target endian is different, driver should not do any endian conversion over the messages going through any of the copyengines. Remove the endian conversion while sending HTT_H2T_MSG_TYPE_RX_RING_SELECTION_CFG, this also fixes the below sparse warnings. drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: warning: incorrect type in assignment (different base types) drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: expected unsigned int [usertype] pkt_type_en_flags0 drivers/net/wireless/ath/ath11k/dp_tx.c:837:33: got restricted __le32 [usertype] drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: warning: incorrect type in assignment (different base types) drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: expected unsigned int [usertype] pkt_type_en_flags1 drivers/net/wireless/ath/ath11k/dp_tx.c:838:33: got restricted __le32 [usertype] drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: warning: incorrect type in assignment (different base types) drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: expected unsigned int [usertype] pkt_type_en_flags2 drivers/net/wireless/ath/ath11k/dp_tx.c:839:33: got restricted __le32 [usertype] drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: warning: incorrect type in assignment (different base types) drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: expected unsigned int [usertype] pkt_type_en_flags3 drivers/net/wireless/ath/ath11k/dp_tx.c:840:33: got restricted __le32 [usertype] drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: warning: incorrect type in assignment (different base types) drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: expected unsigned int [usertype] rx_filter_tlv drivers/net/wireless/ath/ath11k/dp_tx.c:841:28: got restricted __le32 [usertype] Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath11k/dp_tx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index 2a15ca3..5670796 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -834,11 +834,11 @@ int ath11k_dp_htt_rx_filter_setup(struct ath11k_base *ab, u32 ring_id, cmd->info1 = FIELD_PREP(HTT_RX_RING_SELECTION_CFG_CMD_INFO1_BUF_SIZE, rx_buf_size); - cmd->pkt_type_en_flags0 = __cpu_to_le32(tlv_filter->pkt_filter_flags0); - cmd->pkt_type_en_flags1 = __cpu_to_le32(tlv_filter->pkt_filter_flags1); - cmd->pkt_type_en_flags2 = __cpu_to_le32(tlv_filter->pkt_filter_flags2); - cmd->pkt_type_en_flags3 = __cpu_to_le32(tlv_filter->pkt_filter_flags3); - cmd->rx_filter_tlv = __cpu_to_le32(tlv_filter->rx_filter); + cmd->pkt_type_en_flags0 = tlv_filter->pkt_filter_flags0; + cmd->pkt_type_en_flags1 = tlv_filter->pkt_filter_flags1; + cmd->pkt_type_en_flags2 = tlv_filter->pkt_filter_flags2; + cmd->pkt_type_en_flags3 = tlv_filter->pkt_filter_flags3; + cmd->rx_filter_tlv = tlv_filter->rx_filter; ret = ath11k_htc_send(&ab->htc, ab->dp.eid, skb); if (ret)