From patchwork Thu Oct 31 12:25:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Govindaraj Saminathan X-Patchwork-Id: 11221153 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DAFE01599 for ; Thu, 31 Oct 2019 12:26:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD12B2087F for ; Thu, 31 Oct 2019 12:26:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jnLP+FQb"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="PLwhJvvb"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YjMtrD3B" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD12B2087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=DpDK/yldg1rAwb8JvUA4MP5hvEfqwsGQJKhY+NskTsw=; b=jnL P+FQbLPmcLxaeoD6SDf9h8GX2Kw16JHqE7QwKKulSb5+KKFwwYI4latk8ZTv10xwSw1o7wDIYyVZ5 s80MGHHASsjCId/3DZ+kerwHjBX2LeQbcUalB37yx07dl8EVCW3u2a3E1MmKL8yo7l3ODBYWGBYYD 24CREcWWxIimZOTIqMifKB2OfY9CnHOZfw/E8Rrm72e0Pn+b+8kAL9vNxTB80N+rByDGFerhEbgeZ SG6gzYVIS5cVwGJo+2RbMAZec6lzcB3wwWYXk0Gy6z0qAE03LjjMhflKarn/Un0CFtcfz5dbFCWdK ovOxOiaduZevC92G98/6U70tLIYYUgw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQ9Wi-0005RI-P0; Thu, 31 Oct 2019 12:26:08 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iQ9Wf-0005Qp-Rf for ath11k@lists.infradead.org; Thu, 31 Oct 2019 12:26:07 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 02B4D6079C; Thu, 31 Oct 2019 12:26:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572524765; bh=wfI+38FRu579PSsgrZMXRo2bTXIkn8p/KCdBGCToGJw=; h=From:To:Cc:Subject:Date:From; b=PLwhJvvbLF23LgiXrhAb9QRW+O4X1FghqjMl4OLxBFvniPC/2NudpT04NzT2MeGHK T5CYShDo4zfS2ZgFnSN4gHUFUfwAmG1ppvk9ExPxzr2HHyXvuQgVquYwnfQbt9Ml1q 9HUy9Kn+YKYs7QMcS7X5PKiMom0LWFCIkBLyasfY= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from c-gsamin-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gsamin@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4FA17603A3; Thu, 31 Oct 2019 12:26:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572524764; bh=wfI+38FRu579PSsgrZMXRo2bTXIkn8p/KCdBGCToGJw=; h=From:To:Cc:Subject:Date:From; b=YjMtrD3BIIJtOhOpfo6oP54dg75t9IRfaxjU2bFRyUpZ7cLacKGk7/g3bmDCd6BBE lGDaPZEOCmdsN65N2RrVBT5KYBS8bVygsV1P/WmJW8ijzARTmJs0pHRkpfuZyAKaqn q+a87lo1VPtgX8AkzsCx1XN+o7/2OIZzN62AfDfU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4FA17603A3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=gsamin@codeaurora.org From: Govindaraj Saminathan To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: unlock mutex during failure in qmi fw ready Date: Thu, 31 Oct 2019 17:55:47 +0530 Message-Id: <1572524747-25843-1-git-send-email-gsamin@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191031_052605_921083_DD56568A X-CRM114-Status: UNSURE ( 8.11 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [198.145.29.96 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Govindaraj Saminathan MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org qmi firmware ready event start to initialize the core modules and the sequence executed with mutex lock. In case of any failure mutex should be unlocked otherwise it will hang during the recovery. Signed-off-by: Govindaraj Saminathan --- drivers/net/wireless/ath/ath11k/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index 9324dcb..d2dd0ba 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -531,6 +531,7 @@ int ath11k_core_qmi_firmware_ready(struct ath11k_base *ab) ath11k_core_stop(ab); err_dp_free: ath11k_dp_free(ab); + mutex_unlock(&ab->core_lock); return ret; }