From patchwork Mon Oct 30 20:03:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Johannes Berg X-Patchwork-Id: 10033049 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CBE6E600C5 for ; Mon, 30 Oct 2017 20:04:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFA492896D for ; Mon, 30 Oct 2017 20:04:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B40FB28970; Mon, 30 Oct 2017 20:04:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 218A12896D for ; Mon, 30 Oct 2017 20:04:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932539AbdJ3UEE (ORCPT ); Mon, 30 Oct 2017 16:04:04 -0400 Received: from s3.sipsolutions.net ([144.76.63.242]:50584 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932083AbdJ3UEC (ORCPT ); Mon, 30 Oct 2017 16:04:02 -0400 Received: by sipsolutions.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1e9GHw-0001q9-Hq; Mon, 30 Oct 2017 21:04:00 +0100 Message-ID: <1509393839.2637.3.camel@sipsolutions.net> Subject: Re: Compiling error of backport-4.12.c From: Johannes Berg To: =?UTF-8?Q?=E5=90=B3=E9=87=8D=E6=AF=85?= Cc: backports@vger.kernel.org Date: Mon, 30 Oct 2017 21:03:59 +0100 In-Reply-To: <1509005208.2421.51.camel@sipsolutions.net> (sfid-20171026_100654_665631_5F5B08F1) References: <1508843560.2639.28.camel@sipsolutions.net> <1508854185.2639.32.camel@sipsolutions.net> (sfid-20171026_055256_037938_4070B188) <1509002960.2421.50.camel@sipsolutions.net> (sfid-20171026_092934_213999_8CEEC02D) <1509005208.2421.51.camel@sipsolutions.net> (sfid-20171026_100654_665631_5F5B08F1) X-Mailer: Evolution 3.26.0-1 Mime-Version: 1.0 Sender: backports-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: backports@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Thu, 2017-10-26 at 10:06 +0200, Johannes Berg wrote: > On Thu, 2017-10-26 at 09:29 +0200, Johannes Berg wrote: > > On Thu, 2017-10-26 at 11:52 +0800, 吳重毅 wrote: > > > Thankd for fixing, i am able compile now. > > > > Ok, great. > > > > > But when i load the modules and firmware.bin, it crash. > > > > Crap, sorry about that. I'll see what I can do about it right now. > > Ok, I see the bug. Not sure yet how to fix, but yeah. I thought I said I'd fixed it, but don't see that email. Anyway, I did, but Luca found another bug ... where it compiles, this fixes it, I think: But on older kernels this doesn't compile, and needs more work. johannes --- To unsubscribe from this list: send the line "unsubscribe backports" in --- a/compat/backport-4.12.c +++ b/compat/backport-4.12.c @@ -225,6 +225,7 @@ int bp_extack_genl_register_family(struct genl_family *family) /* copy this since the family might access it directly */ family->attrbuf = copy->family.attrbuf; + family->mcgrp_offset = copy->family.mcgrp_offset; mutex_lock(&copies_mutex); list_add_tail(©->list, &copies_list);