diff mbox series

[v2] backports: add header file for function memcmp

Message ID 20180822030554.GA73398@aremote01.aus.cypress.com (mailing list archive)
State Accepted
Headers show
Series [v2] backports: add header file for function memcmp | expand

Commit Message

Winnie Chang Aug. 22, 2018, 3:06 a.m. UTC 
Function memcmp is implicit declaration on kernel 4.9.88 ARM platform.
backport-include/keys/asymmetric-type.h uses function memcmp but its
caller compat/verification/verify.c and all its related header files
do not include string.h. The header file is usually included from
arch/arm/include/asm, but in this configuration, it doesn't. We need
to be safe and insure string.h is there.

Signed-off-by: Winnie Chang <winnie.chang@cypress.com>
---
 backport/backport-include/keys/asymmetric-type.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Johannes Berg Aug. 22, 2018, 7:18 a.m. UTC | #1 
On Tue, 2018-08-21 at 22:06 -0500, Winnie Chang wrote:
> Function memcmp is implicit declaration on kernel 4.9.88 ARM platform.
> backport-include/keys/asymmetric-type.h uses function memcmp but its
> caller compat/verification/verify.c and all its related header files
> do not include string.h. The header file is usually included from
> arch/arm/include/asm, but in this configuration, it doesn't. We need
> to be safe and insure string.h is there.

Makes sense, thanks!

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in
diff mbox series

Patch

diff --git a/backport/backport-include/keys/asymmetric-type.h b/backport/backport-include/keys/asymmetric-type.h
index ee9c418..5744de9 100644
--- a/backport/backport-include/keys/asymmetric-type.h
+++ b/backport/backport-include/keys/asymmetric-type.h
@@ -2,6 +2,8 @@ 
 #define __BP_ASYMMETRIC_TYPE_H
 #ifdef CPTCFG_BPAUTO_BUILD_SYSTEM_DATA_VERIFICATION
 
+#include <linux/string.h>
+
 struct asymmetric_key_id {
 	unsigned short	len;
 	unsigned char	data[];