| Message ID | 1658383473-32188-1-git-send-email-quic_zijuhu@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Bluetooth: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING | expand |
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 21 Jul 2022 14:04:29 +0800 you wrote: > This patch series remove bluetooth HCI_QUIRK_BROKEN_ERR_DATA_REPORTING > the quirk was introduced by 'commit cde1a8a99287 ("Bluetooth: btusb: Fix > and detect most of the Chinese Bluetooth controllers")' to mark HCI > commands HCI_Read|Write_Default_Erroneous_Data_Reporting broken within BT > device driver, but the reason why these two HCI commands are broken is > that feature "Erroneous Data Reporting" is not enabled by firmware, so BT > core driver can addtionally check feature bit "Erroneous Data Reporting" > instead of the quirk to decide if these two HCI commands work fine. > > [...] Here is the summary with links: - [v2,1/4] Bluetooth: hci_sync: Check LMP feature bit instead of quirk https://git.kernel.org/bluetooth/bluetooth-next/c/ca832c5e178f - [v2,2/4] Bluetooth: btusb: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA https://git.kernel.org/bluetooth/bluetooth-next/c/9ee3f82b5015 - [v2,3/4] Bluetooth: btusb: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for fake CSR https://git.kernel.org/bluetooth/bluetooth-next/c/08454349a054 - [v2,4/4] Bluetooth: hci_sync: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING https://git.kernel.org/bluetooth/bluetooth-next/c/4d22b9f84c44 You are awesome, thank you!
This patch series remove bluetooth HCI_QUIRK_BROKEN_ERR_DATA_REPORTING the quirk was introduced by 'commit cde1a8a99287 ("Bluetooth: btusb: Fix and detect most of the Chinese Bluetooth controllers")' to mark HCI commands HCI_Read|Write_Default_Erroneous_Data_Reporting broken within BT device driver, but the reason why these two HCI commands are broken is that feature "Erroneous Data Reporting" is not enabled by firmware, so BT core driver can addtionally check feature bit "Erroneous Data Reporting" instead of the quirk to decide if these two HCI commands work fine. BLUETOOTH CORE SPECIFICATION Version 5.3 | Vol 2, Part C | page 587 This feature indicates whether the device is able to support the Packet_Status_Flag and the HCI commands HCI_Write_Default_- Erroneous_Data_Reporting and HCI_Read_Default_Erroneous_- Data_Reporting. Only QCA and fake CSR btusb device driver set the quirk currently since the feature "Erroneous Data Reporting" are not enabled by their firmware so we also remove the quirk from their device driver. Changes since v1: - split changes to solve build error between patches - optimize commit messages Zijun Hu (4): Bluetooth: hci_sync: Check LMP feature bit instead of quirk Bluetooth: btusb: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for QCA Bluetooth: btusb: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING for fake CSR Bluetooth: hci_sync: Remove HCI_QUIRK_BROKEN_ERR_DATA_REPORTING drivers/bluetooth/btusb.c | 2 -- include/net/bluetooth/hci.h | 12 +----------- net/bluetooth/hci_sync.c | 7 ++----- 3 files changed, 3 insertions(+), 18 deletions(-)