[0/6] Add support for multiple BISes

Message

Silviu Florian Barbulescu Oct. 26, 2023, 2:50 p.m. UTC

Add support for multiple BIS-es
How to configure multiple BIS-es:
In main.conf set the number of required BISes in NumberOfBISes field of
the newly added Bcast section.
In the base_lc3_48_4_1 struct set the configuration for the base
Continue with the registering endpoint for the broadcast source
endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x06
Use the endpoint.config command to set the BIS codec configuration by
specifying the BIS when prompted by the command
endpoint.config /org/bluez/hci0/pac_bcast0 /local/endpoint/ep0 48_4_1
[/local/endpoint/ep0] BIG (value): 0
[/local/endpoint/ep0] BIS (value): 1
Use this endpoint config command to configure all the BISes
After all BISes are configured, use the transports to send data


Claudia Draghicescu (2):
  bap: Fix source+sink endpoint registration
  bap: Fix source+sink endpoint registration

Silviu Florian Barbulescu (4):
  src: Add support for defining the number of BISes in the main.conf
  Add support for multiple BISes
  profiles/audio/transport.c: Add support for multiple BISes
  client/player.c: Add support for multiple BISes

 btio/btio.c                |   4 +-
 client/player.c            |  57 ++++-
 profiles/audio/bap.c       | 483 +++++++++++++++++++++++++------------
 profiles/audio/media.c     |   3 +-
 profiles/audio/transport.c |  49 ++--
 src/btd.h                  |   6 +
 src/main.c                 |  10 +
 src/main.conf              |   8 +
 src/shared/bap.c           | 254 ++++++++++++++-----
 src/shared/bap.h           |  39 ++-
 unit/test-bap.c            |  12 +-
 11 files changed, 678 insertions(+), 247 deletions(-)


base-commit: 00fdb61d56161f523e975b4c044030f4b40abb6d

Comments

Luiz Augusto von Dentz Oct. 26, 2023, 9:32 p.m. UTC | #1

Hi Silviu,

On Thu, Oct 26, 2023 at 7:51 AM Silviu Florian Barbulescu
<[e-mail]> wrote:
>
> Add support for multiple BIS-es
> How to configure multiple BIS-es:
> In main.conf set the number of required BISes in NumberOfBISes field of
> the newly added Bcast section.
> In the base_lc3_48_4_1 struct set the configuration for the base
> Continue with the registering endpoint for the broadcast source
> endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x06
> Use the endpoint.config command to set the BIS codec configuration by
> specifying the BIS when prompted by the command
> endpoint.config /org/bluez/hci0/pac_bcast0 /local/endpoint/ep0 48_4_1
> [/local/endpoint/ep0] BIG (value): 0
> [/local/endpoint/ep0] BIS (value): 1
> Use this endpoint config command to configure all the BISes
> After all BISes are configured, use the transports to send data

Don't think it is a good idea to use main.conf for entering this, in
fact I think we should get rid of BIS and instead have it as number of
BIS because we no longer use the BIS ID as Adv Set ID, or perhaps we
can use the max transport as number of BIS since each BIS shall have a
correspondent transport/socket, either way it shall be the upper layer
that defines how many BIS to configure.

>
> Claudia Draghicescu (2):
>   bap: Fix source+sink endpoint registration
>   bap: Fix source+sink endpoint registration
>
> Silviu Florian Barbulescu (4):
>   src: Add support for defining the number of BISes in the main.conf
>   Add support for multiple BISes
>   profiles/audio/transport.c: Add support for multiple BISes
>   client/player.c: Add support for multiple BISes
>
>  btio/btio.c                |   4 +-
>  client/player.c            |  57 ++++-
>  profiles/audio/bap.c       | 483 +++++++++++++++++++++++++------------
>  profiles/audio/media.c     |   3 +-
>  profiles/audio/transport.c |  49 ++--
>  src/btd.h                  |   6 +
>  src/main.c                 |  10 +
>  src/main.conf              |   8 +
>  src/shared/bap.c           | 254 ++++++++++++++-----
>  src/shared/bap.h           |  39 ++-
>  unit/test-bap.c            |  12 +-
>  11 files changed, 678 insertions(+), 247 deletions(-)
>
>
> base-commit: 00fdb61d56161f523e975b4c044030f4b40abb6d
> --
> 2.39.2
>