mbox series

[BlueZ,0/2] transport: Fix select/unselect reply missing

Message ID 20241025142842.46566-1-iulia.tanasescu@nxp.com (mailing list archive)
Headers show
Series transport: Fix select/unselect reply missing | expand

Message

Iulia Tanasescu Oct. 25, 2024, 2:28 p.m. UTC 
When a transport is selected from bluetoothctl, a reply is expected.
Currently, if the method call is successful, no reply is sent, causing
the following error message in bluetoothctl:

transport.Failed to select: org.freedesktop.DBus.Error.NoReply

The same error can be reproduced for the unselect method.

This patch updates the select and unselect methods to send reply
messages. It also fixes the shell prints in client/player.c,
when the replies for select/unselect are received.

Iulia Tanasescu (2):
  transport: Send reply to select/unselect
  client/player: Fix select/unselect reply prints

 client/player.c            | 4 ++--
 profiles/audio/transport.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)


base-commit: 806a552d53c787c0ddea9328a09b0ef124bca26e

Comments

patchwork-bot+bluetooth@kernel.org Oct. 25, 2024, 7:40 p.m. UTC | #1 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 25 Oct 2024 17:28:40 +0300 you wrote:
> When a transport is selected from bluetoothctl, a reply is expected.
> Currently, if the method call is successful, no reply is sent, causing
> the following error message in bluetoothctl:
> 
> transport.Failed to select: org.freedesktop.DBus.Error.NoReply
> 
> The same error can be reproduced for the unselect method.
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/2] transport: Send reply to select/unselect
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=36b26283cee3
  - [BlueZ,2/2] client/player: Fix select/unselect reply prints
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8c8ca715e05f

You are awesome, thank you!